, Chasel ; Kubacki, Michael A
Subject: RE: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg:
Update PCDs to enable stack sharing
Actually looking at the CoffeeLake FSP Integration Guide it states the minimum
stack size to be 160KB (0x28000) so I guess a slight revision to my previous
On Behalf Of Nate DeSimone
Sent: Friday, December 13, 2019 2:14 PM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Kubacki, Michael A
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg:
Update PCDs to enable stack sharing
Hi Prince,
Looking at your patch I
Hi Prince,
Looking at your patch I see the following two changes:
1. Reduce FSP Temp Ram size from 152KB to 64KB:
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000
+ gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x1
This makes sense because now that the FSP is using the si
Hi Nate,
Which 256KB are you referring to ?
The temporary ram size was reduced from 152KB (0x26000) to 64KB (0x1)
With stack sharing enabled in FSP, temp ram size of 0x26000 causes system to
hang during memory training.
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize |0x26000
+
Hi Prince,
Is 256KB really necessary? Could you try the 152KB (0x26000) that we had
previously?
Thanks,
Nate
-Original Message-
From: Agyeman, Prince
Sent: Wednesday, December 11, 2019 5:13 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Kubacki, Michael A
Su
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, December 11, 2019 5:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Agyeman, Prince
> Sent: Thursday, December 12, 2019 9:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs
> t
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409
Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing.
This fixes the boot failure seen with the latest Coffee Lake (CFL)
FSP binary (v 7.0.68.41)
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
