Re: [edk2-devel] [edk2-platforms] [PATCH 3/5] BoardModulePkg: Added Pcds Sio Driver

2019-11-04 Thread Kubacki, Michael A
Please fix style formatting, especially in this function: /** Gets the number of devices in Table of SIO Controllers mDeviceInfo @retval Number of enabled devices in Table of SIO Controllers. **/ UINTN EFIAPI GetDeviceCount( VOID ){ UINTNCount; Count =

Re: [edk2-devel] [edk2-platforms] [PATCH 3/5] BoardModulePkg: Added Pcds Sio Driver

2019-11-01 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Friday, November 1, 2019 12:51 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms] [PATCH 3/5

[edk2-devel] [edk2-platforms] [PATCH 3/5] BoardModulePkg: Added Pcds Sio Driver

2019-11-01 Thread Agyeman, Prince
Included PCDs to the Sio dxe driver, to allow the enable/disable of Ps2 keyboard/mouse, UART1 and UART2 com ports. Renamed the Sio driver's base name Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../LegacySioDxe/LegacySioDxe.inf | 15