-devel] [edk2-platforms] [PATCH v1 0/9] IpmiFeaturePkg: Add IPMI
transport drivers
From: Isaac Oram
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Implement an open source generic IPMI transport driver.
Provides the ability to communicate with a BMC over IPMI in MinPlatform board
Overall structure looks good. For the series:
Reviewed-by: Sai Chaganty
There are few, rather general comments which I think can be queued up as
on-going improvement after the initial check-in.
1. Copyright year for newly added files should begin with the current year //
this is probably
.groups.io On Behalf Of Michael Kubacki
Sent: Wednesday, March 3, 2021 11:23 AM
To: devel@edk2.groups.io; Desimone, Nathaniel L
Cc: Oram, Isaac W ; Chaganty, Rangasai V
; Liming Gao ; Michael Kubacki
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1 0/9] IpmiFeaturePkg: Add
IPMI transport
.groups.io; Desimone, Nathaniel L
Cc: Oram, Isaac W ; Chaganty, Rangasai V
; Liming Gao ; Michael
Kubacki
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1 0/9] IpmiFeaturePkg: Add
IPMI transport drivers
Looked over the series at a high-level and the feature structure looks fine
Looked over the series at a high-level and the feature structure looks
fine. For the series:
Acked-by: Michael Kubacki
I didn't look closely at implementation but there's a few things I noticed.
There's a few typos. I'd suggest running a spell check to clean those
up. Some quick examples:
From: Isaac Oram
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Implement an open source generic IPMI transport driver.
Provides the ability to communicate with a BMC over IPMI
in MinPlatform board packages.
New changes:
1. Added GenericIpmi
2. Added IPMI base libs
3. Added
