[edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

2019-07-10 Thread Michael D Kinney
From: Gary Lin The scripts for PlatformCapsuleGcc.dsc need Vlv.ROM. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh b/

Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

2019-07-10 Thread Sun, Zailiang
Gary, I suggest remove the first line "From: Gary Lin " from the description section since you have appended the "signed-off-by" declaration. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ;

Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

2019-07-10 Thread Gary Lin
On Thu, Jul 11, 2019 at 04:52:10AM +, Sun, Zailiang wrote: > Gary, > > I suggest remove the first line "From: Gary Lin " from the > description section since you have appended the "signed-off-by" declaration. > Hi Zailiang, That is added by Mike. I'm totally fine if you remove it when pus

Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

2019-07-12 Thread Michael D Kinney
devel@edk2.groups.io; Sun, Zailiang > > Cc: Kinney, Michael D ; Qian, > Yi > Subject: Re: [edk2-devel] [edk2-platforms Patch 10/28] > Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM > > On Thu, Jul 11, 2019 at 04:52:10AM +, Sun, Zailiang > wrote: > > Gary, > >

Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM

2019-07-12 Thread Sun, Zailiang
10, 2019 11:09 PM > To: devel@edk2.groups.io; Sun, Zailiang > > Cc: Kinney, Michael D ; Qian, > Yi > Subject: Re: [edk2-devel] [edk2-platforms Patch 10/28] > Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM > > On Thu, Jul 11, 2019 at 04:52:10AM +, Sun, Zailiang > wrote: