Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureCoreDxe: fix Redfish event issue.

2023-12-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Ah sorry, I missed that one. Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, December 7, 2023 7:46 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [edk2-redfish-clie

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureCoreDxe: fix Redfish event issue.

2023-12-06 Thread Nickle Wang via groups.io
Hi Abner, > If we use PCD here, then we have to also update CreateEventEx in the > RedfishFeatureCoreEntryPoint. Create the event using > REDFISH_FEATURE_CORE_TPL. Yes, I also modify RedfishFeatureCoreEntryPoint in below together. > } > > /** > @@ -670,7 +682,7 @@ RedfishFeatureCoreEntryPo

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureCoreDxe: fix Redfish event issue.

2023-12-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, one comment below. > -Original Message- > From: Nickle Wang > Sent: Wednesday, December 6, 2023 4:57 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] > RedfishClientP

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureCoreDxe: fix Redfish event issue.

2023-12-06 Thread Nickle Wang via groups.io
RedfishFeatureDriverStartup is callback function at TPL_CALLBACK level. In this function, Redfish events are signaled. However, Redfish events are created in TPL_CALLBACK level too. As the result, Redfish events cannot be invoked in desired sequence. Decrease the TPL to TPL_APPLICATION level inside