> ; devel@edk2.groups.io
> Cc: Gao, Liming ; Rebecca Cran
> ; Zimmer, Vincent ; Leif
> Lindholm ; Andrew Fish ;
> Feng, Bob C ; Yang, Yuting2
> ; Hartung, Stephen ;
> Narayanan, Bimod
> Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python
> VfrCompile
7;Leif Lindholm' ; 'Andrew Fish'
Cc: Feng, Bob C ; Yang, Yuting2 ;
devel@edk2.groups.io; Hartung, Stephen
Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python
VfrCompiler implementation
Hi Liming,
I know your point. Would you like to start reviewing it and give us more
Yuting2 mailto:yuting2.y...@intel.com>>; Hartung,
Stephen mailto:stephen.hart...@intel.com>>
δΈ»ι’: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler
implementation
Hi Liming,
Is this feature been tested and reviewed these two weeks? π
Thanks,
Christine
From: devel@edk
On Thu, Dec 7, 2023 at 9:08β―AM Yuwei Chen wrote:
>
> Hi Liming,
>
>
>
> Is this feature been tested and reviewed these two weeks? π
Two questions:
1) What testing strategy do you have to test for regressions in such a
huge rewrite?
2) What's the point in shipping this to upstream if you're not a
ups.io; Chen, Christine
> Cc: Gao, Liming ; Rebecca Cran
> ; Zimmer, Vincent ; Kinney,
> Michael D ; Leif Lindholm
> ; Andrew Fish ; Feng, Bob C
> ; Yang, Yuting2 ; Hartung,
> Stephen
> Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python
> VfrCompiler imp
ing ; Rebecca Cran
> ; Zimmer, Vincent ; Leif
> Lindholm ; Andrew Fish ;
> Feng, Bob C ; Yang, Yuting2
> ; Hartung, Stephen ;
> Kinney, Michael D
> Subject: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python
> VfrCompiler implementation
>
> There are several adv
Christine:
I can't directly reply to the original mail because it is too large. This
is a new feature to add python version VfrCompiler. I don't think we have
enough time to review the design and implementation. Although it has no real
impact, its code may have many change in future. So, I sugges
Hi Liming,
I know your point. Would you like to start reviewing it and give us more
feedbacks? We really hope it can be merged as soon as possible.
We can do the merging after the stable tag, but just like you said, maybe we
need to review it firstly.
Looking forward to your feedbacks, and I th
, Christine ; Gao, Liming
; 'Rebecca Cran' ; Zimmer, Vincent
; Kinney, Michael D ;
'Leif Lindholm' ; 'Andrew Fish'
ζι: Feng, Bob C ; Yang, Yuting2 ;
Hartung, Stephen
δΈ»ι’: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler
implementation
Hi Li