Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2024-03-06 Thread Chang, Abner via groups.io
> ; devel@edk2.groups.io > Cc: Gao, Liming ; Rebecca Cran > ; Zimmer, Vincent ; Leif > Lindholm ; Andrew Fish ; > Feng, Bob C ; Yang, Yuting2 > ; Hartung, Stephen ; > Narayanan, Bimod > Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python > VfrCompile

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2024-01-09 Thread Yuwei Chen
ing ; Rebecca Cran > ; Zimmer, Vincent ; Leif > Lindholm ; Andrew Fish ; > Feng, Bob C ; Yang, Yuting2 > ; Hartung, Stephen ; > Kinney, Michael D > Subject: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python > VfrCompiler implementation > > There are several adv

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-12-15 Thread Michael D Kinney
ups.io; Chen, Christine > Cc: Gao, Liming ; Rebecca Cran > ; Zimmer, Vincent ; Kinney, > Michael D ; Leif Lindholm > ; Andrew Fish ; Feng, Bob C > ; Yang, Yuting2 ; Hartung, > Stephen > Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python > VfrCompiler imp

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-12-15 Thread Pedro Falcato
On Thu, Dec 7, 2023 at 9:08 AM Yuwei Chen wrote: > > Hi Liming, > > > > Is this feature been tested and reviewed these two weeks?  Two questions: 1) What testing strategy do you have to test for regressions in such a huge rewrite? 2) What's the point in shipping this to upstream if you're not

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-12-14 Thread Yuting Yang
phen mailto:stephen.hart...@intel.com>> 主题: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation Hi Liming, Is this feature been tested and reviewed these two weeks?  Thanks, Christine From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@ed

回复: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-12-11 Thread gaoliming via groups.io
, Christine ; Gao, Liming ; 'Rebecca Cran' ; Zimmer, Vincent ; Kinney, Michael D ; 'Leif Lindholm' ; 'Andrew Fish' 抄送: Feng, Bob C ; Yang, Yuting2 ; Hartung, Stephen 主题: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation Hi Liming, Is this feature been

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-12-07 Thread Yuwei Chen
Fish' Cc: Feng, Bob C ; Yang, Yuting2 ; devel@edk2.groups.io; Hartung, Stephen Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation Hi Liming, I know your point. Would you like to start reviewing it and give us more feedbacks? We really hope

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-11-12 Thread Yuwei Chen
Hi Liming, I know your point. Would you like to start reviewing it and give us more feedbacks? We really hope it can be merged as soon as possible. We can do the merging after the stable tag, but just like you said, maybe we need to review it firstly. Looking forward to your feedbacks, and I

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-11-09 Thread gaoliming via groups.io
Christine: I can't directly reply to the original mail because it is too large. This is a new feature to add python version VfrCompiler. I don't think we have enough time to review the design and implementation. Although it has no real impact, its code may have many change in future. So, I