[edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Fix the gBlackBoxEfiSimplePointerProtocolGuid value

2019-08-19 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571 Besides, EOL is converted to CRLF. Cc: Supreeth Venkatesh Signed-off-by: Eric Jin --- uefi-sct/SctPkg/UEFI/UEFI.dec | 206 +- 1 file changed, 103 insertions(+), 103 deletions(-) diff --git a/uefi-sct/SctPk

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Fix the gBlackBoxEfiSimplePointerProtocolGuid value

2019-08-20 Thread Supreeth Venkatesh
Hi Eric, Comments inline. On Tue, 2019-08-20 at 00:07 -0500, Eric Jin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571 > Besides, EOL is converted to CRLF. If you mix EOL conversion to CRLF and bug fix for gBlackBoxEfiSimplePointerProtocolGuid, it is difficult to review the actua

Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Fix the gBlackBoxEfiSimplePointerProtocolGuid value

2019-08-20 Thread Eric Jin
Reasonable. Will split it in v2. Best Regards Eric -Original Message- From: devel@edk2.groups.io On Behalf Of Supreeth Venkatesh Sent: Wednesday, August 21, 2019 2:41 AM To: Jin, Eric ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Fix the