Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Heinrich Schuchardt
On 27.02.24 07:37, Chao Li wrote: DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran
The patch is upstreamed through the commit: https://github.com/tianocore/edk2-test/commit/cabb98d44be94e7547605435a0be7c4946d10f8b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116022): https://edk2.groups.io/g/devel/message/116022 Mute

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li
, 2024 1:34 PM *To:* devel@edk2.groups.io; G Edhaya Chandran *Subject:* Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran
-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks, Chao On 2024/2/27 15:50, G Edhaya Chandran wrote: Hi Li Chao, Thank you for the solution. Reviewed OK

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li
Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks, Chao On 2024/2/27 15:50, G Edhaya Chandran wrote: Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread G Edhaya Chandran
Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116007): https://edk2.groups.io/g/devel/message/116007 Mute This Topic:

[edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li
DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will point to an unknown address. So fix