Re: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security implications in ECDH and BN.

2022-07-14 Thread Heng Luo
Reviewed-by: Heng Luo > -Original Message- > From: Tan, Ming > Sent: Friday, July 15, 2022 1:35 PM > To: devel@edk2.groups.io; Li, Yi1 > Cc: Luo, Heng > Subject: RE: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed > possible security implic

Re: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security implications in ECDH and BN.

2022-07-14 Thread Tan, Ming
Reviewed-by: Ming Tan -Original Message- From: devel@edk2.groups.io On Behalf Of yi1 li Sent: Friday, July 15, 2022 1:30 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Tan, Ming ; Luo, Heng Subject: [edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security

[edk2-devel] [staging/crypto-new-api PATCH] CryptoPkg: Fixed possible security implications in ECDH and BN.

2022-07-14 Thread yi1 li
1. Origenal code mixes up the input/output parameters for the BN_rshift() function - the output is actually the first parameter and not the second one. Now we correct BnRShift() param order. 2. NID_X9_62_prime192v1() and NID_secp224r1 prohibited by Intel Crypto/TLS Guidelines (due to being