Re: [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile

2023-12-10 Thread Mike Beaton
I've sent a patch to this list (with some kind of proposed comment about the issues!) under separate cover. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112260): https://edk2.groups.io/g/devel/message/112260 Mute This Topic:

Re: [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile

2023-12-10 Thread Mike Beaton
> Removing STATIC means that (modulo LTO) the compiler will not know > whether or not the definition can be dropped. It also pollutes the > global namespace. > > IMO, lack of the use of STATIC where appropriate is a severe issue > with the EDK2 codebase. Removing STATIC to appease compiler >

Re: [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile

2023-12-10 Thread Ard Biesheuvel
On Sun, 10 Dec 2023 at 01:26, Mike Beaton wrote: > > Dear Ard, > > This one is about RELEASE CLANGPDB OVMF, which currently does not > compile, giving: > > ``` > /home/mjsbeaton/OpenSource/edk2/OvmfPkg/VirtioSerialDxe/VirtioSerial.c:28:22: > error: variable 'EventNames' is not needed and will not

[edk2-devel] RELEASE CLANGPDB OVMF currently does not compile

2023-12-09 Thread Mike Beaton
Dear Ard, Thanks for your attention on my other issue, about NOOPT CLANGDWARF OVMF. This one is about RELEASE CLANGPDB OVMF, which currently does not compile, giving: ``` /home/mjsbeaton/OpenSource/edk2/OvmfPkg/VirtioSerialDxe/VirtioSerial.c:28:22: error: variable 'EventNames' is not needed and