回复: 回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

2024-04-14 Thread gaoliming via groups.io
Thanks for your update. Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Taylor Beebe > 发送时间: 2024年4月10日 3:43 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: 'Rebecca Cran' ; 'Bob Feng' > ; 'Yuwei Chen' > 主题: Re: 回复: 回复: [edk2-devel]

Re: 回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

2024-04-09 Thread Taylor Beebe
Hi Liming, I made a mistake in patch 2 of the v2 series. In v3, lines 126 and 144 of WorkspaceCommon.py update the check to: `LibraryClassName[4:].isdigit()` instead of `LibraryClass[4:].isdigit()` Can you re-review with this change? -Taylor On 4/1/2024 6:37 PM, gaoliming via groups.io

回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

2024-04-01 Thread gaoliming via groups.io
an' ; 'Bob Feng' > ; 'Yuwei Chen' > 主题: Re: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include > and Library Matching > > Hi Liming, > > Each patch describes the issue being fixed with an example. > > I created a bugzilla and assigned it to me for Patch 1: > h