Re: FW: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

2019-05-07 Thread Fan, ZhijuX
b C > > Subject: Re: FW: [edk2-devel] [PATCH V2] BaseTools:improve code to > support C files with .C suffixes > > Hi Fan Zhiju, > > But where does the string come from that contains a .C suffix? > Is the tool internally converting things to uppercase, or is some s

Re: FW: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

2019-05-07 Thread Leif Lindholm
Hi Fan Zhiju, But where does the string come from that contains a .C suffix? Is the tool internally converting things to uppercase, or is some source file in the build incorrectly named? I am asking because it is not clear to me whether the patch resolves a problem or hides one. Best Regards,

FW: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

2019-05-06 Thread Fan, ZhijuX
This problem has nothing to do with the file system, We just use the filename as a string to compare with other strings Our unittest tested minplatform, Ovmf. This problem was found when building a platform inside Intel. We've tested it on Linux and Windows. Any question, please let me know.