Hi Chasel,
My only feedback is let's not add the EDK1 style GUID definition to
FspNonVolatileStorageHob2.h. It is redundant with the EDK2 style definition.
Please see inline.
With that change...
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, Oct
Thanks Nate! I will remove it.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Saturday, October 2, 2021 6:15 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Adopt FSP 2.3 specification.
>
> Hi Chasel,
>
> My
Patch pushed:
https://github.com/tianocore/edk2/commit/4cc1458dbe004b1d70534caa55f475f6d19fe14a
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, October 1, 2021 4:29 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ma, Maurice
> ; Desimone, Nathaniel L
> ; Z