Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Leif Lindholm
On 2024-03-12 09:58, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 17:56, Leif Lindholm wrote: On 2024-03-12 09:50, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: On 2024-03-12 08:17, Ard Biesheuvel wrote: From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Ard Biesheuvel
On Tue, 12 Mar 2024 at 17:56, Leif Lindholm wrote: > > On 2024-03-12 09:50, Ard Biesheuvel wrote: > > On Tue, 12 Mar 2024 at 17:38, Leif Lindholm > > wrote: > >> > >> On 2024-03-12 08:17, Ard Biesheuvel wrote: > >>> From: Ard Biesheuvel > >>> > >>> NonCoherentIoMmuSetAttribute() does nothing ex

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Leif Lindholm
On 2024-03-12 09:50, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: On 2024-03-12 08:17, Ard Biesheuvel wrote: From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does nothing except return EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI bus

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Ard Biesheuvel
On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: > > On 2024-03-12 08:17, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > NonCoherentIoMmuSetAttribute() does nothing except return > > EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI > > bus driver will fail a PCI I

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Leif Lindholm
On 2024-03-12 08:17, Ard Biesheuvel wrote: From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does nothing except return EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI bus driver will fail a PCI I/O Map() operation if the SetAttributes fails. So return EFI_SUCCESS ins