On Thu, Sep 23, 2021 at 15:20:41 +, Jeff Brasen wrote:
> That looks like something I missed and looks good, do you need me to
> make a v4 or will you just add that in.
Nah, I just folded it in.
Pushed as 79019c7a4228..7ea7f9c07757.
Thanks!
> When I built I just used our
> application that
That looks like something I missed and looks good, do you need me to make a v4
or will you just add that in. When I built I just used our application that has
the guid in our inf so missed this.
>From my looking at it AndroidFastBootApp doesn't seem to use this lib.
> -Original
Hi Jeff,
I was about to say "no more issues", and then I went to build
EmbeddedPkg, and it turns out this fails in
Applications/AndroidBootApp due to the missing dependency on
gEfiLoadFile2ProtocolGuid in AndroidBootImgLib.inf.
(Why this doesn't break AndroidFastbootApp build as well is not
Hi Jeff,
I do not ever work on EDK soon after this patch set was merged. It is
long time since then.
I am sorry that I have no comments other than no objections on your patch.
Regards,
Jun
Jeff Brasen 于2021年9月22日周三 上午12:33写道：
>
> Jun/Others,
>
> Any additional comments on this patch series?
Jun/Others,
Any additional comments on this patch series?
Thanks,
Jeff
From: Jeff Brasen
Sent: Tuesday, September 14, 2021 10:57 AM
To: Leif Lindholm
Cc: devel@edk2.groups.io ; daniel.schae...@hpe.com
; abner.ch...@hpe.com ;
ardb+tianoc...@kernel.org ;
So for patch 3: This is only a change if mAndroidBootImg->UpdateDtb == NULL.
This seemed like a bug as we would not add the initrd values nor would we use
the fdt from the BootImg if that is where the device tree was sourced from.
It seems like either we should require UpdateDtb to be
Hi Jeff,
Thanks for this.
This set looks good to me, with a slight question mark wrt behaviour
compatibility with previous versions for 3/4.
(I think it's fine, but I'm a bear of very little brain, and it's been
several years since I reviewed this code, and even longer since I
really interacted
