Corrected initialisation of one of data structures used to transmit USB
control messages. Mistake had no practical effects but fixing to be on safe
side.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Andy Hayes
---
Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-
1
Corrected initialisation of one of data structures used to transmit USB
control messages. Mistake had no practical effects but fixing to be on safe
side.
https://github.com/andy-hayes/edk2-platforms
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Andy Hayes (1):
Drivers/DisplayLink/DisplayLinkPkg Di
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2185
It is a request to add FMP test to IHV
Eric Jin (3):
uefi-sct/SctPkg: Add FMP test source to IHVSCT
uefi-sct/SctPkg: Add Fmp test to IHVSCT build/configuration
uefi-sct/SctPkg: Add FMP test to IHV SCT binary package
uefi-sct/SctPkg/U
From: shrishail patil
Cc: Supreeth Venkatesh
Cc: Eric Jin
Signed-off-by: shrishail patil
---
uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 2 ++
uefi-sct/SctPkg/Config/Data/Category.ini | 8
2 files changed, 10 insertions(+)
diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-sct/SctP
From: shrishail patil
Cc: Supreeth Venkatesh
Cc: Eric Jin
Signed-off-by: shrishail patil
---
uefi-sct/SctPkg/CommonGenFramework.bat | 3 ++-
uefi-sct/SctPkg/CommonGenFramework.sh | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/SctPkg/CommonGenFramework.bat
b
Due to needs a tackling the deficiency of the AP API, is necessary to ensure
that in non-blocking mode
previous AP executed command is finished before start new one.
To remedy above:
1) execute AcquireSpinLock instead AcquireSpinLockOrFail - this will ensure
time "window" to eliminate potent
Due to needs a tackling the deficiency of the AP API, is necessary to ensure
that in non-blocking mode
previous AP executed command is finished before start new one.
To remedy above:
1) execute AcquireSpinLock instead AcquireSpinLockOrFail - this will ensure
time "window" to eliminate potent
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2087
In CryptHkdf.c line 42
EVP_PKEY_CTX *pHkdfCtx;
Variable pHkdfCtx begins with lower case 'p',
which should be acceptable because it it is a pointer.
(Refer to CCS_2_1_Draft, 4.3.3.3)
So ECC tool should be improved to handle issues like th
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2080
After checking that if the build can't
ignore Autogen due to there is no compelet autogen files,
the build tool need to do a completely Autogen.
This patch is to fix a bug that if AutoGen
can't be skiped, the SkipAutoGen flag
need to set to
Add a function that checks if a target language is in the supported
languages list. Add some calls to this function where appropriate in
UefiLib.c
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Tom Zhao
---
Notes:
v3:
- Add comment about usage for RFC4646 and ISO-639
v4:
-
On 09/09/19 20:03, Kubacki, Michael A wrote:
> I completely understand the need for granular breakup of changes for code
> review and future maintenance. I would not send this as a single patch on the
> mailing list for formal code review. Due to the size of the change, the main
> point here was
Tom:
I miss one minor comments on doxygen style in function header comments.
Please see below.
The code logic is good to me. Reviewed-by: Liming Gao
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of Tom Zhao
> Sent: Wednesday, September 11,
Add a function that checks if a target language is in the supported
languages list. Add some calls to this function where appropriate in
UefiLib.c
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Tom Zhao
---
Notes:
v3:
- Add comment about usage for RFC4646 and ISO-639
v4:
-
On 09/11/19 10:23, Damian Nikodem wrote:
> Due to needs a tackling the deficiency of the AP API, is necessary to ensure
> that in non-blocking mode
> previous AP executed command is finished before start new one.
>
> To remedy above:
> 1) execute AcquireSpinLock instead AcquireSpinLockOrFail
Reviewed-by: Liming Gao
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of Tom Zhao
> Sent: Wednesday, September 11, 2019 10:40 PM
> To: [email protected]
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2-devel] [PATCH v5 1/1] MdePkg:
On 09/11/19 03:45, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039
>
> Current implementation not checks system mode before using
> PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or
> PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This patch check
> the mode before usin
Hi Ching JenX,
Please see two comments inline.
On 2019.09.11 07:08, Cheng, Ching JenX wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182
In order to support VS2019,
the first thing need to do is add 2019 toolchain on tools_def.template
Change-Id: Id52abdc9762cf06bb9a38bbfd1153608
After upgrading the CI system we use for building the ArmVirtPkg
targets, we started seeing failures due to the NOOPT build running
out of space when using the CLANG38 toolchain definition combined
with clang 7.
We really don't want to increase the FD/FV sizes in general to
accommodate this, so pa
What changed from v1:
* Added detailed commit messages
This patch series fix gcc build issues seen
in SimicsOpenBoardPkg.
Patches were tested on GCC 5
Agyeman, Prince (3):
AdvancedFeaturePkg: Fix GCC build
SimicsOpenBoardPkg: Fix GCC build issues
SimicsIch10Pkg: Fix GCC build issues
.../
From: "Agyeman, Prince"
Changed include file name Smbios.h to
SmBios.h to fix gcc file not found
build issue, due to case sensitive
file names in Linux
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162
Cc: David Wei
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Micha
From: "Agyeman, Prince"
Removed Status variable as the SmmClear
function always returns EFI_SUCCESS.
Refer to the Smmclear function for
details
Removed SpiBaseAddress variable as this
address was never used in the SendSpiCmd function.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162
Cc
From: "Agyeman, Prince"
Removed unused functions in secMain.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162
Cc: David Wei
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../PlatformBootManagerLib/B
On 09/10/19 17:58, Igor Mammedov wrote:
> On Mon, 9 Sep 2019 21:15:44 +0200
> Laszlo Ersek wrote:
[...]
> It looks like fwcfg smi feature negotiation isn't reusable in this case.
> I'd prefer not to add another device just for another SMI feature
> negotiation/activation.
I thought it could be
Reviewed-by: Ray Ni
> -Original Message-
> From: Nikodem, Damian
> Sent: Wednesday, September 11, 2019 1:23 AM
> To: [email protected]
> Cc: Nikodem, Damian ; Dong, Eric
> ; Ni, Ray ; You,
> Benjamin ; Laszlo Ersek ; Rusocki,
> Krzysztof
> Subject: [PATCH v3] UefiCpuPkg: Fix potenti
On 09/10/19 17:44, Ryszard Knop wrote:
> On Tue, 2019-09-10 at 16:33 +0100, Leif Lindholm wrote:
>> On Mon, Sep 09, 2019 at 02:35:15PM +0200, Laszlo Ersek wrote:
>>> On 09/06/19 14:26, Leif Lindholm wrote:
On Thu, Sep 05, 2019 at 08:38:17PM +0200, Laszlo Ersek wrote:
> Repo:
> https
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2169
The UEFI specification allows EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState()
to return EFI_UNSUPPORTED if a state change is not supported. This for
instance may be the case when connecting via a serial connection.
Up to now the SCT has marked
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1976
CreateEventEx() may lead to a change in the memory map causing an
EFI_EVENT_GROUP_MEMORY_MAP_CHANGE. So in BBTestCreateEventEx_Func_Sub3() we
should only check for events triggered after the events have been set up.
Among other changes comm
Jiewen, you’re right, SetVariable ( ) will continue to go through SW SMI. I
agree it should not be an issue for this work. Nate, can you please confirm we
can close the open?
From: Yao, Jiewen
Sent: Tuesday, September 10, 2019 8:32 PM
To: Desimone, Nathaniel L ;
[email protected]; Johnson, M
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, September 11, 2019 9:40 AM
> To: [email protected]
> Cc: [email protected]; Agyeman, Prince ;
> Wei, David Y ; Gao, Liming ;
> Sinha, Ankit ; Kubacki, Michael A
> ; Desimone, Nathaniel L
>
> S
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, September 11, 2019 9:40 AM
> To: [email protected]
> Cc: [email protected]; Agyeman, Prince ;
> Wei, David Y ; Gao, Liming ;
> Sinha, Ankit ; Kubacki, Michael A
> ; Desimone, Nathaniel L
>
> S
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, September 11, 2019 9:40 AM
> To: [email protected]
> Cc: [email protected]; Agyeman, Prince ;
> Wei, David Y ; Gao, Liming ;
> Sinha, Ankit ; Kubacki, Michael A
> ; Desimone, Nathaniel L
>
> S
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
Extend the support types of terminal console driver. New added types
are Linux, XtermR6, VT400 and SCO.
Refer to
https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys
Add the missing VT100+ function keys map.
Add F
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
Putty is a very popular terminal tool in windows. So add the whole support
terminal keyboard type for it. The new introduced type is Linux, XtermR6,
VT400 and SCO. And enhance the support for VT100+.
This patch set only add the support of fu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
Add the new introduced terminal types to related setup menu to change
the terminal type from setup. Most platforms would have its own
configure setup menu and they need to change it to support these.
The new introduced terminal types are Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
A common terminal console software Putty support various types of
keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400,
VT100+ and SCO. Refer to the link:
https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funke
push@5e5abfcab4c2962005be89c951a86f55db27555e
From: [email protected] [mailto:[email protected]] On Behalf Of Liming Gao
Sent: Tuesday, September 10, 2019 11:23 PM
To: [email protected]; [email protected]
Subject: Re: [edk2-devel] Increase robustness of nmake BaseTools build for
space als
Push @204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0
>-Original Message-
>From: [email protected] [mailto:[email protected]] On Behalf Of
>Philippe Mathieu-Daudé
>Sent: Tuesday, September 10, 2019 2:30 PM
>To: [email protected]; [email protected]
>Subject: Re: [edk2-devel] [PATCH v
Hi ,
Thanks for the update.
I don't know how you send this patch, the format and subject seems a little
different from V1 patch. Anyway it doesn't block my review of this patch.
I have two minor comments for the function comments:
1. Per EDKII C Coding Spec, @retval for each unique return value
The patch series has been pushed as de0fb79a14..8bda7e434b
-Original Message-
From: Chen, Marc W
Sent: Monday, September 2, 2019 8:36 AM
To: [email protected]
Cc: Kubacki, Michael A ; Chaganty, Rangasai V
; Chiu, Chasel ; Gao,
Liming ; Desimone, Nathaniel L
; Steele, Kelly ;
Gillis
Heinrich,
Could you please provide your company/organization info in copyright part?
I could help to add it when I push the patch.
With that - Reviewed by: Eric Jin
Best Regards
Eric
-Original Message-
From: [email protected] On Behalf Of Heinrich
Schuchardt
Sent: Thursday, Septem
Heinrich,
Could you please provide your company/organization info in copyright part?
I could help to add it when I push the patch.
With that - Reviewed by: Eric Jin
Best Regards
Eric
-Original Message-
From: Heinrich Schuchardt
Sent: Thursday, September 12, 2019 2:45 AM
To: EDK II De
As is requested in the BZ 2077, add two switches to support setting
compression mode and dictionary size.
(https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../Source/C/LzmaCompress/LzmaCompress.c | 39 +++
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, September 12, 2019 9:02 AM
> To: [email protected]
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray
> Subject: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of
> Terminal console
Hello,
Entend -> Extend
>
> REF: https:/
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, September 12, 2019 9:02 AM
> To: [email protected]
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray
> Subject: [PATCH 2/3] MdeModulePkg/TerminalDxe: Extend the terminal
> console support types
>
> REF: https://bugzilla.tianocore.org/show
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, September 12, 2019 9:03 AM
> To: [email protected]
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray
> Subject: [PATCH 3/3] MdeModulePkg/BM_UI: Add the new terminal types
> to related menu
>
> REF: https://bugzilla.tianocore.org/show_bug.
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:[email protected]]
> Sent: Wednesday, September 11, 2019 11:25 PM
> To: Dong, Eric ; [email protected]
> Cc: Ni, Ray
> Subject: Re: [Patch] UefiCpuPkg/CpuDxe: clean up
> PAGE_TABLE_LIB_PAGING_CONTEXT usage.
>
> On 09/11/19 0
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-
From: shrishail patil
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2187
Adding HiiConfigAccess Protocol to IHVSCT.
This patch contains source code which is copied from
UEFISCT and added into IHVSCT.
Cc: Supreeth Venkatesh
Cc: Eric Jin
Signed-off-by: shrishail patil
---
.../BlackBoxTe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2187
It is a request to add HiiConfigAccess test to IHV
Eric Jin (3):
uefi-sct/SctPkg: Add HiiConfigAccess test source to IHVSCT
uefi-sct/SctPkg: Add HiiConfigAccess to IHVSCT build/configuration
uefi-sct/SctPkg: Add HiiConfigAccess to IHV
From: shrishail patil
Cc: Supreeth Venkatesh
Cc: Eric Jin
Signed-off-by: shrishail patil
---
uefi-sct/SctPkg/CommonGenFramework.bat | 4 +++-
uefi-sct/SctPkg/CommonGenFramework.sh | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/CommonGenFramework.bat
b/
From: shrishail patil
Cc: Supreeth Venkatesh
Cc: Eric Jin
Signed-off-by: shrishail patil
---
uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 2 ++
uefi-sct/SctPkg/Config/Data/Category.ini | 8
2 files changed, 10 insertions(+)
diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-sct/SctP
MadtStructs, NewMadtTable and MaxMadtStructCount are not initialized
before used or at the proper place. So assign values to them at the
beginning and change the logic when freeing MadtStructs and
NewMadtTable.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by:
1.Add error handling to enhance status checking.
2.Initialize the variables before used and add check before
FreePool().
v2: Update copyright in 01/02.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Shenglei Zhang (2):
MinPlatformPkg/AcpiTables: Initialize variables
Change ASSERT_EFI_ERROR to return value when the "if" statement is true.
As a result, when SortCpuLocalApicInTable is called, error handling is
needed. So add "if" statement to judge the returned Status from
SortCpuLocalApicInTable () in function InstallMadtFromScratch().
Cc: Michael Kubacki
Cc:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, September 12, 2019 11:27 AM
> To: [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [PATCH v2 1/2] MinPlatformPkg/AcpiTables: Initiali
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, September 12, 2019 11:27 AM
> To: [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [PATCH v2 2/2] MinPlatformPkg/AcpiTables: Add erro
Hi Ard, Leif, Christopher,
Any comments on the patches?
Thanks!
Tien Hock
> -Original Message-
> From: Haojian Zhuang
> Sent: Monday, September 2, 2019 5:31 PM
> To: Loh, Tien Hock
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]
V2 changes:
Avoid use type case, use different file implementation.
V1 changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039
Current implementation not checks system mode before using
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This
On 9/12/19 4:32 AM, Jin, Eric wrote:
Heinrich,
Could you please provide your company/organization info in copyright part?
Hello Eric,
my work on EDK2 has neither been on behalf of a company or organization,
nor have I received any remuneration for it. If you deem it appropriate,
feel free to
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, September 11, 2019 6:14 PM
>To: [email protected]
>Cc: Gao, Liming ; Feng, Bob C
>Subject: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2080
>
Common definitions are not consumed by VFR. They are not required to be
defined in Tcg2ConfigNvData.h with WA way. New shared internal header
file is added to include those common definitions.
Cc: Jian Wang
Cc: Chao Zhang
Signed-off-by: Liming Gao
---
In V2:
Keep struct TCG2_DEVICE_DETECTION i
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2059
These build failures can be reproduced simply by building the
AdvancedFeaturePkg.dsc file in GCC5. To build the whole package
DSC (not pull individual features into other packages), set
the WORKSPACE variable to the edk2 directory in the work
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, September 11, 2019 8:27 PM
> To: [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [PATCH v2 1/2] MinPlatformPkg/AcpiTables: Initia
Reviewed-by: Michael Kubacki
> -Original Message-
> From: [email protected] On Behalf Of Zhang,
> Shenglei
> Sent: Wednesday, September 11, 2019 8:27 PM
> To: [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [edk2-devel
Hello Stephano,
the EDK II C Coding Standards Specification is available at:
https://raw.githubusercontent.com/tianocore-docs/Docs/master/Specifications/CCS_2_1_Draft.pdf
It is copyright restricted, allowing only copying for internal use.
As EDK II has moved to be open source wouldn't it make
On 9/12/19 3:59 AM, Bi, Dandan wrote:
Hi ,
Thanks for the update.
I don't know how you send this patch, the format and subject seems a little
different from V1 patch. Anyway it doesn't block my review of this patch.
I have two minor comments for the function comments:
1. Per EDKII C Coding Spe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869
The UEFI spec requires that if any error occurs in
UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned
and not the return code of UninstallProtocolInterface().
Signed-off-by: Heinrich Schuchardt
Reviewed-by: Dandan Bi
67 matches
Mail list logo
