Re: [edk2-devel] [edk2-platforms][PATCH V1 22/37] CoffeelakeSiliconPkg/Pch: Add DXE private library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 21/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 17/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 24/37] CoffeelakeSiliconPkg/Pch: Add SMM private library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 30/37] Maintainers.txt: Add CoffeelakeSiliconPkg maintainers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D > Subject

Re: [edk2-devel] [edk2-platforms][PATCH V1 36/37] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add DSC and build files

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Kinney, Michael D > ; Sinha,

Re: [edk2-devel] [edk2-platforms][PATCH V1 20/37] CoffeelakeSiliconPkg/Pch: Add SMM library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 32/37] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Kinney, Michael D > ; Sinha,

Re: [edk2-devel] [edk2-platforms][PATCH V1 12/37] CoffeelakeSiliconPkg/SampleCode: Add Include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Kinney, Michael D > ; Sinha,

Re: [edk2-devel] [edk2-platforms][PATCH V1 15/37] CoffeelakeSiliconPkg/Cpu: Add library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 29/37] CoffeelakeSiliconPkg: Add package DSC files

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [PATCH] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Chiu, Chasel
l@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Cheng, Ching JenX > Sent: Monday, August 19, 2019 3:21 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Kubacki, Michael A > ; Chiu, Chasel ; > Desimone, Nathaniel L ; Gao, Liming > > Subject: [edk2-devel] [PATCH] Python run f

Re: [edk2-devel] [edk2-platforms: PATCH v2] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Cheng, Ching JenX > Sent: Monday, August 19, 2019 5:24 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Kubacki, Michael A > ; Chiu, Chasel ; > Desimone, Nathaniel L ; Gao, Liming > > Subject: [edk2-plat

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme.md: Content update

2019-08-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Tuesday, August 20, 2019 10:03 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; G

Re: [edk2-devel] [edk2-platforms: PATCH v2] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Chiu, Chasel
Pushed: https://github.com/tianocore/edk2-platforms/commit/05e9ca3abfcf89795d90e31415bac28a9f350299 > -Original Message- > From: Cheng, Ching JenX > Sent: Monday, August 19, 2019 5:24 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Kubacki, Michael A > ; Chiu, C

Re: [edk2-devel] [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files

2019-08-21 Thread Chiu, Chasel
Some of files touched by this patch still having old copyright year, please help to extend. With above update: Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, August 21, 2019 4:01 PM > To: devel@edk2.groups.io > Cc: Kubacki, M

Re: [edk2-devel] [PATCH] Intel/* clean up duplicated files in Edk2Platforms

2019-08-22 Thread Chiu, Chasel
- > From: Chen, Marc W > Sent: Thursday, August 22, 2019 1:28 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Steele, Kelly > ; Gillispie, Thad ; Bu, > Daocheng ; Oram, Isaac W > > Subject: [PATCH] In

Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option

2019-08-22 Thread Chiu, Chasel
To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Zhang, Shenglei > Subject: [edk2-devel] [edk2-platforms PATCH 3/4] > Platform/MinPlatformPkg.dsc: Add build option > > Add the build option "/D DISABLE_NEW_

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-22 Thread Chiu, Chasel
1:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: > Fix GCC Build Failures > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109 > > Fixes build

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Friday, August 23, 2019 2:17 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoar

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] MinPlatformPkg/MultiBoardInitSupportLib: Fix NULL pointer dereferences

2019-08-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Saturday, August 24, 2019 7:24 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Lim

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures

2019-08-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 24, 2019 5:23 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix

Re: [edk2-devel] [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures

2019-08-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, August 27, 2019 2:48 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix

Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-26 Thread Chiu, Chasel
Please see 3 questions below inline. (tagged by [chasel]) Thanks! Chasel > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, August 27, 2019 2:48 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency

2019-08-27 Thread Chiu, Chasel
Same findings as Nate, with FspSecCoreT.inf copyright updated, Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, August 28, 2019 7:21 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Zeng, Star > S

Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-27 Thread Chiu, Chasel
Sorry that I overlooked that the last part I questioned was just a cleanup. I'm ok with what you are going to do. Thanks for clarification! > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, August 28, 2019 6:54 AM > To: Kubacki, Michael A ; Chiu,

Re: [edk2-devel] [edk2-platforms][PATCH V5 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures

2019-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Wednesday, August 28, 2019 12:17 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V5 1/2] CoffeelakeSiliconPkg: Fix

Re: [edk2-devel] [edk2-platforms][PATCH V5 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Wednesday, August 28, 2019 12:17 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V5 2/2] WhiskeylakeOpenBoar

Re: [edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed ZeroMem ()

2019-08-30 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Friday, August 30, 2019 7:16 AM > To: devel@edk2.groups.io; Desimone, Nathaniel L > > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: RE: [edk2-devel] [PATCH] Coffeelake

Re: [edk2-devel] [edk2-platforms] ClevoOpenBoardPkg: Update board gpios

2019-08-30 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Friday, August 30, 2019 9:12 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Wei, David Y > ; Kubacki, Michael A ; > Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-p

Re: [edk2-devel] [PATCH 1/2] MinPlatformPkg/AcpiTables: Initialize variables before used

2019-09-02 Thread Chiu, Chasel
Please extend copyright. With this update, Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming

Re: [edk2-devel] [PATCH 2/2] MinPlatformPkg/AcpiTables: Add error handling to SortCpuLocalApicInTable

2019-09-02 Thread Chiu, Chasel
Same with 1/2 patch, please extend copyright. With above update, Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers

2019-09-02 Thread Chiu, Chasel
Please extend copyright for files you touched, and one more update in below inline. > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

2019-09-02 Thread Chiu, Chasel
Extend copyright and please follow the coding style: if () { ... } else { ... } > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; G

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointer Variable

2019-09-02 Thread Chiu, Chasel
Please extend copyright, with this update Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Limi

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Sinha, Ankit > Sent: Saturday, August 31, 2019 6:28 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms] [PATCH v2

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/6] MinPlatformPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 1/6]

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/6] CoffeelakeSiliconPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [e

Re: [edk2-devel] [edk2-platforms][PATCH V2 4/6] KabylakeSiliconPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [e

[edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2153 Current logic will skip searching EFI_PEI_CORE_FV_LOCATION_PPI when the PPI in PpiList having EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST flag, but platform may pass single PPI in PpiList that should be supported. Changed the logic to verify PpiL

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Remove unneeded MdeModulePkg dependency

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Agyeman, > Prince > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: > Change TopOfTemporaryRam type > > Cast TopOfTemporaryRam's from

Re: [edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
> -Original Message- > From: Ni, Ray > Sent: Thursday, September 5, 2019 2:04 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: support single > EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
age- > From: Zhang, Shenglei > Sent: Thursday, September 5, 2019 10:11 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, Nathaniel > L ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH] > MinPlatformPkg/SecFspWrapperPlatformSecLib: Change > Top

[edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2153 Current logic will skip searching EFI_PEI_CORE_FV_LOCATION_PPI when the PPI in PpiList having EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST flag, but platform may pass single PPI in PpiList that should be supported. Changed the logic to verify PpiL

Re: [edk2-devel] [edk2-platforms] [PATCH v3 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-04 Thread Chiu, Chasel
I do not see change on top of V2, why we need V3? Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sinha, > Ankit > Sent: Thursday, September 5, 2019 6:18 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, C

Re: [edk2-devel] [edk2-platforms] [PATCH v2] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, September 4, 2019 11:48 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael A > ; Chiu, Chasel ; Bi, &g

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, September 5, 2019 2:20 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-05 Thread Chiu, Chasel
Thanks Laszlo! Pushed: 8a1305a11f3bda2d6c1ab758e4aea79ee021dd1c > -Original Message- > From: Laszlo Ersek > Sent: Thursday, September 5, 2019 9:16 PM > To: Ni, Ray ; Dong, Eric ; Chiu, > Chasel ; devel@edk2.groups.io > Subject: Re: [PATCH v2] UefiCpuP

<    5   6   7   8   9   10