[PATCH] Useless var in smsc_emi.c

2006-08-18 Thread Colin Pitrat
Hello, it looks like in the following piece of code (gw/smsc/smsc_emi.c:1080), the adc var is useless : if (octstr_get_char(emimsg-fields[0], 0) == 'A') { /* we got an ack back. We might have to store the */ /* timestamp for

Re: detecting modems on USB

2006-08-18 Thread Peter Nixon
On Wed 16 Aug 2006 12:41, fred wrote: perhaps this is not strictly a kannel question...YET!! but this is a developers list, and other people writing C code on linux are here. In case you haven't got it yet, the way kannel modems are currently configured, by the device name, ie /dev/ttyUSB00

[PATCH] EMI UCP Numerical message for OT 01

2006-08-18 Thread Colin Pitrat
Hi, this patch add support for numerical message for operation call input operation (Call input operation is OT=01, Numerical message is MT=2). As we're dealing with numerical data, there should be no need of charset conversion. Regards, -- Colin Pitrat (Bull Services Telco) Bull, Architect

Re: [PATCH] EMI UCP Numerical message for OT 01

2006-08-18 Thread Vincent CHAVANIS
I'm -0 for this patch As it's presented as a new feature, your patch looks incomplete. Please refer to EMI/UCP 4.6 Specs. (MT=4 is missing for example) Then you are using redundant code when you initiate emimsg-fields[E01_AMSG] Vincent. -- Telemaque - 06200 NICE - (FR) Service Technique/Reseau

[PATCH] SM field in EMI UCP reply to OT 01

2006-08-18 Thread Colin Pitrat
Hi here is a patch that fill the SM field in positive reply to call input operation. Regards, -- Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com --- gateway/gw/smsc/smsc_emi.c 2006-08-18 14:58:05.0 +0200 +++

Re: [PATCH] EMI UCP Numerical message for OT 01

2006-08-18 Thread Colin Pitrat
Well, in the version of EMI/UCP I have (3.5), there's only MT=2 and MT=3. Do you have a link where I could fine a more recent version ? (I know I'm lazy :) ). For the redundant code, it's not really redundant as for MT=2 there's only the if, whereas for MT=3 there's the if and the else, so if

Re: [PATCH] EMI UCP Numerical message for OT 01

2006-08-18 Thread Vincent CHAVANIS
http://www.orangepartner.com/images/smsc46emiucpspecification.pdf regards -- Telemaque - 06200 NICE - (FR) Service Technique/Reseau - NOC Developpement SMS/MMS/Kiosques http://www.telemaque.fr/ [EMAIL PROTECTED] Tel : +33 4 93 97 71 64 (fax 68) - Original Message - From: Colin Pitrat

Re: [PATCH] EMI UCP Numerical message for OT 01

2006-08-18 Thread Colin Pitrat
Thanks, this one is much more recent and much more readable than mine ! Regards, Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com Vincent CHAVANIS wrote: http://www.orangepartner.com/images/smsc46emiucpspecification.pdf

Re: [PATCH] EMI UCP Numerical message for OT 01

2006-08-18 Thread Colin Pitrat
Hi, after having checked, MT=4 doesn't exist for call input operation (OT=01) as you can see in §8.1, page 58. But it's true it does exist for other operations (51 for example). Regards, Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93

Re: [PATCH] EMI UCP Numerical message for OT 01

2006-08-18 Thread Vincent CHAVANIS
yep right, i've opened the specs on a wrong page. Vincent. -- Telemaque - 06200 NICE - (FR) Service Technique/Reseau - NOC Developpement SMS/MMS/Kiosques http://www.telemaque.fr/ [EMAIL PROTECTED] Tel : +33 4 93 97 71 64 (fax 68)

Re: Kannel HTTP MO delivery failing under load

2006-08-18 Thread Stipe Tolj
Hi Giulio, Giulio Harding wrote: We're looking for some help/advice with a Kannel problem we've just encountered. - We're using Kannel CVS (up-to-date as of today, 28/07/2006) - Kannel is built with --prefix=/opt/kannel --enable-start-stop-daemon - Kannel is running on an Intel Xeon 2.8 GHz