Re: Re: Proposed Patches for META-DATA branch

2008-11-21 Thread Michael Zervakis
Alex, >Michael Zervakis schrieb: >> You're right. Thanks for the patch. >Michael, can you confirm that the issue is solved by Alex's patch. (I'm almost certain it is, but I'd simply hear a "yeah, that does it" from your side). >So we can commit it to the meta-data branch. >Stipe I applied

Re: Proposed Patches for META-DATA branch

2008-11-21 Thread Alexander Malysh
Hi, yep, sometimes it's better to test patch before sending out :) Attached is the patch for head... Michael Zervakis schrieb: Alex, >Michael Zervakis schrieb: >> You're right. Thanks for the patch. >Michael, can you confirm that the issue is solved by Alex's patch. (I'm almost certain i

Patch formalization

2008-11-21 Thread Nikos Balkanas
Hi, I see a lot of patches going around on this group. I would like to propose not to accept patches unless the relevant points are updated in the documentation. Furthermore I suggest that this should be a distributed effort by each submitter. Too much I think has fallen on the shoulders of Ale

Re: Patch formalization

2008-11-21 Thread Stipe Tolj
Nikos Balkanas schrieb: > Hi, > > I see a lot of patches going around on this group. I would like to > propose not to accept patches unless the relevant points are updated in > the documentation. Furthermore I suggest that this should be a > distributed effort by each submitter. Too much I think

Re: [PATCH] MO routing: smsbox-route with keywords

2008-11-21 Thread Stipe Tolj
Alexander Malysh schrieb: > > The idea is as follows: we have urltrans where the whole keyword > handling magic already implemented and maintained. Then why should we > implement keyword mapping again in bb_boxc if we could reuse urltrans > logic or just extract keyword mapping logic from urltrans

Re: fakesmsmc.c patch v2

2008-11-21 Thread Stipe Tolj
Alexander Malysh schrieb: > Hi Nikos, > > seems you don't get a point of fakesmsc... > > with you version it's only possible to test: > fakesmsc->bearerbox->smsbox->(reply) way but fakesmsc should also allow > to test: > smsbox->bearerbox->faksesmsc what Alex wants to say here is: fakesmsc mimi

Re: Patch formalization

2008-11-21 Thread Stipe Tolj
Stipe Tolj schrieb: > > Main policy items, IMO: > > 1. where to submit: devel@ list. > 2. subject prefixing: [PATCH] my foobar patch that does > 3. form of the patch: diff -u against CVS HEAD at 'gateway' root > 4. form of source code: gateway/doc/CodingStyle should be obeyed > 5. explanation of

Re: Patch formalization

2008-11-21 Thread Nikos Balkanas
Hi Stipe, Very nicely done, especially the mantis system. But you are missing a very important point. What I was driving at was that any submitted patch should include a patch also of the manual. This is already in HTML form and needs to be in the CVS, if not already. It might take some time

Re: Patch formalization

2008-11-21 Thread Alejandro Guerrieri
Well, for the last few years, though maybe not a strict policy, patches that modified the functionality were always suggested to have a patch to the documentation XML as well. I remember many patches that were put on hold until a proper documentation patch was in place as well. I also agr

Re: fakesmsmc.c patch v2

2008-11-21 Thread Nikos Balkanas
Hi Stipe, I have discussed this elsewhere with Alex, and seems that we have reached an understanding. I am not sure what you mean by running MT and MO modes, I know only of interactive and batch operation. Batch operation should terminate once all sent messages are received (MO)?, so that benc

Re: Patch formalization

2008-11-21 Thread Alejandro Guerrieri
Nikos, The manual on the site is rendered to HTML, PDF and other formats from a DocBook XML file, userguide.xml available on Kannel's source code. Its content has been updated a lot of times. Regards, Alejandro Guerrieri El 21/11/2008, a las 11:40 p.m., Nikos Balkanas escribió: Hi Alej