Re: [PATCH] No PANIC on failing store_load()

2013-09-16 Thread Willy Mularto
+1 It will be good to dump it to bearerbox-access log and flag it as FAILED MT and maybe add more info into it so we can analyse it. Thanks Stipe. On Sep 16, 2013, at 11:56 PM, Alejandro Guerrieri wrote: > +1 this was really an annoyance IMHO > > > -- > Alejandro Guerrieri > > On Sep 16,

Re: [PATCH] No PANIC on failing store_load()

2013-09-16 Thread Alejandro Guerrieri
+1 this was really an annoyance IMHO -- Alejandro Guerrieri On Sep 16, 2013, at 11:59 AM, Stipe Tolj wrote: > Hi list, > > attached is a very simple change in behavior in being more "runtime" > constraining, in case a message in the spool has an invalid 'sms_type' we > SHOULD NOT PANIC i.e.

Re: [PATCH] No PANIC on failing store_load()

2013-09-16 Thread spameden
+1 for this patch! I remember struggling with sqlbox without injecting proper sms_type = 2 and after restart kannel was crashing. I had to manually clean specific message out of spool. 2013/9/16 Porter, Kelvin : > Hi, > > This sounds like a good change. This principle should be applied, in ge

[PATCH] No PANIC on failing store_load()

2013-09-16 Thread Stipe Tolj
Hi list, attached is a very simple change in behavior in being more "runtime" constraining, in case a message in the spool has an invalid 'sms_type' we SHOULD NOT PANIC i.e. but rather dump an ERROR entry and try to continue. Otherwise we may enter an infinite PANIC/restart loop for cases tha

RE: [PATCH] No PANIC on failing store_load()

2013-09-16 Thread Porter, Kelvin
Hi, This sounds like a good change. This principle should be applied, in general. Regards, Kelvin R. Porter -Original Message- From: devel [mailto:devel-boun...@kannel.org] On Behalf Of Stipe Tolj Sent: Monday, September 16, 2013 10:59 AM To: devel@kannel.org Subject: [PATCH] No PANIC