Re: Some remarks

Oups, of course I forgot the attachment ! Colin Colin Pitrat wrote: Hello, here is another patch as attachment. It concerns contrib/php-admin which is broken when php is configured with register_globals=Off (reccomended) and use of name instead of value in "option" tag. I&#

Re: Some remarks

Hello, here is another patch as attachment. It concerns contrib/php-admin which is broken when php is configured with register_globals=Off (reccomended) and use of name instead of value in "option" tag. I'm currently working on making these scripts better. Regards, Colin Col

Re: Some remarks

Okay, but then there is a conflict with randomize that is -p, and the help is not consistant as it says -p for port and -r for randomize. Colin Stipe Tolj wrote: Vincent CHAVANIS wrote: Yep, i'm in favor of normlizing all args. (host=-h port=-p etc...) btw, your patch is incomplete, (i.e st

Re: Some remarks

| strcmp(argv[i], "--randomize")==0) [...] My version of fakesmsc is not the last one as I can't manage to browse cvs, so maybe it has already been corrected. Regards, Colin Stipe Tolj wrote: Colin Pitrat wrote: Okay, but then there is a conflict with randomize that is -p,

Re: Some remarks

Stipe Tolj wrote: > I had a report of an other Kannel user that cvspserver was not available > for TCP connection? Can you state a timestamp for this? Well, when I go to http://kannel.org/cgi-bin/lxr/source, I've got the Apache Test Page, but I just figured that ViewVC is working. Colin

Re: Some remarks

Hello, I re-send my patch for MWI sms. The problem is that judging by fields_to_dcs function in sms.c, an empty message with an activating MWI flag should result in "discard message" MWI whereas a non-empty message should result in "store message" MWI. But when the smsbox handle the message s

[PATCH] empty SMS replaced by default message

Hello, I sent this patch a few days ago, but I've been told that mail with patch attached should be prefixed with [PATCH] so I resend it. The problem is that judging by fields_to_dcs function in sms.c, an empty message with an activating MWI flag should result in "discard message" MWI whereas a

Re: [PATCH] empty SMS replaced by default message

Hi, yes it will remove the "" message when sending blank messages except when this message comes from a sms-service group (mt_reply) with omit-empty set to false. Regards, Colin Hillel wrote: Hi, Will this patch remove the "" message when sending blank mt messages? This message confuses th

Re: [PATCH] empty SMS replaced by default message

Hello, there hasn't been any remark on this patch, but it hasn't been committed either. Is there a problem with it ? Regards, Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com Colin Pitrat wrote: Hello, I sent th

[PATCH] Useless var in smsc_emi.c

ybe m could be named message etc ... It does'nt even allow to code faster, as a comment has to explain that we store the timestamp. -- Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com --- gateway/gw/smsc/smsc_emi.c 2006-0

[PATCH] EMI UCP Numerical message for OT 01

Hi, this patch add support for numerical message for operation call input operation (Call input operation is OT=01, Numerical message is MT=2). As we're dealing with numerical data, there should be no need of charset conversion. Regards, -- Colin Pitrat (Bull Services Telco) Bull, Arch

[PATCH] SM field in EMI UCP reply to OT 01

Hi here is a patch that fill the SM field in positive reply to call input operation. Regards, -- Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com --- gateway/gw/smsc/smsc_emi.c 2006-08-18 14:58:05.0 +0200 +++ gateway

Re: [PATCH] EMI UCP Numerical message for OT 01

he if and the else, so if you wan't to change it you have to add a flag to know later if emimsg->fields[E01_AMSG] was NULL or not in order to do the else only when needed. Moreover, this part only concern MT=2 and MT=3, but not the default case, and maybe not the MT=4 part (what is it

Re: [PATCH] EMI UCP Numerical message for OT 01

Thanks, this one is much more recent and much more readable than mine ! Regards, Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com Vincent CHAVANIS wrote: http://www.orangepartner.com/images/smsc46emiucpspecification.pdf

Re: [PATCH] EMI UCP Numerical message for OT 01

Hi, after having checked, MT=4 doesn't exist for call input operation (OT=01) as you can see in §8.1, page 58. But it's true it does exist for other operations (51 for example). Regards, Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 3

[PATCH] Some modifs on EMI UCP

. I'm currently running some conformity tests on kannel for EMI UCP, and I'd like to add the missing functionalities, but it seems like there's not a lot of commit on CVS for a long time. Will all the patches that have been sent for the last months be applied ? Regards, -- Col

[PATCH] EMI UCP - ot=02 : multiple address call input operation

As the previous one, this patch should be applied after the others. Regards, -- Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com diff -ru gateway/gw/smsc/emimsg.c gateway-new/gw/smsc/emimsg.c --- gateway/gw/smsc/emimsg.c2

Re: [PATCH] EMI UCP - ot=02 : multiple address call input operation

Wow it looks like I misread the documentation. Operations 02 and 03 can only be initiated by the gateway, not by the SMSC, so this patch is totally useless, and a part of the previous one too ! Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72

Re: [PATCH] Some modifs on EMI UCP

As I said in another mail, 02 and 03 operations can't be initiated by the SMSC, so this patch is wrong. However, it seems that operations 57 and 58 should be added. I will send a patch later. Sorry for the inconvenience. Regards, Colin Pitrat (Bull Services Telco) Bull, Architect of an

Re: gw/msg.c (profile question)

Maybe this could help : http://sam.zoy.org/writings/programming/gprof.html Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Te'l : +33 (0) 1 30 80 72 93 www.bull.com Panda wrote: I thought about it but can't get good idea. Putting in switch would give ins

Re: [PATCH] empty SMS replaced by default message

Hi, I'm surprised that this patch hasn't been integrated or commented by now. Is there any problem with it ? Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com Colin Pitrat wrote: Hello, I sent this patch a few day

Compiling kannel with -Wall option

Hello, I added the -Wall option to CFLAGS, and I add a lot of warnings. I know this doesn't mean that there are errors, but it could hide some. Maybe it would be nice to enable this flag and to try to correct some of these warnings don't you think ? Regards, -- Colin Pitrat (Bul