[PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Rune Saetre
Hi again. I think this patch should be applied before 1.4.1 is released. I have submitted this before, but without the [PATCH] tag in the subject line. And here it is again, since I cannot see it has been applied to the CVS. This patches the gateway-1.4.0/gwlib/http.c file from the 1.4.0 version

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Paul P Komkoff Jr
Replying to Rune Saetre: > I think this patch should be applied before 1.4.1 is released. > > I have submitted this before, but without the [PATCH] tag in the subject > line. And here it is again, since I cannot see it has been applied to the > CVS. > > This patches the gateway-1.4.0/gwlib/http.c

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Stipe Tolj
Hi Paul, comments inlined. I know the reasoning I had when invented NEW_CHARSET. Phone claims it supports multiple encodings - like, for example, latin1, koi8-r, and utf8, but does this in-line and with q=0.x weights. The, webserver decides to present russian content in, for example, koi8. But ther

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Rune Saetre
Hi What happens is that the document typically contains characters from the ISO-8859-1 charset, as allowed/suggested by the RFC. Kannel expects something else, I do not know what. The WML compiler fails, dumping something like this in the logs: 2004-12-03 23:58:57 [13183] [7] INFO: Mutex gwlib/l

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Stipe Tolj
Rune Saetre wrote: Hi again. I think this patch should be applied before 1.4.1 is released. I have submitted this before, but without the [PATCH] tag in the subject line. And here it is again, since I cannot see it has been applied to the CVS. This patches the gateway-1.4.0/gwlib/http.c file from t

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Rune Saetre
Thanks! Rune --- Rune Sætre <[EMAIL PROTECTED]> NetCom as, Infrastruktur Telefon (mob): 934 34 285 .. On Tue, 15 Feb 2005, Stipe Tolj wrote: > Rune Saetre wrote: > > > Hi again. > > > > I think this patch should be applied before 1.4.1 is released. > > > > I have submitted this before, but wit

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Paul P Komkoff Jr
Replying to Stipe Tolj: > applied to cvs, in a variation form. See > http://www.kannel.org/cgi-bin/viewcvs.cgi/gateway/gwlib/http.c.diff?r1=1.225&r2=1.226&sortby=date Great! Now it's not 1<->1 with curl as it goes. :( -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Paul P Komkoff Jr
Replying to Stipe Tolj: > ok, reading this, it means from the point of logic: > If there has not been an Accept-Charset header with utf-8, you add it > directly. But, when I look into how List *charset is filled, I see in > gw/xml_shared.c:77 that UTF-8 is added anyway in the "rest" of the #else

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Stipe Tolj
Paul P Komkoff Jr wrote: Replying to Stipe Tolj: applied to cvs, in a variation form. See http://www.kannel.org/cgi-bin/viewcvs.cgi/gateway/gwlib/http.c.diff?r1=1.225&r2=1.226&sortby=date Great! Now it's not 1<->1 with curl as it goes. what do you mean with 1<->1?? ;) the behaviour of libcurl and

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-15 Thread Paul P Komkoff Jr
Replying to Stipe Tolj: > > the behaviour of libcurl and gwlib's http.c? Yes. curl doesn't mangle headers in any way. -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This message represents the official view of the voices in my head

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-16 Thread Stipe Tolj
Paul P Komkoff Jr wrote: Replying to Stipe Tolj: the behaviour of libcurl and gwlib's http.c? Yes. curl doesn't mangle headers in any way. hm... As I noticed, the section reading from the HTTP/1.1 RFC is more like "this is what the server should do", IMO. So the question is if it is up to the se

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-16 Thread Rune Saetre
Hi again. This is snipped from the RFC: The "charset" parameter is used with some media types to define the character set (section 3.4) of the data. When no explicit charset parameter is provided by the sender, media subtypes of the "text" type are defined to have a default charset va

Re: [PATCH] Default charset patch (bug 0000068)

2005-02-16 Thread Stipe Tolj
Rune Saetre wrote: Hi again. This is snipped from the RFC: The "charset" parameter is used with some media types to define the character set (section 3.4) of the data. When no explicit charset parameter is provided by the sender, media subtypes of the "text" type are defined to have a d