[PATCH] curl

2005-02-11 Thread Paul P Komkoff Jr
attached -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This message represents the official view of the voices in my head Index: gateway.A9/acinclude.m4 === --- gateway.A9.orig/acinclude.m42004-11-06

Re: [PATCH] curl

2005-02-11 Thread Stipe Tolj
Paul P Komkoff Jr wrote: attached ok, I may be picky again... but I'll be anyway ;) As far as I understand, this means, libcurl support is optional via configure switch --enable-curl, right? Some points I'd like to see cleaned: * moving curl_XXX functions to an "own" file instead of mudging it in

Re: [PATCH] curl

2005-02-11 Thread Dziugas Baltrunas
Hi, > As far as I understand, this means, libcurl support is optional via configure > switch --enable-curl, right? > > Some points I'd like to see cleaned: > > * moving curl_XXX functions to an "own" file instead of mudging it into > gw/wap-appl.c. This is not the appropriate place IMO. > > * c

Re: [PATCH] curl

2005-02-11 Thread Enver ALTIN
On Fri, 2005-02-11 at 16:38 +0200, Dziugas Baltrunas wrote: > A snip from doc/CodingStyle: > > Don't add new features and make them conditionally compiled. > Either add them completely, or don't add them at all. > > Should it now be removed? A very good catch. I think we should r

Re: [PATCH] curl

2005-02-11 Thread Davy Chan
**>Subject: Re: [PATCH] curl **>From: Enver ALTIN <[EMAIL PROTECTED]> **>To: devel@kannel.org **>In-Reply-To: <[EMAIL PROTECTED]> **>Organization: Parkyeri **>Date: Fri, 11 Feb 2005 18:09:19 +0200 **> **>On Fri, 2005-02-11 at 16:38 +0200, Dziugas Baltrunas wro

Re: [PATCH] curl

2005-02-11 Thread Paul P Komkoff Jr
Replying to Stipe Tolj: > As far as I understand, this means, libcurl support is optional via > configure switch --enable-curl, right? Yes, that is for those people who want gwlib's http for some reason. My testing shows that curl is more reliable, though ... ;( > Some points I'd like to see cle

Re: [PATCH] curl

2005-02-11 Thread Alexander Malysh
hi, joust one idea: would it be possible to put curl things into gwlib into extra file and provide some compat layer for kannel's http interface so that _all_ users of gwlib/http would benefit (e.g. smsc_http/smsbox/etc.)? Paul P Komkoff Jr wrote: > Replying to Stipe Tolj: >> As far as I underst

Re: [PATCH] curl

2005-02-12 Thread Stipe Tolj
Davy Chan wrote: **>Subject: Re: [PATCH] curl **>From: Enver ALTIN <[EMAIL PROTECTED]> **>To: devel@kannel.org **>In-Reply-To: <[EMAIL PROTECTED]> **>Organization: Parkyeri **>Date: Fri, 11 Feb 2005 18:09:19 +0200 **> **>On Fri, 2005-02-11 at 16:38 +0200, Dziug

Re: [PATCH] curl

2005-02-12 Thread Stipe Tolj
Alexander Malysh wrote: hi, joust one idea: would it be possible to put curl things into gwlib into extra file and provide some compat layer for kannel's http interface so that _all_ users of gwlib/http would benefit (e.g. smsc_http/smsbox/etc.)? good point from Alex here. Ehh... by the way, will a

Re: [PATCH] curl

2005-02-14 Thread Kalle Marjola
> right. That was the main intention of the clause. I don't see an active > reason > to remove it. Seeing the clause in such a context in legitim and holds still > with current policy on how to add optional features, IMO. > > > Maybe Kalle could shed some light on the matter. > > yep, Kalle ma

Re: [PATCH] curl

2005-02-14 Thread Stipe Tolj
Kalle Marjola wrote: right. That was the main intention of the clause. I don't see an active reason to remove it. Seeing the clause in such a context in legitim and holds still with current policy on how to add optional features, IMO. Maybe Kalle could shed some light on the matter. yep, Kalle