Re: [PATCH] fix sms_split in sms.c

2007-02-26 Thread Alexander Malysh
no objections, commited to cvs. Alexander Malysh wrote: Hi, seems sms_split function was always buggy and never worked correctly? I found two issues: 1) max_part_len calculation was wrong. It was: max_len * 8 / 7 - udh_len But because udh nerer packed this is just wrong end should be:

[PATCH] fix sms_split in sms.c

2007-02-06 Thread Alexander Malysh
Hi, seems sms_split function was always buggy and never worked correctly? I found two issues: 1) max_part_len calculation was wrong. It was: max_len * 8 / 7 - udh_len But because udh nerer packed this is just wrong end should be: (max_len - udh_len) * 8 / 7 2) we dropped last

Re: [PATCH] fix sms_split in sms.c

2007-02-06 Thread Stipe Tolj
Alexander Malysh wrote: Hi, seems sms_split function was always buggy and never worked correctly? I found two issues: 1) max_part_len calculation was wrong. It was: max_len * 8 / 7 - udh_len But because udh nerer packed this is just wrong end should be: (max_len - udh_len) * 8 / 7 2)