Hi,
as of sooo many positive votes, commited to cvs :)
Am 25.10.2006, 22:40 Uhr, schrieb Alexander Malysh <[EMAIL PROTECTED]>:
patch fixes race condition in unregister/callback usage/destroy of
callback data.
The race is as follow, spotted with help of http.c:
1 Thread
tested, and approved ++1 !
Please commit to CVS
Vincent.
- Original Message -
From: "Vincent CHAVANIS" <[EMAIL PROTECTED]>
To:
Sent: Thursday, October 26, 2006 11:14 AM
Subject: Re: [PATCH] fix unregister/callback race in conn.c
Alex is right here,
The patch (+ l
ject: Re: [PATCH] fix unregister/callback race in conn.c
Hi,
because dict_get(conn_pool, key) may not be NULL it's just impossible if
no races there.
Am 26.10.2006, 07:53 Uhr, schrieb Mi Reflejo <[EMAIL PROTECTED]>:
> Umh.
> Why this?:
>
> -if (list != NULL
ue.fr/
[EMAIL PROTECTED]
Tel : +33 4 92 90 99 84 (fax 9142)
- Original Message -
From: "Alexander Malysh" <[EMAIL PROTECTED]>
To:
Sent: Thursday, October 26, 2006 9:35 AM
Subject: Re: [PATCH] fix unregister/callback race in conn.c
Hi,
because dict_get(conn_pool, key) may
Hi,
because dict_get(conn_pool, key) may not be NULL it's just impossible if
no races there.
Am 26.10.2006, 07:53 Uhr, schrieb Mi Reflejo <[EMAIL PROTECTED]>:
Umh.
Why this?:
-if (list != NULL && gwlist_delete_equal(list, conn) > 0) {
+if (gwlist_delete_equal(list, conn) >
Umh.
Why this?:
-if (list != NULL && gwlist_delete_equal(list, conn) > 0) {
+if (gwlist_delete_equal(list, conn) > 0) {
dict_get couldn't return null value from conn_pool and key?
M
On 10/25/06, Alexander Malysh <[EMAIL PROTECTED]> wrote:
Hi All,
attached patch fixes race con
Hi All,
attached patch fixes race condition in unregister/callback usage/destroy
of callback data.
The race is as follow, spotted with help of http.c:
1 Thread2 Thread
1) http:conn_pool_get 1) http:check_pool_conn
2) conn = XYZ
3)
