Re: [PATCH] include destination into dlr lookup

2004-09-29 Thread Alexander Malysh
Hi, Nicholas Rahn wrote: > I just had a chance to look at this code and i don't think this will > work for swiss or french numbers. in switzerland there are 10 numbers > in a national number (i.e. "0761234567"). If this is what we receive > from the SMSC, the patch will strip it down to 7 numbe

Re: [PATCH] include destination into dlr lookup

2004-09-29 Thread Nicholas Rahn
I just had a chance to look at this code and i don't think this will work for swiss or french numbers. in switzerland there are 10 numbers in a national number (i.e. "0761234567"). If this is what we receive from the SMSC, the patch will strip it down to 7 numbers ("1234567"). the last 7 charact

Re: [PATCH] include destination into dlr lookup

2004-09-28 Thread Enver ALTIN
Hi, On Tue, 2004-09-28 at 13:37 +0200, Alexander Malysh wrote: > I don't like the idea of bloating the db and we will not win too much > performance (IMHO)... (we should really make benchmarks with > direct/indirect db lookup) I'm fine either way, as long as it works :) Thanks, -- Enver ALTIN

Re: [PATCH] include destination into dlr lookup

2004-09-28 Thread Alexander Malysh
Hi, sorry for delay... Enver ALTIN wrote: > Hi, > > On Sun, 2004-09-26 at 17:07 +0200, Alexander Malysh wrote: >> > I believe avoiding use of `like` in SQL statements is better. >> >> it's impossible to avoid `like` by indirect lookup... if it's >> possible, please teach me ;) > > Walking ups

Re: [PATCH] include destination into dlr lookup

2004-09-26 Thread Alexander Malysh
Hi Alan, good catch ;) it's just a stupid bug in smsc_smpp module... see attached patch that I will commit to cvs asap. Alan McNatty wrote: > Hi Alex, > > One of the problems in the past with the DLR search using destination > address is that it has been contrary to SMPP v3.4 specs. In section

Re: [PATCH] include destination into dlr lookup

2004-09-26 Thread Alan McNatty
Hi Alex, One of the problems in the past with the DLR search using destination address is that it has been contrary to SMPP v3.4 specs. In section 2.11 Message Types we can note: 'The destination address will be taken from the source address of the original short message which generated the deliv

Re: [PATCH] include destination into dlr lookup (#2)

2004-09-26 Thread Enver ALTIN
Hi Alexander, On Sun, 2004-09-26 at 17:26 +0200, Alexander Malysh wrote: > that's why I say, we can't use direct db lookup ;) and with proposed patch, > it just works ;) Oh, well. Reading the older thread about this subject Guillaume Cottenceau pointed me to[1] a while ago, I liked the "I will te

Re: [PATCH] include destination into dlr lookup (#2)

2004-09-26 Thread Alexander Malysh
Enver ALTIN wrote: > On Sun, 2004-09-26 at 18:03 +0300, Enver ALTIN wrote: >> At a glance, looks good to me. I think I'll try a quick test with my >> weird-acting UCP service provider tomorrow :) > > BTW, let me explain what "weird-acting" means, in case it may sched a > light for something else.

Re: [PATCH] include destination into dlr lookup (#2)

2004-09-26 Thread Enver ALTIN
On Sun, 2004-09-26 at 18:03 +0300, Enver ALTIN wrote: > At a glance, looks good to me. I think I'll try a quick test with my > weird-acting UCP service provider tomorrow :) BTW, let me explain what "weird-acting" means, in case it may sched a light for something else. I'm sending a message to a re

Re: [PATCH] include destination into dlr lookup (#2)

2004-09-26 Thread Enver ALTIN
Hi, On Sat, 2004-09-25 at 22:00 +0200, Alexander Malysh wrote: > attached is the second version of this patch that fixes some stupid bugs... At a glance, looks good to me. I think I'll try a quick test with my weird-acting UCP service provider tomorrow :) -- Enver ALTIN |

Re: [PATCH] include destination into dlr lookup

2004-09-26 Thread Alexander Malysh
Hi, Enver ALTIN wrote: > Hi Alexander, > > On Sat, 2004-09-25 at 21:28 +0200, Alexander Malysh wrote: >> * It's not possible to use the whole destination in sql query, so we >> just * strip country prefix and do DB lookup like 'like "%striped-dst"' >> and so * increase probability to find a r

Re: [PATCH] include destination into dlr lookup

2004-09-26 Thread Enver ALTIN
Hi Alexander, On Sat, 2004-09-25 at 21:28 +0200, Alexander Malysh wrote: > * It's not possible to use the whole destination in sql query, so we just > * strip country prefix and do DB lookup like 'like "%striped-dst"' and so > * increase probability to find a right DB entry. This approach seem

Re: [PATCH] include destination into dlr lookup (#2)

2004-09-25 Thread Alexander Malysh
Hi again, attached is the second version of this patch that fixes some stupid bugs... P.S. seems nobody ever used 'dlr_flush_oracle' because table name was hardcoded to 'DLR' ;) Alexander Malysh wrote: > Hi, > > attched you can find patch that includes destination address into dlr > lookup. Th

[PATCH] include destination into dlr lookup

2004-09-25 Thread Alexander Malysh
Hi, attched you can find patch that includes destination address into dlr lookup. This patch implements include all necessary changes for all dlr storage types. Additionally this patch changes my email addr. from @centrium.de to @kannel.org and does some cleanup for sql query generation. What thi