Re: [RFC] Resouce leak/Denial of service in bb_boxc.c

2003-09-02 Thread Alexander Malysh
Hi Paul, can you please test my patch from the message with subject: [PATCH] boxc connections (#2) It should fix this problem. Thanks in advance... On Monday 25 August 2003 12:55, Paul Keogh wrote: In boxc_sender (), the code /* wait for smsbox identification */ if

[RFC] Resouce leak/Denial of service in bb_boxc.c

2003-08-25 Thread Paul Keogh
In boxc_sender (), the code /* wait for smsbox identification */ if (bb_status != BB_DEAD conn-alive conn-is_wap == 0) { mutex_lock(conn-boxc_id_mutex); debug(bb.boxc, 0, boxc_sender: sender unlocked); mutex_unlock(conn-boxc_id_mutex); } means that this

Re: [RFC] Resouce leak/Denial of service in bb_boxc.c

2003-08-25 Thread Stipe Tolj
Paul Keogh wrote: In boxc_sender (), the code /* wait for smsbox identification */ if (bb_status != BB_DEAD conn-alive conn-is_wap == 0) { mutex_lock(conn-boxc_id_mutex); debug(bb.boxc, 0, boxc_sender: sender unlocked); mutex_unlock(conn-boxc_id_mutex);

Re: [RFC] Resouce leak/Denial of service in bb_boxc.c

2003-08-25 Thread Stipe Tolj
I think some code is needed in boxc_receive() to cater for this; ie. msg = read_from_box(conn); if (msg == NULL) { /* garbage/connection lost */ conn-alive = 0; if (conn - boxc_id == NULL) mutex_unlock(conn-boxc_id_mutex);