PATCH: Small bug with DLRs

2007-03-30 Thread Ben Suffolk
Just noticed that when the SMSC rejects a message at submission the dlr was set to 22 (0x16) not 16 (0x10). Just a bad define in the header file. Regards Ben dlr_smsc_fail.patch Description: Binary data

Re: PATCH: Small bug with DLRs

2007-04-03 Thread Alexander Malysh
Hi Ben, your patch is not correct. You will receive SMSC_FAIL or DLR_FAIL depending on the dlr_mask you used. If you set dlr_mask to request SMSC_FAIL then you will receive it if only DLR_FAIL requested then DLR_FAIL will be set. Ben Suffolk wrote: > Just noticed that when the SMSC rejects a mes

Re: PATCH: Small bug with DLRs

2007-04-03 Thread Ben Suffolk
Ok, Slightly confused then, the SMSC rejected my message at submission, and so I should have got back a dlr_mask value of 16 (dec) in the DLR according to the documentation, but I got back 22 (dec). Maybe I jumped to the wrong conclusion seeing the DLR_SMSC_FAIL set to 0x16 (22 dec) in th

Re: PATCH: Small bug with DLRs

2007-04-03 Thread Alexander Malysh
Hi, it's pretty simple. If in documentation mentioned 16 then it's hex value and all values except 0x16 match with dec because below 0x10 dec and hex equal :) Ben Suffolk wrote: > Ok, > > Slightly confused then, the SMSC rejected my message at submission, > and so I should have got back a dlr_m

Re: PATCH: Small bug with DLRs

2007-04-03 Thread Ben Suffolk
I had assumed it was a binary bit mask :- 1 Success 00010 Fail 00100 Buffered 01000 SMSC Success 1 SMSC Failed Which would tie up with the value of decimal 31(1) for submission of all DLRs. However if the last value is in fact 0x16 (10110) then it would cause problems with mat

Re: PATCH: Small bug with DLRs

2007-04-03 Thread Alexander Malysh
Hi Ben, sorry you are right. That was 0x10 and is in my local copy :) Stipe made commit that changed it: 1.21 (stolj07-Jan-07): #define DLR_SMSC_FAIL 0x16 Ok, I will correct it in cvs and commit. Thanks for pointing it! Ben Suffolk wrote: > I had assumed it was a binary

Re: PATCH: Small bug with DLRs

2007-04-03 Thread Ben Suffolk
No worries, You had me thinking I was going mad :-) Glad I'm not Ben On 3 Apr 2007, at 15:27, Alexander Malysh wrote: Hi Ben, sorry you are right. That was 0x10 and is in my local copy :) Stipe made commit that changed it: 1.21 (stolj07-Jan-07): #define DLR_SMSC_FAIL

Re: PATCH: Small bug with DLRs

2007-04-03 Thread Stipe Tolj
Alexander Malysh wrote: Hi Ben, sorry you are right. That was 0x10 and is in my local copy :) Stipe made commit that changed it: 1.21 (stolj07-Jan-07): #define DLR_SMSC_FAIL 0x16 Ok, I will correct it in cvs and commit. yep, my fault, appologies... I mis-interpreted it