Re: Question about dlr_add and dlr_find parameters

2009-05-04 Thread Alejandro Guerrieri
Please check on my latest patch over the "smsc-dlr-alias" parameter. To use the dlr_alias, it modifies the code on the smsc's that were using the ->name instead of ->id to be as follows: -msg = dlr_find(conn->name, timestamp, destination, code); +msg = dlr_find((conn->dlr_ali

Re: Question about dlr_add and dlr_find parameters

2009-05-04 Thread Alejandro Guerrieri
Ok, so something similar to this would make sense I guess: gw/smsc/smsc_emi.c: dlr_add((conn->id ? conn->id : privdata->name), ts, m); I think on most if not all SMSC's connections the id is a mandatory parameter anyway. So unless it's not mandatory, the "id" would make more sense. Reg

Re: Question about dlr_add and dlr_find parameters

2009-05-04 Thread Andreas Fink
in all cases the conection name,is being passed. If I remember right it was mainly used for logging purposes. apparently there where cases in EMI where conn->id was empty or so. unifying it would make sense in my eyes. Note: I wrote the initial implementation in SMPP and EMI/UCP. The CIMD2 an

Question about dlr_add and dlr_find parameters

2009-05-04 Thread Alejandro Guerrieri
Hi, Just a quick question: I'm checking on different smsc's implementations and I've noticed that, despite that dlr_add and dlr_find are usually called using conn->id for the first parameter (smsc), on some smsc's conn->name is used instead: gw/smsc/smsc_cimd2.c: dlr_add(conn->name, ts,