Re: [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)

2010-05-07 Thread Nitin Gupta
Hi, On 05/08/2010 11:59 AM, Pekka Enberg wrote: > > Andrew Morton wrote: >> The driver appears to be controlled by some nasty-looking ioctl against >> some fd. None of it is documented anywhere. It should be. You're >> proposing here a permanent extension to the kernel ABI which we will >> nee

Re: [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)

2010-05-07 Thread Pekka Enberg
Hi Andrew, Andrew Morton wrote: Looking at the changelogs I'm seeing no information about the effectiveness of ramzswap - how much memory it saves. As that's the entire point of the driver, that would be a rather important thing to have included in the commit comments. We cannot make the decis

Re: [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)

2010-05-07 Thread Nitin Gupta
On Sat, May 8, 2010 at 1:25 AM, Andrew Morton wrote: > On Fri, 7 May 2010 12:55:04 +0530 > Nitin Gupta wrote: > > > > Looking at the changelogs I'm seeing no information about the > effectiveness of ramzswap - how much memory it saves. As that's the > entire point of the driver, that would b

Patch to auto-load MSFT PV NIC driver

2010-05-07 Thread Ky Srinivasan
I am attaching a patch to auto-load hv_netvsc. Regards, K. Y From: K. Y. Srinivasan Subject: Auto-load the hyperV PV net driver. References: None Patch-mainline: Signed-off-by: K. Y. Srinivasan Index: linux/drivers/staging/hv/netvsc_drv.c ==

Re: [PATCH] Staging: vt6656: remove unnecessary #ifdef

2010-05-07 Thread Charles Clément
On Fri, May 07, 2010 at 06:13:50PM -0500, H Hartley Sweeten wrote: > On Friday, May 07, 2010 3:47 PM, Charles Clément wrote: > > Subject: [PATCH] Staging: vt6656: remove unnecessary #ifdef > > > > > > Signed-off-by: Charles Clément > > --- > > drivers/staging/vt6656/ttype.h |5 - > > 1 fi

RE: [PATCH] Staging: vt6656: remove unnecessary #ifdef

2010-05-07 Thread H Hartley Sweeten
On Friday, May 07, 2010 3:47 PM, Charles Clément wrote: > Subject: [PATCH] Staging: vt6656: remove unnecessary #ifdef > > > Signed-off-by: Charles Clément > --- > drivers/staging/vt6656/ttype.h |5 - > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/vt665

Re: [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)

2010-05-07 Thread Andrew Morton
On Fri, 7 May 2010 12:55:04 +0530 Nitin Gupta wrote: > (tested on mainline but should apply to linux-next cleanly) > > * Changelog: v2 vs initial patches >- directly add swap free callback to block_device_operations > instead of using 'notifiers' for various swap events. > > ramzswap

[PATCH] Staging: vt6656: remove unnecessary #ifdef

2010-05-07 Thread Charles Clément
Signed-off-by: Charles Clément --- drivers/staging/vt6656/ttype.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h index 692b63e..5768862 100644 --- a/drivers/staging/vt6656/ttype.h +++ b/drivers/staging/

[PATCH] staging: rtl8192x: sync the various rtl819x_Qos.h files

2010-05-07 Thread H Hartley Sweeten
The rtl8192e, rtl8192su, and rtl8192u drivers all share what appears to be a common private ieee80211 stack. Various patches have been applied to the rtl819x_Qos.h file for some of the drivers but not the others. This sync's the files based on all the applied patches. Signed-off-by: H Hartley Sw

[PATCH] staging: rtl8192x: sync the various rtl819x_TSProc.c files

2010-05-07 Thread H Hartley Sweeten
The rtl8192e, rtl8192su, and rtl8192u drivers all share what appears to be a common private ieee80211 stack. Various patches have been applied to the rtl819x_TSProc.c file for some of the drivers but not the others. This sync's the files based on all the applied patches. Signed-off-by: H Hartley

[PATCH] staging: adis16255 - TODO issues resolved and typos removed

2010-05-07 Thread Matthias Brugger
This patch adds the adis16255 driver to the build system under the staging directory. It solves also most issues mentioned in TODO list: - sample rate exported to sysfs - spi_adis16255_bringup and spi_adis16255_shutdown encapsulated - chip selftest in spi_adis16255_bringup - kernel messages reduce

[PATCH 1/3] Staging: vt6655: remove unused SUCCESS definition

2010-05-07 Thread Charles Clément
Signed-off-by: Charles Clément --- drivers/staging/vt6655/ttype.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/ttype.h b/drivers/staging/vt6655/ttype.h index 4dfad04..dc061c6 100644 --- a/drivers/staging/vt6655/ttype.h +++ b/drivers/staging/

Re: [Q] staging: adis16255: something screwy...

2010-05-07 Thread matthias
2010/5/7 H Hartley Sweeten : > It appears something screwy happened when the adis16255 driver was first > added to the staging tree. > > There are a bunch of thru characters in the file instead of the > real code.  So you get stuff like: > >        struct spi_device *spi piadis->spi; > > instead

[Q] staging: adis16255: something screwy...

2010-05-07 Thread H Hartley Sweeten
It appears something screwy happened when the adis16255 driver was first added to the staging tree. There are a bunch of thru characters in the file instead of the real code. So you get stuff like: struct spi_device *spi piadis->spi; instead of: struct spi_device *spi = spiad

Re: [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)

2010-05-07 Thread Linus Torvalds
On Fri, 7 May 2010, Pekka Enberg wrote: > > The series looks good to me: > > Acked-by: Pekka Enberg Yeah, I think I'm finally ok with it too. Acked-by: Linus Torvalds Thanks, Linus ___ devel mailing list devel@linuxdriver

Re: [PATCH 2/3] Add swap slot free callback to block_device_operations

2010-05-07 Thread Nigel Cunningham
Hi. On 07/05/10 19:48, Nitin Gupta wrote: +if ((p->flags& SWP_BLKDEV)&& +disk->fops->swap_slot_free_notify) +disk->fops->swap_slot_free_notify(p->bdev, offset); Is this p->flags& SWP_BLKDEV logic reversed? (Don't you want the notifier called for devices t

Re: [PATCH 2/3] Add swap slot free callback to block_device_operations

2010-05-07 Thread Nitin Gupta
On 05/07/2010 02:52 PM, Nigel Cunningham wrote: > Hi. > > On 07/05/10 17:25, Nitin Gupta wrote: >> This callback is required when RAM based devices are used as swap disks. >> One such device is ramzswap which is used as compressed in-memory swap >> disk. For such devices, we need a callback as so

Re: [PATCH 1/3] Add flag to identify block swap devices

2010-05-07 Thread Nigel Cunningham
Hi again. On 07/05/10 17:25, Nitin Gupta wrote: Added SWP_BLKDEV flag to distinguish block and regular file backed swap devices. We could also check if a swap is entire block device, rather than a file, by: S_ISBLK(swap_info_struct->swap_file->f_mapping->host->i_mode) but, I think, simply checki

Re: [PATCH 2/3] Add swap slot free callback to block_device_operations

2010-05-07 Thread Nigel Cunningham
Hi. On 07/05/10 17:25, Nitin Gupta wrote: This callback is required when RAM based devices are used as swap disks. One such device is ramzswap which is used as compressed in-memory swap disk. For such devices, we need a callback as soon as a swap slot is no longer used to allow freeing memory a

Re: [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)

2010-05-07 Thread Pekka Enberg
Nitin Gupta kirjoitti: (tested on mainline but should apply to linux-next cleanly) * Changelog: v2 vs initial patches - directly add swap free callback to block_device_operations instead of using 'notifiers' for various swap events. ramzswap driver creates RAM based block devices which

[PATCH 3/3] ramzswap: Handler for swap slot free callback

2010-05-07 Thread Nitin Gupta
Install handler for swap_slot_free_notify callback which is called when a swap slot is no longer used. This handler immediately frees memory allocated corresponding to the given swap slot. Signed-off-by: Nitin Gupta --- drivers/staging/ramzswap/TODO |5 - drivers/staging/ramzswa

[PATCH 2/3] Add swap slot free callback to block_device_operations

2010-05-07 Thread Nitin Gupta
This callback is required when RAM based devices are used as swap disks. One such device is ramzswap which is used as compressed in-memory swap disk. For such devices, we need a callback as soon as a swap slot is no longer used to allow freeing memory allocated for this slot. Without this callbac

[PATCH 1/3] Add flag to identify block swap devices

2010-05-07 Thread Nitin Gupta
Added SWP_BLKDEV flag to distinguish block and regular file backed swap devices. We could also check if a swap is entire block device, rather than a file, by: S_ISBLK(swap_info_struct->swap_file->f_mapping->host->i_mode) but, I think, simply checking this flag is more convenient. Signed-off-by: Ni

[PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)

2010-05-07 Thread Nitin Gupta
(tested on mainline but should apply to linux-next cleanly) * Changelog: v2 vs initial patches - directly add swap free callback to block_device_operations instead of using 'notifiers' for various swap events. ramzswap driver creates RAM based block devices which can be used (only) as sw