On 05/26/2010 11:25 PM, Haiyang Zhang wrote:
>> From: Greg KH [mailto:gre...@suse.de]
>>> + VmbusChannelOpen(newChannel, 2 * PAGE_SIZE,
>>> +2 * PAGE_SIZE, NULL, 0,
>>> +hv_cb_utils[cnt].callback,
Removed kfree(NULL checks) that were not necessary
Signed-off-by: Scott Kidder
---
drivers/staging/crystalhd/crystalhd_lnx.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers/staging/crystalhd/crystalhd_lnx.c
ind
This is a patch to zdusb.c that fixes whitespace,
C99 comment, and other style issues found by the
checkpatch.pl tool
Signed-off-by: Scott Kidder
---
drivers/staging/otus/zdusb.c | 251 --
1 files changed, 119 insertions(+), 132 deletions(-)
diff --git a
Patches wbusb.c to replace printk usage (missing KERN_ levels) with pr_info.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wbusb.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbu
Patches reg.c to replace printk usage (missing KERN_ levels) with pr_info.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/reg.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index d9a81
Patches wb35tx.c to replace printk usage (missing KERN_ levels) with
appropriate pr_info and pr_err calls.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wb35tx.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/
This patches wb35rx_s.h to replace all the C99 style comments (//) with C89
style (/* ... */), as reported by checkpatch.pl.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wb35rx_s.h | 42 ++--
1 files changed, 21 insertions(+), 21 deletions(-)
diff -
Patches wb35rx_s.h to correct the spacing around brackets and pointers as
reported by checkpatch.pl
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wb35rx_s.h | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx_s.h
b/drivers/
This patches wb35rx_f.h to replace all the C99 style comments (//) with C89
style (/* ... */), as reported by checkpatch.pl.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wb35rx_f.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/winbond/w
Patches wb35rx_f.h to correct the spacing around brackets and pointers as
reported by checkpatch.pl
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wb35rx_f.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx_f.h
b/drivers/stag
Patches wb35rx.c to replace printk usage (missing KERN_ levels) with
appropriate pr_info and pr_err calls.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wb35rx.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx.c b/
Patches wb35reg.c to replace printk usage (missing KERN_ levels) with pr_err.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/wb35reg.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg.c
b/drivers/staging/winbond/wb35reg.c
This patches phy_calibration.c to replace all the C99 style comments (//) with
C89 style (/* ... */), as reported by checkpatch.pl.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/phy_calibration.c | 387 ++---
1 files changed, 191 insertions(+), 196 deletions(-
Patches phy_calibration.c to correct the spacing around brackets, braces, less
than/greater than, equals and remove some extraneous braces as reported by
checkpatch.pl
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/phy_calibration.c | 471 ++---
1 files change
Patches mds.c to replace printk usage (missing KERN_ levels) with appropriate
pr_info and pr_err calls.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/mds.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/mds.c b/drivers/staging
Patches mds.c to correct the spacing around brackets, braces, less than/greater
than, equals as reported by checkpatch.pl
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/mds.c | 153 ++---
1 files changed, 66 insertions(+), 87 deletions(-)
diff --gi
This patches mac_structures.h to replace all the C99 style comments (//) with
C89 style (/* ... */), as reported by checkpatch.pl.
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/mac_structures.h | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/d
Patches mac_structures.h to correct the spacing around brackets and colons as
reported by checkpatch.pl
Signed-off-by: Mike Sheldon
---
drivers/staging/winbond/mac_structures.h | 86 -
1 files changed, 36 insertions(+), 50 deletions(-)
diff --git a/drivers/staging
Resolved whitespace-related checkpatch findings in .h files
Signed-off-by: Andres More
---
drivers/staging/vt6656/80211mgr.h | 31 --
drivers/staging/vt6656/baseband.h | 19 -
drivers/staging/vt6656/bssdb.h |8 ++--
drivers/staging/vt6656/channel.h| 12
> From: Greg KH [mailto:gre...@suse.de]
> How about a lock!
>
> What's so scary about a pretty little semaphore? They are all cute and
> cuddley and don't bite anyone. You should not be afraid to use them,
> they are here to do your bidding.
No problem, we will add a lock here.
> > The VmbusCh
On Wed, May 26, 2010 at 10:23:08PM +, Haiyang Zhang wrote:
> > From: Greg KH [mailto:gre...@suse.de]
> > > As discussed previously, I used atomic_t to handle more general case
> > > if vmbus interrupts happen on every cpu.
> >
> > Ok, but then you should use a lock to protect the variable, not
> From: Greg KH [mailto:gre...@suse.de]
> > As discussed previously, I used atomic_t to handle more general case
> > if vmbus interrupts happen on every cpu.
>
> Ok, but then you should use a lock to protect the variable, not an
> atomic_t.
> If you care about this, because some other thread is lo
> -Original Message-
> From: Greg KH [mailto:gre...@suse.de]
> Sent: Wednesday, May 26, 2010 2:49 PM
> To: Haiyang Zhang
> Cc: 'linux-ker...@vger.kernel.org'; 'de...@driverdev.osuosl.org';
> 'virtualizat...@lists.osdl.org'; Hank Janssen
> Subject: Re: [PATCH 1/1] staging: hv: Fix race co
On Wed, May 26, 2010 at 09:25:31PM +, Haiyang Zhang wrote:
> > From: Greg KH [mailto:gre...@suse.de]
> > > + static atomic_t ic_channel_initcnt = ATOMIC_INIT(0);
> > Why is this an atomic_t?
>
> As discussed previously, I used atomic_t to handle more general case
> if vmbus interrupts happen
On Wednesday 26 May 2010 20:28:57 Bashlykov Arthur wrote:
Hi Arthur
> @@ -87,15 +87,15 @@ int ieee80211_wx_get_freq(struct ieee80211_device *ieee,
>struct iw_request_info *a,
>union iwreq_data *wrqu, char *b)
> {
> - struct iw_freq *fw
> From: Greg KH [mailto:gre...@suse.de]
> > + static atomic_t ic_channel_initcnt = ATOMIC_INIT(0);
> Why is this an atomic_t?
As discussed previously, I used atomic_t to handle more general case
if vmbus interrupts happen on every cpu.
> > + VmbusChannelOpen(newChannel, 2
On Wed, May 26, 2010 at 04:54:39PM +, Haiyang Zhang wrote:
> From: Haiyang Zhang
>
> Subject: [PATCH] staging: hv: Fix race condition on IC channel initialization
> There is a possible race condition when hv_utils starts to load immediately
> after hv_vmbus is loading - null pointer error cou
On Wed, May 26, 2010 at 10:48:08PM +0400, Denis Kirjanov wrote:
> On Wed, May 26, 2010 at 20:28 +0400, Bashlykov Arthur wrote:
> > - if (!ieee->proto_started){
> > + if (!ieee->proto_started) {
> > ieee->iw_mode = wrqu->mode;
>
> I guess we can drop braces with single else stateme
On Wed, May 26, 2010 at 20:28 +0400, Bashlykov Arthur wrote:
> ---
> .../rtl8192su/ieee80211/ieee80211_softmac_wx.c | 149
> +---
> 1 files changed, 70 insertions(+), 79 deletions(-)
>
> diff --git a/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac_wx.c
> b/drivers/sta
---
drivers/staging/rtl8192su/ieee80211/ieee80211_tx.c | 429 ++--
1 files changed, 206 insertions(+), 223 deletions(-)
diff --git a/drivers/staging/rtl8192su/ieee80211/ieee80211_tx.c
b/drivers/staging/rtl8192su/ieee80211/ieee80211_tx.c
index 484c3ab..1a41809 100644
--- a/driver
From: Haiyang Zhang
Subject: [PATCH] staging: hv: Fix race condition on IC channel initialization
There is a possible race condition when hv_utils starts to load immediately
after hv_vmbus is loading - null pointer error could happen.
This patch added an event waiting to ensure all channels are r
---
.../rtl8192su/ieee80211/ieee80211_softmac_wx.c | 149 +---
1 files changed, 70 insertions(+), 79 deletions(-)
diff --git a/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac_wx.c
b/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac_wx.c
index 9ded253..3e0527c 10064
From: Julia Lawall
Add a spin_unlock and mutex_unlock missing on the error path.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression E1;
@@
* spin_lock(E1,...);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
*
On Wed, May 26, 2010 at 01:39:42PM +0200, Jiri Kosina wrote:
> On Tue, 25 May 2010, Charles Clément wrote:
> > > diff --git a/drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_tkip.c
> > > b/drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_tkip.c
> > > index 65f4889..14ca610 100644
> > > --- a
Current linux kernel has GENERIC_HDLC_VERSION equal to 4, no need to have
dead code in-kernel which was there for ancient kernel versions.
Signed-off-by: Jiri Kosina
---
drivers/staging/cxt1e1/linux.c | 40
drivers/staging/cxt1e1/pmcc4.h |2 ++
2 f
On Tue, 25 May 2010, Charles Clément wrote:
> Hello Jiri,
>
> On Tue, May 25, 2010 at 02:16:50PM +0200, Jiri Kosina wrote:
> > On Tue, 25 May 2010, Andreas Schwab wrote:
>
> > diff --git a/drivers/staging/cxt1e1/pmcc4.h b/drivers/staging/cxt1e1/pmcc4.h
> > index 26c1f0e..e288a0a 100644
> > --- a
>From 14646b7f6630920f0ff0c067611ffcb9c6820d98 Mon Sep 17 00:00:00 2001
From: Jiri Kosina
Date: Tue, 25 May 2010 11:59:19 +0200
Subject: [PATCH] staging: cxt1e1: remove all code dependent on
LINUX_VERSION_CODE
Remove all code which is dead for in-kernel driver due to being
ifdefed by LINUX_VERSI
Remove all code which is dead for in-kernel driver due to being
ifdefed by LINUX_VERSION_CODE.
While at it, also remove surrounding code which is commented out,
or '#if 1' nops.
Signed-off-by: Jiri Kosina
---
drivers/staging/rtl8192su/r8192SU_led.c |9 -
1 files changed, 0 insertion
Remove all code which is dead for in-kernel driver due to being
ifdefed by LINUX_VERSION_CODE.
While at it, also remove surrounding code which is commented out,
or '#if 1' nops.
Signed-off-by: Jiri Kosina
---
drivers/staging/cxt1e1/functions.c | 12 --
drivers/staging/cxt1e1/hwprobe
Hello,
I want to solicit your attention to recieve money on my behalf.
I will send you the full details and more information about myself and the
funds.
I wait to hear from you immediately you receive this mail,
NB: Please be informed that this transaction is 100% legal.
Thank you
Barrister John W
40 matches
Mail list logo
