Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Dmitry Torokhov
On Mon, May 31, 2010 at 10:48:32PM +0100, Richard Purdie wrote: > On Mon, 2010-05-31 at 12:09 -0700, Dmitry Torokhov wrote: > > On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > > > I2C-drivers can use the clientdata-pointer to point to private data. As > > > I2C > > > devices are no

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Richard Purdie
On Mon, 2010-05-31 at 12:09 -0700, Dmitry Torokhov wrote: > On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > > devices are not really unregistered, but merely detached from their driver, > > it > > used

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Jean Delvare
Hi Dmitry, On Mon, 31 May 2010 12:09:12 -0700, Dmitry Torokhov wrote: > Frankly I'd prefer taking input stuff through my tree with the goal of > .36 merge window just to minimize potential merge issues. This is a > simple cleanup patch that has no dependencies, so there is little gain > from doing

Re: [PATCH 1/3] Support generic I/O requests

2010-05-31 Thread Nitin Gupta
Hi Minchan, On 05/31/2010 09:11 PM, Minchan Kim wrote: > > On Mon, 2010-05-24 at 19:48 +0530, Nitin Gupta wrote: >> >> - Scalability: There is only one (per-device) de/compression >> buffer stats. This can lead to significant contention, especially >> when used for generic (non-swap) purposes.

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Dmitry Torokhov
Hi Wolfram, On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > devices are not really unregistered, but merely detached from their driver, it > used to be the drivers obligation to clear this pointer during

Re: [PATCH] Drivers: Stagins: memrar: cleanup

2010-05-31 Thread Jiri Slaby
On 05/31/2010 05:04 PM, Spyros Papageorgiou wrote: > From:Spyros Papageorgiou > > Removed an unneeded struct specifier in function call. > > Signed-off-by: Spyros Papageorgiou > --- > drivers/staging/memrar/memrar_allocator.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) >

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Greg KH
On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > devices are not really unregistered, but merely detached from their driver, it > used to be the drivers obligation to clear this pointer during remove() or a

Re: [PATCH 1/3] Support generic I/O requests

2010-05-31 Thread Minchan Kim
Hi, Nitin. Sorry for late review. On Mon, 2010-05-24 at 19:48 +0530, Nitin Gupta wrote: > Currently, ramzwap devices (/dev/ramzswapX) can only > be used as swap disks since it was hard-coded to consider > only the first request in bio vector. > > Now, we iterate over all the segments in an incom

[PATCH] Drivers: Stagins: memrar: cleanup

2010-05-31 Thread Spyros Papageorgiou
From:Spyros Papageorgiou Removed an unneeded struct specifier in function call. Signed-off-by: Spyros Papageorgiou --- drivers/staging/memrar/memrar_allocator.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/memrar/memrar_allocator.c b/drivers/st

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Mark Brown
On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > devices are not really unregistered, but merely detached from their driver, it > used to be the drivers obligation to clear this pointer during remove() or a

[PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Wolfram Sang
I2C-drivers can use the clientdata-pointer to point to private data. As I2C devices are not really unregistered, but merely detached from their driver, it used to be the drivers obligation to clear this pointer during remove() or a failed probe(). As a couple of drivers forgot to do this, it was ag

[PATCH] Comedi: staging: Fixed whitespace and braces in adl_pci9118.c

2010-05-31 Thread Mark
This patch fixes a few coding style issues discovered in adl_9118.c by checkpatch Signed-off-by: Mark Rankilor --- drivers/staging/comedi/drivers/adl_pci9118.c | 39 +++-- 1 files changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pc

[PATCH] Staging: comedi: Fixed long lines in gsc_hpdi.c

2010-05-31 Thread Mark
This patch fixes some long line lengths in gsc_hpdi.c as found by the checkpatch.pl tool Signed-off-by: Mark Rankilor --- drivers/staging/comedi/drivers/gsc_hpdi.c | 30 +++- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH] Staging: comedi: Refactored code to fix long line lengths in drivers.c

2010-05-31 Thread Mark
This patch refactors some code to clean up some long line length checkpatch warnings. Signed-off-by: Mark Rankilor Signed-off-by: Joe Perches --- drivers/staging/comedi/drivers.c | 188 ++ 1 files changed, 87 insertions(+), 101 deletions(-) diff --git a/dri

[PATCH] Staging: comedi: Checkpatch cleanups in adl_pci9111.c

2010-05-31 Thread Mark
This patch cleans up some various warnings generated from checkpatch.pl Signed-off-by: Mark Rankilor --- drivers/staging/comedi/drivers/adl_pci9111.c | 105 ++--- 1 files changed, 59 insertions(+), 46 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c b