Re: [PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c

2010-07-06 Thread Joe Eloff
On Tue, 2010-07-06 at 22:29 +0100, Alan Cox wrote: > On Tue, 06 Jul 2010 19:17:08 +0200 > Joe Eloff wrote: > > > >From e23e19537c4d62bc76ae982859d3c3225a45d9c2 Mon Sep 17 00:00:00 > > >2001 > > From: Joe Eloff > > Date: Tue, 6 Jul 2010 19:13:28 +0200 > > Subject: [PATCH] Staging: et131x: fix cod

Re: [PATCH] staging/panel: Prevent double-calling of parport_release - fix oops.

2010-07-06 Thread Willy Tarreau
On Wed, Jul 07, 2010 at 04:52:16AM +0200, Peter Huewe wrote: > From: Peter Huewe > > This patch prevents the code from calling parport_release and > parport_unregister_device twice with the same arguments - and thus fixes an > oops. > > Rationale: > After the first call the parport is already r

[PATCH] staging/panel: Prevent double-calling of parport_release - fix oops.

2010-07-06 Thread Peter Huewe
From: Peter Huewe This patch prevents the code from calling parport_release and parport_unregister_device twice with the same arguments - and thus fixes an oops. Rationale: After the first call the parport is already released and the handle isn't valid anymore and calling parport_release and pa

Re: Oops after unloading staging/panel/panel.ko

2010-07-06 Thread Peter Hüwe
Am Mittwoch 07 Juli 2010 03:38:49 schrieb Peter Hüwe: > Here is another oops trace caused by the same problem. I think I've tracked it down. parport_release and parport_unregister_device get called twice while unloading the module - after the first call the handle isn't valid anymore and thus c

Re: Oops after unloading staging/panel/panel.ko

2010-07-06 Thread Peter Hüwe
Here is another oops trace caused by the same problem. This time I inserted the module using # insmod panel.ko parport=0 lcd_height=2 lcd_width=20 lcd_charset=1 lcd_type=5 lcd_e_pin=1 lcd_rs_pin=14 lcd_rw_pin=0 parport_pc 00:09: reported by Plug and Play ACPI parport0: PC-style at 0x378, irq 7 [

Oops after unloading staging/panel/panel.ko

2010-07-06 Thread Peter Hüwe
Hi, I just tried to get the driver working with my lcd display (hd44780 compatible) and the kernel oops'ed - but unfortunately I can't figure out why. Steps to reproduce: 1) compile panel driver with CONFIG_PANEL=m CONFIG_PANEL_PARPORT=0 CONFIG_PANEL_PROFILE=0 CONFIG_PANEL_KEYPAD=0 CONFIG_PANEL_

Re: [PATCH] Staging: dt3155: fix coding style issues in dt3155_drv.c

2010-07-06 Thread Simon Horman
On Tue, Jul 06, 2010 at 12:25:35PM -0500, Aldo Cedillo wrote: > > diff --git a/drivers/staging/dt3155/dt3155_drv.c > > b/drivers/staging/dt3155/dt3155_drv.c > > index 66db878..f6edd66 100644 > > --- a/drivers/staging/dt3155/dt3155_drv.c > > +++ b/drivers/staging/dt3155/dt3155_drv.c > > @@ -308,33

Re: [PATCH 1/3] Staging: vt6655: remove boolean TRUE

2010-07-06 Thread Joe Perches
On Tue, 2010-07-06 at 08:18 -0700, Greg KH wrote: > On Tue, Jul 06, 2010 at 04:45:41PM +0200, Charles Clément wrote: > > case WLAN_EID_RSN_WPA: > > if (pFrame->pRSNWPA == NULL) { > > -if (WPAb_Is_RSN((PWLAN_IE_RSN_EXT)pItem) == TRUE) > > +

Re: [PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c

2010-07-06 Thread Alan Cox
On Tue, 06 Jul 2010 19:17:08 +0200 Joe Eloff wrote: > >From e23e19537c4d62bc76ae982859d3c3225a45d9c2 Mon Sep 17 00:00:00 > >2001 > From: Joe Eloff > Date: Tue, 6 Jul 2010 19:13:28 +0200 > Subject: [PATCH] Staging: et131x: fix coding style issues in > et131x_initpci.c > > This is a patch to the

Re: [PATCH] Staging: dt3155: fix coding style issues in dt3155_drv.c

2010-07-06 Thread Aldo Cedillo
> > I presumed all issues would be incorporated into checkpatch.pl. I guess > it isn't. > I think the safest be here then would be to fix the script as to then > have a single point of failure rather than interpretation and reference > documentation in conjunction to the script. > > Regards, > > Jo

Re: [PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c

2010-07-06 Thread Nick Bowler
On 19:17 Tue 06 Jul , Joe Eloff wrote: > >From e23e19537c4d62bc76ae982859d3c3225a45d9c2 Mon Sep 17 00:00:00 2001 > From: Joe Eloff > Date: Tue, 6 Jul 2010 19:13:28 +0200 > Subject: [PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c > > This is a patch to the et131x_initpci.c

Re: [PATCH 1/3] Staging: vt6655: remove boolean TRUE

2010-07-06 Thread Greg KH
On Tue, Jul 06, 2010 at 07:29:47PM +0200, Charles Clément wrote: > On Tue, Jul 06, 2010 at 08:18:27AM -0700, Greg Kroah-Hartman wrote: > > On Tue, Jul 06, 2010 at 04:45:41PM +0200, Charles Clément wrote: > > > > > > Signed-off-by: Charles Clément > > > --- > > > drivers/staging/vt6655/80211mgr.c

Re: [PATCH] Staging: dt3155: fix coding style issues in dt3155_drv.c

2010-07-06 Thread Joe Eloff
On Tue, 2010-07-06 at 12:25 -0500, Aldo Cedillo wrote: > > diff --git a/drivers/staging/dt3155/dt3155_drv.c > > b/drivers/staging/dt3155/dt3155_drv.c > > index 66db878..f6edd66 100644 > > --- a/drivers/staging/dt3155/dt3155_drv.c > > +++ b/drivers/staging/dt3155/dt3155_drv.c > > @@ -308,33 +308,42

Re: [PATCH] Staging: cx25821: fix brace coding style issue in cx25821-audio-upstream.c

2010-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2010 14:24, Joe Eloff escreveu: > On Tue, 2010-07-06 at 12:12 -0500, Aldo Cedillo wrote: >>> Subject: [PATCH] Staging: cx25821: fix brace coding style issue in >>> cx25821-audio-upstream.c >>> This is a patch to the cx25821.c file that fixes up a brace warning found >>> by the checkpatc

Re: [PATCH 1/3] Staging: vt6655: remove boolean TRUE

2010-07-06 Thread Charles Clément
On Tue, Jul 06, 2010 at 08:18:27AM -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 06, 2010 at 04:45:41PM +0200, Charles Clément wrote: > > > > Signed-off-by: Charles Clément > > --- > > drivers/staging/vt6655/80211mgr.c|8 +- > > drivers/staging/vt6655/IEEE11h.c | 10 +- > > driver

Re: [PATCH 3/3] Staging: vt6655: remove typedef BOOL

2010-07-06 Thread Charles Clément
On Tue, Jul 06, 2010 at 05:13:34PM +0200, Jiri Slaby wrote: > On 07/06/2010 04:45 PM, Charles Clément wrote: > > Change variables to int type. > > Why not to use in-kernel bool, true and false if it ought to be boolean? I haven't seen the in-kernel bool types a lot, that's why I just wanted to co

Re: [PATCH] Staging: dt3155: fix coding style issues in dt3155_drv.c

2010-07-06 Thread Aldo Cedillo
> diff --git a/drivers/staging/dt3155/dt3155_drv.c > b/drivers/staging/dt3155/dt3155_drv.c > index 66db878..f6edd66 100644 > --- a/drivers/staging/dt3155/dt3155_drv.c > +++ b/drivers/staging/dt3155/dt3155_drv.c > @@ -308,33 +308,42 @@ static void dt3155_isr(int irq, void *dev_id, struct > pt_regs

Re: [PATCH] Staging: cx25821: fix brace coding style issue in cx25821-audio-upstream.c

2010-07-06 Thread Joe Eloff
On Tue, 2010-07-06 at 12:12 -0500, Aldo Cedillo wrote: > > Subject: [PATCH] Staging: cx25821: fix brace coding style issue in > > cx25821-audio-upstream.c > > This is a patch to the cx25821.c file that fixes up a brace warning found > > by the checkpatch.pl tool > > Signed-off-by: Joe Eloff >

[PATCH] Staging: comedi: Cleanup on dmm32at.c from checkpatch.pl

2010-07-06 Thread Mark
This patch cleans up some style issues in dmm32at.c as found by checkpatch.pl Signed-off-by: Mark Rankilor --- drivers/staging/comedi/drivers/dmm32at.c | 45 - 1 files changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/staging/comedi/drivers/dmm32at.c

[PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c

2010-07-06 Thread Joe Eloff
>From e23e19537c4d62bc76ae982859d3c3225a45d9c2 Mon Sep 17 00:00:00 2001 From: Joe Eloff Date: Tue, 6 Jul 2010 19:13:28 +0200 Subject: [PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c This is a patch to the et131x_initpci.c file that fixes up all the line lengths over 80 by the

Re: [PATCH] Staging: cx25821: fix brace coding style issue in cx25821-audio-upstream.c

2010-07-06 Thread Aldo Cedillo
> Subject: [PATCH] Staging: cx25821: fix brace coding style issue in > cx25821-audio-upstream.c >  This is a patch to the cx25821.c file that fixes up a brace warning found by > the checkpatch.pl tool >  Signed-off-by: Joe Eloff > > --- >  drivers/staging/cx25821/cx25821-audio-upstream.c |    4

Re: Volunteers needed to cleanup xgifb driver

2010-07-06 Thread Greg KH
On Tue, Jul 06, 2010 at 03:22:08PM +0200, Arnaud Patard wrote: > Greg, as the staging maintainer, do you have any objections against > patches sent to the list de...@driverdev.osuosl.org rather than a pull > request ? No, I prefer it :) Just be sure to also Cc: me so I don't loose the patches in

[PATCH] Staging: dt3155: fix coding style issues in dt3155_drv.c

2010-07-06 Thread Joe Eloff
I just realised how the commit chaining works after messing it up so I have already uploaded a 1/2 and 2/2 and now it made another 2/2 for this patch which is different. I have realised how it works now and wont mess it up again and have no idea how to reverse chain the 3 patches. This now fi

Re: [PATCH 1/3] Staging: vt6655: remove boolean TRUE

2010-07-06 Thread Greg KH
On Tue, Jul 06, 2010 at 04:45:41PM +0200, Charles Clément wrote: > > Signed-off-by: Charles Clément > --- > drivers/staging/vt6655/80211mgr.c|8 +- > drivers/staging/vt6655/IEEE11h.c | 10 +- > drivers/staging/vt6655/aes_ccmp.c|4 +- > drivers/staging/vt6655/baseband.c|

Re: [PATCH 3/3] Staging: vt6655: remove typedef BOOL

2010-07-06 Thread Jiri Slaby
On 07/06/2010 04:45 PM, Charles Clément wrote: > Change variables to int type. Why not to use in-kernel bool, true and false if it ought to be boolean? regards, -- js ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproje

Re: Volunteers needed to cleanup xgifb driver

2010-07-06 Thread Rtp
Martin Michlmayr writes: Hi, > Arnaud Patard recently submitted the xgifb driver for the XGI Z7, > Z9 and Z11 PCI chips to the staging tree but it needs a lot of work > before it can move out of staging. I'm looking for volunteers who > would like to work on this. That's great. I didn't expect

Re: [PATCH 2/2] Staging: dt3155: fix coding style issues in dt3155_drv.c

2010-07-06 Thread Jiri Slaby
On 07/06/2010 12:02 AM, Joe Eloff wrote: > --- a/drivers/staging/dt3155/dt3155_drv.c > +++ b/drivers/staging/dt3155/dt3155_drv.c > @@ -78,7 +78,7 @@ extern void printques(int); > MODULE_LICENSE("GPL"); > > /* Error variable. Zero means no error. */ > -int dt3155_errno = 0; > +int dt3155_errno

Re: Volunteers needed to cleanup xgifb driver

2010-07-06 Thread Charles Clément
On Mon, Jul 05, 2010 at 08:03:33PM +0100, Martin Michlmayr wrote: > Arnaud Patard recently submitted the xgifb driver for the XGI Z7, > Z9 and Z11 PCI chips to the staging tree but it needs a lot of work > before it can move out of staging. I'm looking for volunteers who > would like to work on th