[PATCH] staging: rt2860: rtmp: Fixed coding style issue in rtmp.h

2010-08-02 Thread tarinaky
From: Tarinaky This patch fixes a whitespace issue detected by checkpatch.pl Signed-off-by: Jacob Smith --- drivers/staging/rt2860/rtmp.h | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rt2860/rtmp.h b/drivers/staging/rt2860/rtmp.h inde

[PATCH] staging: vt6656: added spaces around '||'

2010-08-02 Thread Andres More
Cleared checkpatch ERROR: spaces required around that '||' Signed-off-by: Andres More --- drivers/staging/vt6656/dpc.c |4 ++-- drivers/staging/vt6656/iwctl.c |3 ++- drivers/staging/vt6656/rxtx.c |4 ++-- drivers/staging/vt6656/wmgr.c |8 +--- 4 files changed, 11 inserti

Re: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

2010-08-02 Thread Greg KH
On Mon, Aug 02, 2010 at 05:46:01PM +, Haiyang Zhang wrote: > From: Haiyang Zhang > > Subject: staging: hv: Fix missing functions for net_device_ops > Unlike in older kernels, ether_setup() no longer sets default Why put the subject in the body of the email? This forces me to edit it again

Re: [PATCH] Staging: wlan-ng: Update prism2_set_tx_power() to use mBm

2010-08-02 Thread Greg KH
On Mon, Aug 02, 2010 at 10:56:29PM +0200, Christoph Fritz wrote: > On Mon, 2010-08-02 at 21:53 +0200, Christoph Fritz wrote: > > Commit fa61cf70a6ae1089e459e4b59b2e8d8e90d8535e updates nl80211's function > > .set_tx_power to use mBm units instead of dBm for greater accuracy and > > smaller power le

Re: [PATCH] Staging: memrar: moved user code away from core code

2010-08-02 Thread Greg KH
On Wed, Jul 28, 2010 at 10:12:21PM -0700, Chris McIntosh wrote: > moved memrar_ioctl, rar_reserve, rar_release, rar_handle_to_bus to > memrar_user.c > > Signed-off-by: Chris McIntosh > --- > drivers/staging/memrar/memrar_handler.c | 207 - > drivers/staging/memrar/memrar_use

Re: [PATCH] Staging: dt3155: properly export the module parameter

2010-08-02 Thread Greg KH
On Thu, Jul 29, 2010 at 11:02:38AM -0500, H Hartley Sweeten wrote: > On Thursday, July 29, 2010 6:09 AM, Jiri Slaby wrote: > > On 07/29/2010 02:55 AM, H Hartley Sweeten wrote: > >> On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote: > >>> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote: > -

[PATCH] staging: vt6656: removed NTSTATUS definition

2010-08-02 Thread Andres More
Replaced NTSTATUS with int, as defined in a couple of places. Signed-off-by: Andres More --- drivers/staging/vt6656/baseband.c |6 ++-- drivers/staging/vt6656/control.c |2 +- drivers/staging/vt6656/device.h |1 - drivers/staging/vt6656/dpc.c |2 +- drivers/staging/vt6656

Re: [PATCH] staging: vt6656: simplified tests involving both multi/broad-casts

2010-08-02 Thread Andrés More
On Mon, Aug 2, 2010 at 8:11 PM, Joe Perches wrote: > Perhaps these are more readable as: >                if (is_multicast_ether_addr(psEthHeader->abyDstAddr)) { > > +    if > > (is_multicast_ether_addr(&(pPacket->p80211Header->sA3.abyAddr1[0]))) { True, thanks. -- Andres __

[PATCH] staging: vt6656: simplified tests involving both multi/broad-casts

2010-08-02 Thread Andres More
By definition the broadcast address is also a multicast address. Lindented the modified section as required by checkpatch.pl. Signed-off-by: Andres More --- drivers/staging/vt6656/rxtx.c | 31 +-- 1 files changed, 13 insertions(+), 18 deletions(-) diff --git a/driv

Re: [PATCH] staging: vt6656: simplified tests involving both multi/broad-casts

2010-08-02 Thread Joe Perches
On Mon, 2010-08-02 at 19:59 -0300, Andres More wrote: > + if (is_multicast_ether_addr(&(psEthHeader->abyDstAddr[0]))) { Perhaps these are more readable as: if (is_multicast_ether_addr(psEthHeader->abyDstAddr)) { > +if (is_multicast_ether_addr(&(pPacket->p80211Head

[PATCH] staging: vt6656: simplified tests involving both multi/broad-casts

2010-08-02 Thread Andres More
By definition the broadcast address is also a multicast address. Lindented the modified section as required by checkpatch.pl. Signed-off-by: Andres More --- drivers/staging/vt6656/rxtx.c | 27 --- 1 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/

Re: [PATCH] Staging: wlan-ng: Update prism2_set_tx_power() to use mBm

2010-08-02 Thread Christoph Fritz
On Mon, 2010-08-02 at 21:53 +0200, Christoph Fritz wrote: > Commit fa61cf70a6ae1089e459e4b59b2e8d8e90d8535e updates nl80211's function > .set_tx_power to use mBm units instead of dBm for greater accuracy and > smaller power levels. > > This patchs updates prism2_set_tx_power() accordingly. > > Si

[PATCH] Staging: wlan-ng: Update prism2_set_tx_power() to use mBm

2010-08-02 Thread Christoph Fritz
Commit fa61cf70a6ae1089e459e4b59b2e8d8e90d8535e updates nl80211's function .set_tx_power to use mBm units instead of dBm for greater accuracy and smaller power levels. This patchs updates prism2_set_tx_power() accordingly. Signed-off-by: Christoph Fritz --- drivers/staging/wlan-ng/cfg80211.c |

[PATCH 1/1] staging: hv: Fix missing functions for net_device_ops (resubmit)

2010-08-02 Thread Haiyang Zhang
From: Haiyang Zhang Subject: staging: hv: Fix missing functions for net_device_ops Unlike in older kernels, ether_setup() no longer sets default functions. We need to put them into net_device_ops. For example, eth_change_mtu prevents setting MTU beyond 1500. This is necessary because we don't s

RE: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops

2010-08-02 Thread Haiyang Zhang
> From: Greg KH [mailto:gre...@suse.de] > Sent: Monday, August 02, 2010 1:18 PM > > So what kernel versions are affected by this? > > Please don't attach a patch and put it inline, it forces me to edit it > by hand. > > Care to provide the above information and resend it so I can apply it? It af

Re: [PATCH 1/1] staging: hv: Fix missing functions for net_device_ops

2010-08-02 Thread Greg KH
On Mon, Aug 02, 2010 at 05:00:33PM +, Haiyang Zhang wrote: > From: Haiyang Zhang > > Subject: staging: hv: Fix missing functions for net_device_ops > Unlike in older kernels, ether_setup() no longer sets default > functions. So what kernel versions are affected by this? Please don't attac

[PATCH 1/1] staging: hv: Fix missing functions for net_device_ops

2010-08-02 Thread Haiyang Zhang
From: Haiyang Zhang Subject: staging: hv: Fix missing functions for net_device_ops Unlike in older kernels, ether_setup() no longer sets default functions. We need to put them into net_device_ops. For example, eth_change_mtu prevents setting MTU beyond 1500. This is necessary because we don't s

Re: [PATCH 1/9 v3] staging: dt3155: check put_user() return value

2010-08-02 Thread Simon Horman
On Mon, Aug 02, 2010 at 04:56:38PM +0400, Vasiliy Kulikov wrote: > put_user() returns code was not checked for errors. To simplify the code > fill local struct dt3155_read with data and copy it with single > copy_to_user() call. > > Signed-off-by: Kulikov Vasiliy Looks good to me. Reviewed-by:

[PATCH 1/9 v3] staging: dt3155: check put_user() return value

2010-08-02 Thread Vasiliy Kulikov
put_user() returns code was not checked for errors. To simplify the code fill local struct dt3155_read with data and copy it with single copy_to_user() call. Signed-off-by: Kulikov Vasiliy --- drivers/staging/dt3155/dt3155_drv.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions

Re: [PATCH 1/9 v2] staging: dt3155: check put_user() return value

2010-08-02 Thread Simon Horman
On Mon, Aug 02, 2010 at 12:31:12PM +0400, Kulikov Vasiliy wrote: > put_user() return code was not checked for errors. To simplify the code > fill local struct dt3155_read with data and copy it with single > copy_to_user() call. > > Signed-off-by: Kulikov Vasiliy > --- > drivers/staging/dt3155/dt

[PATCH 1/9 v2] staging: dt3155: check put_user() return value

2010-08-02 Thread Kulikov Vasiliy
put_user() return code was not checked for errors. To simplify the code fill local struct dt3155_read with data and copy it with single copy_to_user() call. Signed-off-by: Kulikov Vasiliy --- drivers/staging/dt3155/dt3155_drv.c | 17 - 1 files changed, 8 insertions(+), 9 deleti