Re: [PATCH 2/4] staging: xgifb: Add compilation conditionals

2010-09-04 Thread Greg KH
On Sat, Sep 04, 2010 at 07:07:48PM -0400, Javier Martinez Canillas wrote: > > Signed-off-by: Javier Martinez Canillas > --- > drivers/staging/xgifb/XGI_main.h|2 ++ > drivers/staging/xgifb/XGI_main_26.c |6 ++ > 2 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/d

Re: [PATCH 1/4] staging: xgifb: Fix compile warning

2010-09-04 Thread Greg KH
On Sat, Sep 04, 2010 at 07:06:47PM -0400, Javier Martinez Canillas wrote: > Hello, In today linux-next I got a some compile warnings with the > staging/xgifb driver. This is the first of a 4 patchset that fix all the > issues. > > The patches are: > > [PATCH 1/4] staging: xgifb: Fix compile war

Re: [PATCH] Staging: xgifb: fixed many style issues in XGI_accel.c

2010-09-04 Thread Greg KH
On Sat, Sep 04, 2010 at 03:40:45PM +0530, Prashant P. Shah wrote: > This is a patch to the XGI_accel.c file that fixes many style > issues found by the checkpatch.pl tool. > - extra spaces > - invalid code indent > - extra braces > - invalid comment style > > Signed-off-by: Prashant P. Shah Um,

[PATCH 06/13] drivers/staging/lirc: Remove unnecessary casts of private_data

2010-09-04 Thread Joe Perches
Signed-off-by: Joe Perches --- drivers/staging/lirc/lirc_imon.c |4 ++-- drivers/staging/lirc/lirc_zilog.c | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lirc/lirc_imon.c b/drivers/staging/lirc/lirc_imon.c index 818bec0..9949dfa 100644 --- a

[PATCH 00/13] trivial: Remove unnecessary casts of private_data

2010-09-04 Thread Joe Perches
Resend removal of remaining casts of private_data Joe Perches (13): drivers/gpu/drm: Remove unnecessary casts of private_data drivers/infiniband: Remove unnecessary casts of private_data drivers/net/wireless/iwlwifi: Remove unnecessary casts of private_data drivers/s390: Remove unnecessary

[PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues

2010-09-04 Thread Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas --- drivers/staging/xgifb/vb_setmode.c | 35 +-- 1 files changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index cf6874b..bcd3083 100644 --- a

[PATCH 3/4] staging: xgifb: Removes unused variable

2010-09-04 Thread Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas --- drivers/staging/xgifb/XGI_main_26.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 2cba4c4..4db5986 100644 --- a/drivers/staging/xgifb/XGI_main_2

[PATCH 2/4] staging: xgifb: Add compilation conditionals

2010-09-04 Thread Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas --- drivers/staging/xgifb/XGI_main.h|2 ++ drivers/staging/xgifb/XGI_main_26.c |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h index 72448e8..93837f3

[PATCH 1/4] staging: xgifb: Fix compile warning

2010-09-04 Thread Javier Martinez Canillas
Hello, In today linux-next I got a some compile warnings with the staging/xgifb driver. This is the first of a 4 patchset that fix all the issues. The patches are: [PATCH 1/4] staging: xgifb: Fix compile warning [PATCH 2/4] staging: xgifb: Add compilation conditionals [PATCH 3/4] staging: xgifb:

Transfer

2010-09-04 Thread Samuel
Dear Friend, Good day. I have some information for you about your unpaid fund, the people you are dealing with is not the original bank, why can't you deal with the bank instead of sending money to people to help you get your fund, I have their Direct Contact Information and I can direct

[PATCH 1/1] Staging: ath6kl, remove unneeded ptr checking

2010-09-04 Thread Jiri Slaby
In wmi_bssInfo_event_rx, there is unneeded check for bss, because it is in the branch where the bss is checked to be non-null already. Remove the superfluous check. Signed-off-by: Jiri Slaby Cc: Vipin Mehta Cc: Greg Kroah-Hartman --- drivers/staging/ath6kl/wmi/wmi.c |2 +- 1 files changed

[PATCH 1/1] Staging: lirc, fix NULL dereference

2010-09-04 Thread Jiri Slaby
When 'context' allocation fails in imon_probe, we jump to unlock context->ctx_lock. This is wrong as context is NULL and the lock is not locked. Fix the labels. Signed-off-by: Jiri Slaby Cc: Jarod Wilson Cc: Mauro Carvalho Chehab --- drivers/staging/lirc/lirc_imon.c |5 +++-- 1 files chan

[PATCH v2 1/1] Staging: lirc, fix lock imbalance

2010-09-04 Thread Jiri Slaby
[2nd version -- melded all three together] 1) There is a missing return or goto statement in one fail path in sasem_probe, so that the code contiues its normal execution (and unlocks a mutex twice). Fix that by jumping to the right place. Anyway the code is very broken on its fail paths and there

[PATCH 1/1] Staging: lirc, fix lock imbalance

2010-09-04 Thread Jiri Slaby
There is an omitted unlock in one fail path in vfd_write, jump to the right place to unlock the lock. Signed-off-by: Jiri Slaby Cc: Jarod Wilson Cc: Mauro Carvalho Chehab --- drivers/staging/lirc/lirc_sasem.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 1/1] Staging: lirc, fix double unlock

2010-09-04 Thread Jiri Slaby
There is a missing return or goto statement in ine fail path in sasem_probe, so that the code contiues its normal execution (and unlocks a mutex twice). Fix that by jumping to the right place. Anyway the code is very broken on its fail paths and there are many leaks. But that's a different story.