Re: [PATCH] staging: fix possible use-before-NULL-check crash

Hi Greg, On Wed, Oct 06, 2010 at 03:51:04PM -0700, Greg KH wrote: > Nice catch, but I don't think that the dev pointer can ever be NULL > here. Yeah, I didn't think so either, but figured it was best to fix it anyway. -Kees -- Kees Cook Ubuntu Security Team

Re: [PATCH] staging: fix possible use-before-NULL-check crash

On Wed, Oct 06, 2010 at 03:39:41PM -0700, Kees Cook wrote: > Found via http://coccinelle.lip6.fr/rules/mini_null_ref.cocci > > Signed-off-by: Kees Cook > --- > drivers/staging/tm6000/tm6000-alsa.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/tm

[PATCH] staging: fix possible use-before-NULL-check crash

Found via http://coccinelle.lip6.fr/rules/mini_null_ref.cocci Signed-off-by: Kees Cook --- drivers/staging/tm6000/tm6000-alsa.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/tm6000/tm6000-alsa.c b/drivers/staging/tm6000/tm6000-alsa.c index 087137d..c

RE: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging

Jiri, > -Original Message- > From: Jiri Slaby [mailto:jirisl...@gmail.com] > Sent: Wednesday, October 06, 2010 5:18 PM > To: Savoy, Pavan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@driverdev.osuosl.org; > a...@lxorguk.ukuu.org.uk > Subject: Re: [PATCH 1/2] drivers:staging

Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging

On 10/06/2010 10:08 PM, Savoy, Pavan wrote: >> On 10/06/2010 06:18 PM, pavan_sa...@ti.com wrote: >>> --- /dev/null >>> +++ b/drivers/misc/ti-st/st_core.c >>> @@ -0,0 +1,1031 @@ >> ... >>> +#define PROTO_ENTRY(type, name)name >>> +const unsigned char *protocol_strngs[] = { >>> + PROTO_ENTRY(ST

[PATCH 5/9] staging: brcm80211: remove kernel_thread() for _dhd_sysioc_thread.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c index e95e34d..3f7b6b7 100644 --- a/dri

[PATCH 8/9] staging: brcm80211: remove kernel_thread() for wl_iscan_thread.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c index ac09fd6..5ee2c86 100644 --- a/

[PATCH 6/9] staging: brcm80211: remove kernel_thread() for _iscan_sysioc_thread.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_iw.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/wl_iw.c b/drivers/staging/brcm80211/brcmfmac/wl_iw.c index c105b7f..ed1c596 100644 --- a/drivers/staging/b

[PATCH 7/9] staging: brcm80211: remove kernel_thread() for wl_iscan_thread.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c index 041568e..ac09fd6 100644 --- a

[PATCH 4/9] staging: brcm80211: remove kernel_thread() for dhd_dpc_thread.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c index 125ee43..e95e34d 100644 --- a/dri

[PATCH 1/9] staging: brcm80211: wl_cfg80211.c: fix 'assignment in if condition'

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 431 -- 1 files changed, 236 insertions(+), 195 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c index 0c5d5cf..0

[PATCH 3/9] staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c index 1441b33..125ee43 100644 --- a/

[PATCH 0/9] brcm80211: kernel_thread() removal and misc.

Greg, all, This series adds a patch I missed last go around (my fault, I started with the wrong commit :-( ), removes ';' after while() in macros as recommended by Joe, and then removes all of the calls to kernel_thread. Each patch compile tested, please sanity check, esp. the kernel_thread() fix

[PATCH 9/9] staging: brcm80211: remove kernel_thread() for wl_event_handler.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c index 5ee2c86..9a48dc8 100644 --- a

[PATCH 2/9] staging: brcm80211: remove ';' after while() in macros.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |2 +- drivers/staging/brcm80211/brcmfmac/wl_iw.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/

RE: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging

Jiri, > -Original Message- > From: Jiri Slaby [mailto:jirisl...@gmail.com] > Sent: Wednesday, October 06, 2010 2:47 PM > To: Savoy, Pavan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@driverdev.osuosl.org; > a...@lxorguk.ukuu.org.uk > Subject: Re: [PATCH 1/2] drivers:staging:

Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging

Hi, I have few comments below. On 10/06/2010 06:18 PM, pavan_sa...@ti.com wrote: > --- /dev/null > +++ b/drivers/misc/ti-st/st_core.c > @@ -0,0 +1,1031 @@ ... > +#define PROTO_ENTRY(type, name) name > +const unsigned char *protocol_strngs[] = { > + PROTO_ENTRY(ST_BT, "Bluetooth"), > +

[PATCH] staging: brcm80211: removed duplicated file, linux_osl.c

Removed duplicated file, linux_osl.c from brcmfmac. linux_osl.c under brcm80211/util/ will be shared between softmac & fullmac drivers Signed-off-by: Nohee Ko --- drivers/staging/brcm80211/brcmfmac/Makefile|2 +- drivers/staging/brcm80211/brcmfmac/linux_osl.c | 591

Re: [PATCH 5/5] staging: brcm80211: fix checkpatch macro errors.

Joe Perches wrote: On Wed, 2010-10-06 at 10:08 -0400, Jason Cooper wrote: Signed-off-by: Jason Cooper diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c index 42e2f29..3536011 100644 --- a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c

[PATCH] staging: brcm80211: bug fix - connection status report

Added connection status report for the case connection fails. Originally this logic was missing. Signed-off-by: Nohee Ko --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 44 ++ 1 files changed, 36 insertions(+), 8 deletions(-) diff --git a/drivers/staging/brcm80211/

[PATCH] staging: brcm80211: bug fix - connection status report

When brcmfmac fails to connect to AP, it reports failure status to cfg80211 plane. Originally this logic was missing. Signed-off-by: Nohee Ko --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 44 ++ 1 files changed, 36 insertions(+), 8 deletions(-) diff --git a/driver

Re: [PATCH 5/5] staging: brcm80211: fix checkpatch macro errors.

On Wed, 2010-10-06 at 10:08 -0400, Jason Cooper wrote: > Signed-off-by: Jason Cooper > diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c > b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c > index 42e2f29..3536011 100644 > --- a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c > +++ b/driv

RE: [PATCH 0/2] move TI_ST driver out of staging

> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Wednesday, October 06, 2010 10:29 AM > To: Savoy, Pavan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; a...@lxorguk.ukuu.org.uk; > de...@driverdev.osuosl.org > Subject: Re: [PATCH 0/2] move TI_ST driver out of stag

Re: [PATCH 0/2] move TI_ST driver out of staging

On Wed, Oct 06, 2010 at 12:18:13PM -0400, pavan_sa...@ti.com wrote: > From: Pavan Savoy > > Greg, > > As suggested, I've squashed the 4 patches into a set of 2 patches. > 1. moves the source files. > 2. moves/modifies the Kconfig and Makefiles. > > Please review. All applied, nice job. greg k

Re: [PATCH 0/5] staging: brcm80211: fix checkpatch errors.

On Wed, Oct 06, 2010 at 10:07:58AM -0400, Jason Cooper wrote: > Greg, all, > > This series removes all the 'low hanging fruit' checkpatch errors. The > following remain: > - errors intentionally left alone (per ml conversations) > - errors triggered by typedef use > - kernel_thr

[PATCH 2/2] drivers:misc: ti-st: Kconfig & Makefile for TI_ST

From: Pavan Savoy Add the Kconfig and the Makefile for the TI_ST driver. TI_ST driver is the line discipline driver for the Texas Instrument's WiLink chipsets. Also add the ti-st folder to list of drivers under drivers/misc. Signed-off-by: Pavan Savoy --- drivers/misc/Kconfig|1 +

[PATCH 0/2] move TI_ST driver out of staging

From: Pavan Savoy Greg, As suggested, I've squashed the 4 patches into a set of 2 patches. 1. moves the source files. 2. moves/modifies the Kconfig and Makefiles. Please review. Thanks & Regards, Pavan Savoy Pavan Savoy (2): drivers:staging:ti-st: move TI_ST from staging drivers:misc: ti-

Re: OOM panics with zram

On 10/6/2010 10:16 AM, Pekka Enberg wrote: > On 6.10.2010 17.03, Greg KH wrote: >> Oops, I need to update the MAINTAINERS file, the proper place for the >> staging tree is now in git, at >> >> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-next-2.6.git >> >> which feeds directly into

Re: OOM panics with zram

On 6.10.2010 17.03, Greg KH wrote: Oops, I need to update the MAINTAINERS file, the proper place for the staging tree is now in git, at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-next-2.6.git which feeds directly into the linux-next tree. Excellent! Nitin, can you develop a

Re: OOM panics with zram

On Wed, Oct 06, 2010 at 10:38:59AM +0300, Pekka Enberg wrote: > Hi, > > On Wed, Oct 6, 2010 at 7:30 AM, Nitin Gupta wrote: > > Deleting it from staging would not help much. Much more helpful would > > be to sync at least the mainline and linux-next version of the driver > > so it's easier to deve

Re: OOM panics with zram

On Wed, Oct 06, 2010 at 12:30:39AM -0400, Nitin Gupta wrote: > > So, should I delete the version in staging, or are you going to send > > patches to sync it up with your development version? > > > > Deleting it from staging would not help much. Much more helpful would > be to sync at least the ma

Re: What is the minimum quality needed for drivers to move out of staging?

On Wed, Oct 06, 2010 at 10:50:48AM +0530, PRASANNA KUMAR wrote: > When a driver will be moved from staging directory tree? What is the minimum > criteria for a driver to be moved to main line tree? Is there any set of > tests > that a driver should pass to be moved from staging? How will you d

[PATCH 5/5] staging: brcm80211: fix checkpatch macro errors.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/bcmutils.c |2 +- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |9 ++--- drivers/staging/brcm80211/brcmfmac/wl_iw.c |9 ++--- drivers/staging/brcm80211/brcmfmac/wl_iw.h |2 +- 4 files changed, 1

[PATCH 3/5] staging: brcm80211: fix 'do not init statics to 0 or NULL'

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c |2 +- .../brcm80211/brcmfmac/bcmsdh_sdmmc_linux.c|2 +- drivers/staging/brcm80211/brcmfmac/dhd_common.c|2 +- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |6 +++--- drivers/stag

[PATCH 4/5] staging: brcm80211: fix various checkpatch spacing errors.

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c |3 ++- .../staging/brcm80211/brcmfmac/dhd_custom_gpio.c |2 +- drivers/staging/brcm80211/brcmfmac/dhd_sdio.c |4 ++-- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |2 +- 4 files chang

[PATCH 2/5] staging: brcm80211: fix 'do not init globals to 0 or NULL'

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/bcmsdh.c |2 +- drivers/staging/brcm80211/brcmfmac/dhd_common.c |2 +- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 10 +- drivers/staging/brcm80211/brcmfmac/linux_osl.c |2 +- drivers/staging/brcm

[PATCH 1/5] staging: brcm80211: brcmfmac/*: fix remaining 'assignment in if condition'

Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c | 46 - drivers/staging/brcm80211/brcmfmac/dhd_common.c | 45 ++-- drivers/staging/brcm80211/brcmfmac/linux_osl.c| 15 --- 3 files changed, 58 insertions(+), 48 d

[PATCH 0/5] staging: brcm80211: fix checkpatch errors.

Greg, all, This series removes all the 'low hanging fruit' checkpatch errors. The following remain: - errors intentionally left alone (per ml conversations) - errors triggered by typedef use - kernel_thread() use I plan on hitting the kernel_thread()'s next, then I'll mov

Re: OOM panics with zram

Hi, On Wed, Oct 6, 2010 at 7:30 AM, Nitin Gupta wrote: > Deleting it from staging would not help much. Much more helpful would > be to sync at least the mainline and linux-next version of the driver > so it's easier to develop against these kernel trees.  Initially, I > thought -staging means tha