[PATCH] staging:brcm80211:bug fix- dual band problem

Bug fix for dual band problem. In particular it had an issue to connect to 5G band AP. Signed-off-by: Nohee Ko --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 108 ++ 1 files changed, 89 insertions(+), 19 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/

[PATCH] staging: brcm80211: Purge unused packet engine

We're not using the packet engine anymore - goodbye. Signed-off-by: Brett Rudley --- drivers/staging/brcm80211/include/wlioctl.h | 10 drivers/staging/brcm80211/phy/wlc_phy_cmn.c |2 +- drivers/staging/brcm80211/phy/wlc_phy_int.h |1 - drivers/staging/brcm80211/phy/wlc_phy_lc

RE: What is the minimum quality needed for drivers to move out of staging?

Hi Prasanna, > > I came across some tools that other operating systems provide for > > checking the quality. My idea is that if we have a automated tool that > > could test the driver it will be easy for the developer, maintainer > > and also for the user. The automated test scripts could do check

[PATCH v2]: staging: brcm80211: Purge unused wlc_info tracing

Fixed subject line. Purge unused wlc_info_dbg Signed-off-by: Brett Rudley --- drivers/staging/brcm80211/sys/wlc_mac80211.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c

[PATCH: staging: brcm80211: Purge unused wlc_info tracing

Purge unused wlc_info_dbg Signed-off-by: Brett Rudley --- drivers/staging/brcm80211/sys/wlc_mac80211.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c index 857dd06..4694

[PATCH] staging: brcm80211: Purge unused wlc_id_name

Purge unused wlc_id_name_entry Signed-off-by: Brett Rudley --- drivers/staging/brcm80211/sys/wlc_mac80211.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c index a5f7b9c..

RE: [PATCH] staging: brcm80211: bug fix - connection status report

>>> May I ask why? In general, runtime debug level setting is considered superior to compile-time; see iwlwifi. <<< Thanks for your advice. I will revert this in next patch. Thanks Nohee -Original Message- From: Gábor Stefanik [mailto:netrolller...@gmail.com] Sent: Friday, October 08, 2

[PATCH 6/6] staging: brcm80211: remove BLOCKABLE so no one uses it.

BLOCKABLE() doesn't do what it's supposed to. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c

[PATCH 4/6] staging: brcm80211: remove kernel_thread() for _iscan_sysioc_thread.

Replace kernel_thread() with kthread_run, kthread_stop() and kthread_should_stop(). Remove sysioc_pid, sysioc_exit, and DAEMONIZE. sysioc_tsk is NULL when not in use, -ENOMEM in error, otherwise in use. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_iw.c | 44 +

[PATCH 5/6] staging: brcm80211: remove kernel_thread() for wl_iscan_thread and wl_event_thread.

Replace kernel_thread() with kthread_run(). Replace pid with tsk, and exited with kthread_stop()/kthread_should_stop(). event_tsk, and tsk are NULL when not in use, -ENOMEM on error, otherwise, in use. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 42

[PATCH 1/6] staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.

Replaced kernel_thread() with kthread_run(). Used kthread_should_stop() in place of watchdog_exited completion. Replaced watchdog_pid with struct task_struct. watchdog_tsk is NULL when not in use, -ENOMEM for error, otherwise, in use. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/

[PATCH 3/6] staging: brcm80211: remove kernel_thread() for _dhd_sysioc_thread.

Replaced kernel_thread() with kthread_run(), kthread_stop(), and kthread_should_stop(). Also removed all references to sysioc_pid and sysioc_exit. DAEMONIZE removed because not used in dhd_linux.c. sysioc_tsk is NULL when not is use, -ENOMEM on error, and otherwise in use. Signed-off-by: Jason

[PATCH 0/6 v3] brcm80211: kernel_thread() removal.

Greg, all, This series removes all of the calls to kernel_thread(). At the recommendation of Jiri, also removed all reference to pid, KILL_PROC, DAEMONIZE, completion, and various completion structs. The third version correctly handles the return value of kthread_run(). So, all task_struct's be

[PATCH 2/6] staging: brcm80211: remove kernel_thread() for dhd_dpc_thread.

use kthread_run(), kthread_stop(), and kthread_should_stop(). Removes dpc_pid, dpc_exited, and the call to DAEMONIZE. dpc_tsk is NULL when not in use, -ENOMEM when fail, otherwise ok. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 31 +--

[PATCH 3/3 v2] staging: brcm80211: Coalesce osl_dma_alloc_consistent between fullmac and softmac

Combine dma_alloc routine for full and softmac Signed-off-by: Brett Rudley --- drivers/staging/brcm80211/include/linux_osl.h | 17 - drivers/staging/brcm80211/util/linux_osl.c| 20 ++-- 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/dri

[PATCH 2/3 v2] staging: brcm80211: Purge unused memlist debugging

Purge unused memlist debugging Signed-off-by: Brett Rudley --- drivers/staging/brcm80211/util/linux_osl.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/staging/brcm80211/util/linux_osl.c b/drivers/staging/brcm80211/util/linux_osl.c index b0fb370..9d86

Re: [PATCH] staging: brcm80211: bug fix - connection status report

On Wed, Oct 6, 2010 at 7:59 PM, nohee ko wrote: > When brcmfmac fails to connect to AP, it reports failure status to > cfg80211 plane. Originally this logic was missing. > > Signed-off-by: Nohee Ko > --- >  drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |   44 > ++ >  1 fil

[PATCH 5/5] staging: brcm80211: remove kernel_thread() for wl_iscan_thread and wl_event_thread.

Replace kernel_thread() with kthread_run(). Replace pid with tsk, and exited with kthread_stop()/kthread_should_stop(). Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 38 ++ drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h |6 +-- 2

[PATCH 2/5] staging: brcm80211: remove kernel_thread() for dhd_dpc_thread.

use kthread_run(), kthread_stop(), and kthread_should_stop(). Removes dpc_pid, dpc_exited, and the call to DAEMONIZE. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 27 ++- 1 files changed, 12 insertions(+), 15 deletions(-) diff --git a/d

[PATCH 4/5] staging: brcm80211: remove kernel_thread() for _iscan_sysioc_thread.

Replace kernel_thread() with kthread_run, kthread_stop() and kthread_should_stop(). Remove sysioc_pid, sysioc_exit, and DAEMONIZE. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_iw.c | 40 +++ 1 files changed, 16 insertions(+), 24 deletions(-) d

[PATCH 1/5] staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.

Replaced kernel_thread() with kthread_run(). Used kthread_should_stop() in place of watchdog_exited completion. Replaced watchdog_pid with struct task_struct. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 26 1 files changed, 13 ins

[PATCH 0/5 v2] brcm80211: kernel_thread() removal.

Greg, all, This series removes all of the calls to kernel_thread(). At the recommendation of Jiri, also removed all reference to pid, KILL_PROC, DAEMONIZE, completion, and various completion structs. Each patch compile tested, please sanity check... thx, Jason. Jason Cooper (5): staging:

[PATCH 3/5] staging: brcm80211: remove kernel_thread() for _dhd_sysioc_thread.

Replaced kernel_thread() with kthread_run(), kthread_stop(), and kthread_should_stop(). Also removed all references to sysioc_pid and sysioc_exit. DAEMONIZE removed because not used in dhd_linux.c. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 38 +-

Re: What is the minimum quality needed for drivers to move out of staging?

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Oct 08, 2010 at 08:22:16PM +0530, PRASANNA KUMAR wrote: > Hi Greg, > > I have not had much experience in driver programming (i am new to driver > programming world) in any of the operating sy

Re: [PATCH 0/9] brcm80211: kernel_thread() removal and misc.

On Fri, Oct 08, 2010 at 09:04:33AM +0200, Jiri Slaby wrote: > On 10/07/2010 09:26 PM, Brett Rudley wrote: > > Sure, we'll try to get these tested ASAP. > > You don't need to. They are buggy, as I wrote earlier: > http://www.spinics.net/lists/linux-driver-devel/msg08213.html > and > http://www.spin

Re: What is the minimum quality needed for drivers to move out of staging?

On Fri, Oct 08, 2010 at 11:14:24AM +0530, PRASANNA KUMAR wrote: > Hi Greg, > > I am not having any questions about specific driver. Microsoft is having a > set > of test cases for drivers which each driver must pass. If we could have some > test cases to ensure the quality of the driver (for ea

[patch v2] Staging: bcm: silence off by one warning

"status" is used as an index into the Adapter->PackInfo[] array, which has NO_OF_QUEUES elements. This code actually works OK. The SearchSfid() function always returns a valid index or it returns NO_OF_QUEUES + 1. But it looks sloppy and it makes the static checkers complain. Signed-off-by: Dan

[patch] Staging: bcm: silence off by one warning

"status" is used as an index into the Adapter->PackInfo[] array, which has NO_OF_QUEUES elements. This code actually works OK. The SearchSfid() function always returns a valid index or it returns NO_OF_QUEUES + 1. But it looks sloppy and it makes the static checkers complain. Signed-off-by: Dan

[patch] Staging: bcm: remove unneeded NULL check

The error handling here is wrong. If psIntfAdapter were NULL then we would have a NULL dereference in the debug output on the error path. But this function is only called from usbbcm_device_probe() when psIntfAdapter is non-NULL. Since the check isn't needed and I removed it instead of fixing it.

[patch] Staging: bcm: return -EFAULT on copy_to_user() errors

bcm/InterfaceDld.c had a couple places which returned the number of bytes remaining instead of -EFAULT. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/bcm/InterfaceDld.c b/drivers/staging/bcm/InterfaceDld.c index 8825b8e..60c0f29 100644 --- a/drivers/staging/bcm/InterfaceDld.c +++ b/

[patch] Staging: bcm: dereferencing before checking

I moved the check to see if "Adapter" was null in front of the dereference. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 37187c4..46f3a7d 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c @@ -1943,15 +1943,

[patch] Staging: bcm: mocro expansion bug

The WIMAX_MAX_MTU macro is used in drivers/staging/bcm/CmHost.c like this: if (Adapter->PackInfo[uiSearchRuleIndex].uiMaxBucketSize < WIMAX_MAX_MTU * 8) The multiplication by eight has precedence over the addition so the macro needs parenthesis to work. Signed-off-by: Dan Carpenter diff -

[patch] Staging: bcm: make major and minor signed

We assume that major is signed in register_control_device_interface(). Signed-off-by: Dan Carpenter diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h index 742ddeb..748460e 100644 --- a/drivers/staging/bcm/Adapter.h +++ b/drivers/staging/bcm/Adapter.h @@ -484,8 +484,8 @

[patch] Staging: bcm: return -EFAULT on copy_to_user() failures

There were a number of places in the bcm_char_ioctl() which returned the number of bytes remaining to be copied instead of returning -EFAULT. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 38d21eb..77fdfe2 100644 --- a/drivers/stagin

Re: [PATCH 0/9] brcm80211: kernel_thread() removal and misc.

On 10/08/2010 03:04 AM, Jiri Slaby wrote: > On 10/07/2010 09:26 PM, Brett Rudley wrote: >> Sure, we'll try to get these tested ASAP. > > You don't need to. They are buggy, as I wrote earlier: > http://www.spinics.net/lists/linux-driver-devel/msg08213.html > and > http://www.spinics.net/lists/linux

[bug report] batman: potential null dereference in send_packet()

There was a dereference before check issue introduced in 6a0e9fa88df9: "Staging: batman-adv: attach each hard-interface to a soft-interface" 160 static void send_packet(struct forw_packet *forw_packet) 161 { 162 struct batman_if *batman_if; 163 struct net_device *so

Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging

Hi Alan, > > ldisc is the ONLY way to do it, isn't it? Do I have any other option? > > Userspace but even then it wouldn't solve your problem > > > The situation was something similar here. > > What I was trying to get to is how we can have a per-device context if a > > driver is just a line di

Re: [PATCH 0/9] brcm80211: kernel_thread() removal and misc.

On 10/07/2010 09:26 PM, Brett Rudley wrote: > Sure, we'll try to get these tested ASAP. You don't need to. They are buggy, as I wrote earlier: http://www.spinics.net/lists/linux-driver-devel/msg08213.html and http://www.spinics.net/lists/linux-driver-devel/msg08214.html regards, -- js __

Re: [PATCH 2/3] staging: brcm80211: Purge unused memlist debug code

On Thu, Oct 07, 2010 at 08:31:47PM -0700, Brett Rudley wrote: > This memlist code is not used > > Signed-off-by: Brett Rudley This patch doesn't apply, care to refresh it and the 3/3 patch as well? I applied the 1/3 one. thanks, greg k-h ___ devel m