Re: [PATCH 0/6 v4] staging: brcm80211: remove kernel_thread()

2010-10-09 Thread Greg KH
On Sat, Oct 09, 2010 at 02:51:09PM -0400, Jason Cooper wrote: > Fourth cut. Applied all of Jiri's recommendations. At first glance, this looks good. Henry, can you test these out to verify they still work properly? Note, I'm going to be travelling next week to New York^WNewark, so my response t

[PATCH 2/6] staging: brcm80211: remove kernel_thread() for dhd_dpc_thread.

2010-10-09 Thread Jason Cooper
use kthread_run(), kthread_stop(), and kthread_should_stop(). Removes dpc_pid, dpc_exited, and the call to DAEMONIZE. dpc_tsk is NULL when not running. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 31 +-- 1 files changed, 17 insertions(

[PATCH 5/6] staging: brcm80211: remove kernel_thread() for wl_iscan_thread and wl_event_thread.

2010-10-09 Thread Jason Cooper
Replace kernel_thread() with kthread_run(). Replace pid with tsk, and exited with kthread_stop()/kthread_should_stop(). event_tsk, and tsk are NULL when their respective threads are not running. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 42 +++

[PATCH 6/6] staging: brcm80211: remove BLOCKABLE so no one uses it.

2010-10-09 Thread Jason Cooper
BLOCKABLE() doesn't do what it's supposed to. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c

[PATCH 4/6] staging: brcm80211: remove kernel_thread() for _iscan_sysioc_thread.

2010-10-09 Thread Jason Cooper
Replace kernel_thread() with kthread_run, kthread_stop() and kthread_should_stop(). Remove sysioc_pid, sysioc_exit, and DAEMONIZE. sysioc_tsk is NULL when not running. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/wl_iw.c | 43 +--- 1 files change

[PATCH 3/6] staging: brcm80211: remove kernel_thread() for _dhd_sysioc_thread.

2010-10-09 Thread Jason Cooper
Replaced kernel_thread() with kthread_run(), kthread_stop(), and kthread_should_stop(). Also removed all references to sysioc_pid and sysioc_exit. DAEMONIZE removed because not used in dhd_linux.c. sysioc_tsk is NULL when not running. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/

[PATCH 1/6] staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.

2010-10-09 Thread Jason Cooper
Replaced kernel_thread() with kthread_run(). Used kthread_should_stop() in place of watchdog_exited completion. Replaced watchdog_pid with struct task_struct. watchdog_tsk is NULL when the task is not running. Signed-off-by: Jason Cooper --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c |

[PATCH 0/6 v4] staging: brcm80211: remove kernel_thread()

2010-10-09 Thread Jason Cooper
Fourth cut. Applied all of Jiri's recommendations. thx, Jason. Jason Cooper (6): staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread. staging: brcm80211: remove kernel_thread() for dhd_dpc_thread. staging: brcm80211: remove kernel_thread() for _dhd_sysioc_thread. staging:

[PATCH 4/4] staging:brcm80211:remove unnecessary cflag, LINUX

2010-10-09 Thread nohee ko
remove unnecessary cflag, LINUX Signed-off-by: Nohee Ko --- drivers/staging/brcm80211/brcmfmac/Makefile |1 - drivers/staging/brcm80211/brcmfmac/dhd.h|9 - 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/staging/brcm80211/brcmfmac/Makefile b/drivers/

[PATCH 3/4] staging:brcm80211:remove unnecessary cflag, CONFIG_CFG80211

2010-10-09 Thread nohee ko
remove unnecessary cflag, CONFIG_CFG80211 Signed-off-by: Nohee Ko --- drivers/staging/brcm80211/brcmfmac/Makefile|1 - .../brcm80211/brcmfmac/bcmsdh_sdmmc_linux.c|4 -- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 32 +--- 3 files changed, 1 ins

[PATCH 2/4] staging:brcm80211:remove unnecessary cflag, BCMWPA2

2010-10-09 Thread nohee ko
remove unnecessary cflag, BCMWPA2. BCMDRIVER is already not used. Signed-off-by: Nohee Ko --- drivers/staging/brcm80211/brcmfmac/Makefile |2 -- drivers/staging/brcm80211/brcmfmac/wl_iw.c | 22 -- 2 files changed, 0 insertions(+), 24 deletions(-) diff --git a/drivers

Re: [PATCH 1/6] staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.

2010-10-09 Thread Jason
On 10/09/2010 07:09 AM, Jiri Slaby wrote: > On 10/08/2010 11:44 PM, Jason Cooper wrote: >> Replaced kernel_thread() with kthread_run(). Used kthread_should_stop() >> in place of watchdog_exited completion. Replaced watchdog_pid with >> struct task_struct. >> >> watchdog_tsk is NULL when not in us

[patch] Staging: brcm80211: make interface name buffer smaller

2010-10-09 Thread Dan Carpenter
In the original code the interface name was IFNAMSIZ + 1, but that caused problems in dhd_ifname2idx() which does: strncmp(dhd->iflist[i]->name, name, IFNAMSIZ) The wl_event_msg_t struct can only store 16 character names as well. And thirdly there is a potential buffer overflow in dhd_op_

Re: [PATCH 1/6] staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.

2010-10-09 Thread Jiri Slaby
On 10/08/2010 11:44 PM, Jason Cooper wrote: > Replaced kernel_thread() with kthread_run(). Used kthread_should_stop() > in place of watchdog_exited completion. Replaced watchdog_pid with > struct task_struct. > > watchdog_tsk is NULL when not in use, -ENOMEM for error, otherwise, in use. > > Si

Re: [PATCH v2]: staging: brcm80211: Purge unused wlc_info tracing

2010-10-09 Thread Greg KH
On Fri, Oct 08, 2010 at 04:05:10PM -0700, Brett Rudley wrote: > Fixed subject line. > Purge unused wlc_info_dbg > > Signed-off-by: Brett Rudley This was already sent in by Henry. thanks, greg k-h ___ devel mailing list devel@linuxdriverproject.org ht