Re: [PATCH 2/3] staging: ft1000: Remove unused char dev inerface.

2010-11-13 Thread Belisko Marek
Hi Greg, On Thu, Nov 11, 2010 at 1:26 AM, Greg KH wrote: > On Wed, Nov 10, 2010 at 11:15:27AM +0100, Marek Belisko wrote: >> This patch remove lot of code for character device. This >> interface was used for getting network informations and >> statistics which is currently exported via /proc file

[PATCH 2/2] staging: comedi: fix memory leak

2010-11-13 Thread Nicolas Kaiser
Instead of freeing outBuffer, inBuffer gets freed twice. Signed-off-by: Nicolas Kaiser --- Only compile tested. I hope I got it right? drivers/staging/comedi/drivers/usbdux.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbdux.c b/d

[PATCH 1/2] staging: comedi: fix typo in error message

2010-11-13 Thread Nicolas Kaiser
Fix typo in error message of dux commands allocation. Signed-off-by: Nicolas Kaiser --- drivers/staging/comedi/drivers/usbdux.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c index 1f177

[PATCH -next] staging: fix iio/gyro typos, build errors

2010-11-13 Thread Randy Dunlap
From: Randy Dunlap Typo causes build errors. Did anyone even build this driver? Signed-off-by: Randy Dunlap --- drivers/staging/iio/gyro/adis16251.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) Also has section mismatch warnings: WARNING: drivers/staging/built-in

[patch] Staging: iio/dds: double locking bugs

2010-11-13 Thread Dan Carpenter
This is a static checker patch and I don't have this hardware. This code is unusual because while I've often seen a double lock, this is the first time I've seen code that takes a lock 11 times in a row. I feel like I must have missed something. But I've looked very carefully I don't see any way

[patch] Staging: intel_sst: fix memory leak

2010-11-13 Thread Dan Carpenter
The original code set "str_info->decode_ibuf" to NULL so the kfree() is no-op. Signed-off-by: Dan Carpenter --- This is a static checker thing. I don't have the hardware to test this myself so please check it carefully. diff --git a/drivers/staging/intel_sst/intel_sst_stream_encoded.c b/driver

[patch] Staging: cptm1217: move free under dereference

2010-11-13 Thread Dan Carpenter
We dereference "ts" in the printk so move the kfree() down a line. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/cptm1217/clearpad_tm1217.c b/drivers/staging/cptm1217/clearpad_tm1217.c index 269503f..76e4b78 100644 --- a/drivers/staging/cptm1217/clearpad_tm1217.c +++ b/drivers/stagi

[patch] Staging: bcm: signedness bug in InitCardAndDownloadFirmware()

2010-11-13 Thread Dan Carpenter
status is used to store negative error codes throughout. The only place where this is a runtime bug is if create_worker_threads() fails. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c index 1bb6a1d..440b9cd 100644 --- a/drivers/staging/bcm/Mis