On Wed, Jan 26, 2011 at 08:09:47PM +, Haiyang Zhang wrote:
> >
> >
> > These don't line up with the others.
>
> I have corrected and resubmitted them.
>
You could have just resubmitted the one. Overall the patchset makes
things way better than before. I didn't want to make more work for
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |2 +-
drivers/staging/hv/channel.c | 56 +++---
drivers/staging/hv/channel_mgmt.c|2 +-
drivers/staging/hv/hv_kvp.c |4 +-
drivers/staging
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c | 22 +-
drivers/staging/hv/channel_mgmt.c | 16
drivers/staging/hv/connection.c| 74 ++--
drivers/staging/hv/vmbus_drv.c |2 +-
dri
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c |4 ++--
drivers/staging/hv/channel_mgmt.c| 20 ++--
drivers/staging/hv/vmbus_channel_interface.h | 26 +-
3 files changed, 25 ins
> From: Dan Carpenter [mailto:erro...@gmail.com]
> > + VM_PKT_INVALID = 0x0,
> > + VM_PKT_SYNCH= 0x1,
> > + VM_PKT_ADD_XFER_PAGESET = 0x2,
> > + VM_PKT_RM_XFER_PAGESET = 0x3,
> ^^
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc.c | 20 ++--
drivers/staging/hv/blkvsc_drv.c | 56 ++--
drivers/staging/hv/channel.c | 20 ++--
drivers/staging/hv/channel_mgmt.c |2 +-
drivers/staging/hv/netvsc.c | 58
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/vmbus_drv.c | 50
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index b33f497..99686f0 100
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c | 48 ++--
drivers/staging/hv/channel_mgmt.c | 48 ++--
drivers/staging/hv/connection.c| 154 ++--
drivers/staging/hv/vmbus_drv.c |2 +
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel_mgmt.c |4 ++--
drivers/staging/hv/vmbus_drv.c | 22 +++---
drivers/staging/hv/vmbus_private.h |6 +++---
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/driver
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c | 12 +-
drivers/staging/hv/channel_mgmt.c |4 +-
drivers/staging/hv/connection.c| 39 +++
drivers/staging/hv/vmbus_drv.c |6 ++--
drivers/
* Pekka Enberg (penb...@cs.helsinki.fi) wrote:
> On Wed, Jan 26, 2011 at 7:23 PM, Robert Jennings>
> wrote:
>> Calculate the first- and second-level indices for new page when the pool
>> is initialized rather than calculating them on each insertion.
>>
>> Signed-off-by: Robert Jennings
>> ---
>
On Wed, Jan 26, 2011 at 9:09 PM, Robert Jennings
wrote:
> Pekka Enberg wrote:
>> On Wed, Jan 26, 2011 at 7:23 PM, Robert Jennings
>> wrote:
>>> On a 64K page kernel, the value PAGE_SIZE passed to
>>> blk_queue_logical_block_size would overflow the logical block size
>>> argument (resulting in
Pekka Enberg wrote:
> On Wed, Jan 26, 2011 at 7:23 PM, Robert Jennings
> wrote:
>> On a 64K page kernel, the value PAGE_SIZE passed to
>> blk_queue_logical_block_size would overflow the logical block size
>> argument (resulting in setting it to 0).
>>
>> Take the minimum of PAGE_SIZE or 4096 an
On Wed, Jan 26, 2011 at 8:40 PM, Robert Jennings
wrote:
> * Pekka Enberg (penb...@kernel.org) wrote:
>> On Wed, Jan 26, 2011 at 7:25 PM, Robert Jennings
>> wrote:
>> > There is no need to set the bits in the first- and second-level indices
>> > to indicate a free page when we know that a free p
* Pekka Enberg wrote:
> On Wed, Jan 26, 2011 at 7:22 PM, Robert Jennings>
> wrote:
>> xvmalloc will not currently function with 64K pages. Newly allocated
>> pages will be inserted at an offset beyond the end of the first-level
>> index. This tuning is needed to properly size the allocator for
On 01/26/2011 12:25 PM, Robert Jennings wrote:
There is no need to set the bits in the first- and second-level indices
to indicate a free page when we know that a free page existed at this
level.
Signed-off-by: Robert Jennings
Reviewed-by: Nitin Gupta
Thanks for all the fixes and cleanups.
* Pekka Enberg (penb...@kernel.org) wrote:
> On Wed, Jan 26, 2011 at 7:25 PM, Robert Jennings
> wrote:
> > There is no need to set the bits in the first- and second-level indices
> > to indicate a free page when we know that a free page existed at this
> > level.
> >
> > Signed-off-by: Robert Jen
* Pekka Enberg (penb...@kernel.org) wrote:
> On Wed, Jan 26, 2011 at 7:26 PM, Robert Jennings
> wrote:
> > This wraps the code, noted by comments as being debug code, with
> > #ifdef DEBUG so that it is removed from running in non-debug kernels.
> >
> > Signed-off-by: Robert Jennings
> > ---
> >
* Robert Jennings (r...@linux.vnet.ibm.com) wrote:
> * Dan Carpenter (erro...@gmail.com) wrote:
> > On Wed, Jan 26, 2011 at 11:27:44AM -0600, Robert Jennings wrote:
> > > Adding QUEUE_FLAG_NONROT for the in the request_queue flags. When used
> >^^
> > "to th
On Wed, Jan 26, 2011 at 09:50:05AM -0800, Haiyang Zhang wrote:
> + VM_PKT_INVALID = 0x0,
> + VM_PKT_SYNCH= 0x1,
> + VM_PKT_ADD_XFER_PAGESET = 0x2,
> + VM_PKT_RM_XFER_PAGESET = 0x3,
On Wed, Jan 26, 2011 at 7:25 PM, Robert Jennings
wrote:
> There is no need to set the bits in the first- and second-level indices
> to indicate a free page when we know that a free page existed at this
> level.
>
> Signed-off-by: Robert Jennings
Why is it not necessary? I don't know that part o
On Wed, Jan 26, 2011 at 7:23 PM, Robert Jennings
wrote:
> Calculate the first- and second-level indices for new page when the pool
> is initialized rather than calculating them on each insertion.
>
> Signed-off-by: Robert Jennings
> ---
> drivers/staging/zram/xvmalloc.c | 13 +++--
* Dan Carpenter (erro...@gmail.com) wrote:
> On Wed, Jan 26, 2011 at 11:27:44AM -0600, Robert Jennings wrote:
> > Adding QUEUE_FLAG_NONROT for the in the request_queue flags. When used
>^^
> "to the" perhaps?
Yeah, that was edited a few times and never re-r
On Wed, Jan 26, 2011 at 11:27:44AM -0600, Robert Jennings wrote:
> Adding QUEUE_FLAG_NONROT for the in the request_queue flags. When used
^^
"to the" perhaps?
> as a swap device, scan_swap_map will avoid the extra work of optimizing
> for rotating media.
>
On Wed, Jan 26, 2011 at 7:22 PM, Robert Jennings
wrote:
> xvmalloc will not currently function with 64K pages. Newly allocated
> pages will be inserted at an offset beyond the end of the first-level
> index. This tuning is needed to properly size the allocator for 64K
> pages.
>
> The default 3
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc.c | 20 ++--
drivers/staging/hv/blkvsc_drv.c | 56 ++--
drivers/staging/hv/channel.c | 20 ++--
drivers/staging/hv/channel_mgmt.c |2 +-
drivers/staging/hv/netvsc.c | 58
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel_mgmt.c |4 ++--
drivers/staging/hv/vmbus_drv.c | 22 +++---
drivers/staging/hv/vmbus_private.h |6 +++---
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/driver
On Wed, Jan 26, 2011 at 7:27 PM, Robert Jennings
wrote:
> Adding QUEUE_FLAG_NONROT for the in the request_queue flags. When used
> as a swap device, scan_swap_map will avoid the extra work of optimizing
> for rotating media.
>
> Signed-off-by: Robert Jennings
Reviewed-by: Pekka Enberg
___
On Wed, Jan 26, 2011 at 7:26 PM, Robert Jennings
wrote:
> This wraps the code, noted by comments as being debug code, with
> #ifdef DEBUG so that it is removed from running in non-debug kernels.
>
> Signed-off-by: Robert Jennings
> ---
> drivers/staging/zram/xvmalloc.c | 4 +++-
> 1 files ch
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c |4 ++--
drivers/staging/hv/channel_mgmt.c| 20 ++--
drivers/staging/hv/vmbus_channel_interface.h | 26 +-
3 files changed, 25 ins
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |2 +-
drivers/staging/hv/channel.c | 56 +++---
drivers/staging/hv/channel_mgmt.c|2 +-
drivers/staging/hv/hv_kvp.c |4 +-
drivers/staging
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c | 22 +-
drivers/staging/hv/channel_mgmt.c | 16
drivers/staging/hv/connection.c| 74 ++--
drivers/staging/hv/vmbus_drv.c |2 +-
dri
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c | 48 ++--
drivers/staging/hv/channel_mgmt.c | 48 ++--
drivers/staging/hv/connection.c| 154 ++--
drivers/staging/hv/vmbus_drv.c |2 +
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/channel.c | 12 +-
drivers/staging/hv/channel_mgmt.c |4 +-
drivers/staging/hv/connection.c| 39 +++
drivers/staging/hv/vmbus_drv.c |6 ++--
drivers/
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/vmbus_drv.c | 50
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index b33f497..99686f0 100
On Wed, Jan 26, 2011 at 7:27 PM, Robert Jennings
wrote:
> By swapping the total_pages statistic with the lock we close a
> hole in the structure for 64-bit CPUs.
>
> Signed-off-by: Robert Jennings
Reviewed-by: Pekka Enberg
___
devel mailing list
deve
On Wed, Jan 26, 2011 at 7:23 PM, Robert Jennings
wrote:
> On a 64K page kernel, the value PAGE_SIZE passed to
> blk_queue_logical_block_size would overflow the logical block size
> argument (resulting in setting it to 0).
>
> Take the minimum of PAGE_SIZE or 4096 and use this for the block device
By swapping the total_pages statistic with the lock we close a
hole in the structure for 64-bit CPUs.
Signed-off-by: Robert Jennings
---
drivers/staging/zram/xvmalloc_int.h |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/zram/xvmalloc_int.h
b/drive
This wraps the code, noted by comments as being debug code, with
#ifdef DEBUG so that it is removed from running in non-debug kernels.
Signed-off-by: Robert Jennings
---
drivers/staging/zram/xvmalloc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/zr
There is no need to set the bits in the first- and second-level indices
to indicate a free page when we know that a free page existed at this
level.
Signed-off-by: Robert Jennings
---
drivers/staging/zram/xvmalloc.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/driver
Adding QUEUE_FLAG_NONROT for the in the request_queue flags. When used
as a swap device, scan_swap_map will avoid the extra work of optimizing
for rotating media.
Signed-off-by: Robert Jennings
---
drivers/staging/zram/zram_drv.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
xvmalloc will not currently function with 64K pages. Newly allocated
pages will be inserted at an offset beyond the end of the first-level
index. This tuning is needed to properly size the allocator for 64K
pages.
The default 3 byte shift results in a second level list size which can not
be inde
Calculate the first- and second-level indices for new page when the pool
is initialized rather than calculating them on each insertion.
Signed-off-by: Robert Jennings
---
drivers/staging/zram/xvmalloc.c | 13 +++--
drivers/staging/zram/xvmalloc_int.h |4
2 files changed, 1
On a 64K page kernel, the value PAGE_SIZE passed to
blk_queue_logical_block_size would overflow the logical block size
argument (resulting in setting it to 0).
Take the minimum of PAGE_SIZE or 4096 and use this for the block device
logical block size.
Signed-off-by: Robert Jennings
---
drivers/
The xvmalloc allocator is non-functional when running with a 64K page
size. The first two patches fix 64K page related issues.
The remaining patches provide some small optimizations for zram and
xvmalloc.
Regards,
Robert Jennings
___
devel mailing list
You are receiving this email because we wish you to use our 3D/2D animation
services.
We are a China based animation studio. We are specialized in providing 3D
designing/modelling/animation services across the globe. We utilize the finest
equipment available in the industry, offer efficient dat
Also when it does:
memcpy(ft1000dev->tx_buf, *pUcFile, byte_length);
That should probably be:
memcpy(ft1000dev->tx_buf, *pUcFile, word_length * 4);
Otherwise we're probably copying garbage from beyond the end of *pUcFile
to the ->tx_buf. ft1000dev->tx_buf is hopefully initialized
On Wed, Jan 26, 2011 at 2:43 PM, Dan Carpenter wrote:
> On Wed, Jan 26, 2011 at 04:07:18PM +0300, Dan Carpenter wrote:
>> You didn't introduce it but do you know what the code is trying to do
>> here?
>>
>> byte_length = word_length * 4;
>>
>> if (byte_length % 4)
>
> Actually this
On Wed, Jan 26, 2011 at 04:07:18PM +0300, Dan Carpenter wrote:
> You didn't introduce it but do you know what the code is trying to do
> here?
>
> byte_length = word_length * 4;
>
> if (byte_length % 4)
Actually this check is pointless. word_length * 4 is always
aligned at 4 byt
On Wed, Jan 26, 2011 at 2:07 PM, Dan Carpenter wrote:
> You didn't introduce it but do you know what the code is trying to do
> here?
>
> byte_length = word_length * 4;
>
> if (byte_length % 4)
> aligncnt = 4 - (byte_length % 4);
> else
> aligncnt
You didn't introduce it but do you know what the code is trying to do
here?
byte_length = word_length * 4;
if (byte_length % 4)
aligncnt = 4 - (byte_length % 4);
else
aligncnt = 0;
byte_length += aligncnt;
if (byte_length &&
Signed-off-by: Marek Belisko
---
.../staging/ft1000/ft1000-usb/ft1000_download.c| 934 +++-
1 files changed, 509 insertions(+), 425 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 1e12
Signed-off-by: Marek Belisko
---
.../staging/ft1000/ft1000-usb/ft1000_download.c| 56 +--
1 files changed, 27 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 2537a11
Same check was done on three places which make code unreadable.
Put repeat routine to separate function.
Signed-off-by: Marek Belisko
---
.../staging/ft1000/ft1000-usb/ft1000_download.c| 59 ++--
1 files changed, 29 insertions(+), 30 deletions(-)
diff --git a/drivers/stagi
Remove variables which was defined and assigned
but never used in function.
Signed-off-by: Marek Belisko
---
.../staging/ft1000/ft1000-usb/ft1000_download.c|4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
b/drive
dsp_img_info->version and requested_version have same type
so additional temporary variable creation could be omitted
because variables could be compares directly.
Signed-off-by: Marek Belisko
---
.../staging/ft1000/ft1000-usb/ft1000_download.c|7 +--
1 files changed, 1 insertions(+)
This compilation error was introduced by coding style fixes
series patch. Fix for problem (forgot to compile).
Signed-off-by: Marek Belisko
---
.../staging/ft1000/ft1000-usb/ft1000_download.c|2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/ft1000/ft10
57 matches
Mail list logo
