Re: [PATCH 01/15] staging: ath6kl: Update cfg80211 to recent calling convention changes

On Fri, Jan 28, 2011 at 10:35:54AM +0300, Dan Carpenter wrote: > On Thu, Jan 27, 2011 at 08:04:18PM -0800, Joe Perches wrote: > > Add bool unicast and bool multicast to set_default_key > > Return struct net_device * to add_virtual_intf > > Don't we have to update the callers when we change the fun

Re: [PATCH 01/15] staging: ath6kl: Update cfg80211 to recent calling convention changes

On Thu, Jan 27, 2011 at 08:04:18PM -0800, Joe Perches wrote: > Add bool unicast and bool multicast to set_default_key > Return struct net_device * to add_virtual_intf Don't we have to update the callers when we change the functions? I think this would break git bisect. What am I missing? regard

Re: [PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures with A_BOOL to u32

On Fri, Jan 28, 2011 at 7:04 AM, Joe Perches wrote: > From: Joe Perches > > These structures are device native and need to be 4 bytes long. > > Signed-off-by: Joe Perches > --- You should fix your email address here >  drivers/staging/ath6kl/include/common/wmi.h |   16 >  1 fi

[PATCH 15/15] staging: ath6kl: Convert tspecCompliance from A_BOOL to int

Make the use in wmi_verify_tspec_params match the declaration of the variable. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/include/wmi_api.h |2 +- drivers/staging/ath6kl/wmi/wmi.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ath

[PATCH 14/15] staging: ath6kl: Convert sets of scanSpecificSsid to TRUE/FALSE.

Don't use 0/1 for an A_BOOL. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/os/linux/wireless_ext.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/wireless_ext.c b/drivers/staging/ath6kl/os/linux/wireless_ext.c index dc32e2d.

[PATCH 13/15] staging: ath6kl: Convert A_NETBUF_QUEUE_EMPTY to return TRUE or FALSE

Make the return an A_BOOL not int. Signed-off-by: Joe Perches --- .../staging/ath6kl/os/linux/include/osapi_linux.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/include/osapi_linux.h b/drivers/staging/ath6kl/os/linux/include/osapi_li

[PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A_BOOL

Use A_BOOL as appropriate for actual variable uses. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os/linux/ar6000_drv

[PATCH 11/15] staging: ath6kl: cfg80211: Convert forceFgScan to A_UINT32

It's declared that way in the prototype, use it that way too. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/os/linux/cfg80211.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/cfg80211.c b/drivers/staging/ath6kl/os/linux/cfg802

[PATCH 10/15] staging: ath6kl: Convert 0 to FALSE

Convert a set of an A_BOOL from 0 to FALSE. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/os/linux/ar6000_android.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/ar6000_android.c b/drivers/staging/ath6kl/os/linux/ar6000_android

[PATCH 09/15] staging: ath6kl: Convert A_BOOL compressed sets from 0 to FALSE

Use the appropriate define. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os/linux/ar6000_drv.c index 3ad3d57..01ebdf

[PATCH 08/15] staging: ath6kl: Convert BDADDR_Present uses to TRUE/FALSE bugfix

The previous uses of BDADDR_Present set the initial value to A_ERROR (-1) when not present and A_OK (0) when present. A later test for (!BDADDR_Present) was therefore logically inverted. Convert the values to TRUE/FALSE and the test is now logically correct. Signed-off-by: Joe Perches --- .../s

[PATCH 06/15] staging: ath6kl: Convert bypasswmi to bool

Types should match logical uses. Remove unused extern, make static. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |8 drivers/staging/ath6kl/os/linux/ioctl.c |1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/a

[PATCH 07/15] staging: ath6kl: Convert type of streamExists to A_UINT8

Make the declaration type match the assigned from type. It's not a bool, it's a u8. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/wmi/wmi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ath6kl/wmi/wmi.c b/drivers/staging/ath6kl/wmi/wmi.c index

[PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures with A_BOOL to u32

From: Joe Perches These structures are device native and need to be 4 bytes long. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/include/common/wmi.h | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ath6kl/include/common/wmi.h b/dr

[PATCH 03/15] staging: ath6kl: Remove A_SUCCESS macro

Remove obfuscating A_SUCCESS(foo) macro. Just test for !foo instead. Reformat a few macros that used A_SUCCESS for better readability. Add do { foo } while (0) surrounds to those macros too. Signed-off-by: Joe Perches --- drivers/staging/ath6kl/bmi/src/bmi.c |2 +- .../staging

[PATCH 01/15] staging: ath6kl: Update cfg80211 to recent calling convention changes

Add bool unicast and bool multicast to set_default_key Return struct net_device * to add_virtual_intf Signed-off-by: Joe Perches --- drivers/staging/ath6kl/os/linux/cfg80211.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/cfg80211.c

[git pull-request and PATCH 00/15] staging: ath6kl: Cleanups

First block of many patches to be sent in blocks of 15. The following changes since commit af109f2e323e9dc6aeb49962e3bc0237ce653cb9: Staging: Westbridge: fix EXPORT_SYMBOL errors reported by checkpatch.pl (2011-01-26 15:02:53 +0800) are available in the git repository at: git://repo.or.cz/l

Re: [PATCH] Staging: comedi: Add MODULE_AUTHOR and similar to ni_pcimio.c.

On Thu, Jan 27, 2011 at 06:52:15PM -0500, W. Trevor King wrote: > Without this metadata, I got (while running 2.6.36) > # modprobe ni_pcimio > FATAL: Error inserting ni_pcimio (/.../ni_pcimio.ko): > Unknown symbol in module, or unknown parameter (see dmesg) > # dmesg | tail -n30 > ... >

Re: [PATCH 00/12]staging:tidspbridge - Remove hungarian notation from structures

On Mon, Jan 17, 2011 at 9:19 PM, Armando Uribe wrote: > This series of patches remove the hungarian notation from the structure's > elements. > Also the whole patch series has been rebased to the latest of tidspbridge > tree, > and minor corrections were made from the original version of Rene Sa

[PATCH] Staging: comedi: Add MODULE_AUTHOR and similar to ni_pcimio.c.

Without this metadata, I got (while running 2.6.36) # modprobe ni_pcimio FATAL: Error inserting ni_pcimio (/.../ni_pcimio.ko): Unknown symbol in module, or unknown parameter (see dmesg) # dmesg | tail -n30 ... [ 2970.180691] ni_pcimio: Unknown symbol ni_tio_handle_interrupt (err 0)

Re: [PATCH 03/12] rtl8192e: Delete dead code

On Thu, Jan 27, 2011 at 5:10 PM, Mike McCormack wrote: > Signed-off-by: Mike McCormack > --- >  drivers/staging/rtl8192e/r8190_rtl8256.c |   10 - >  drivers/staging/rtl8192e/r8192E_core.c   |   23 --- >  drivers/staging/rtl8192e/r8192E_dm.c     |   62 ++--- >  

Re: [PATCH 2/2] drivers/staging/msm/lcdc.c: Convert IS_ERR result to PTR_ERR

On Thu, Jan 27 2011, Julia Lawall wrote: > This code elsewhere returns a negative constant to an indicate an error, > while IS_ERR returns the result of a >= operation. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > Signed-off-by: Julia Lawall Ac

Professional CAD Drafting Services

CAD Drafting Services We are a China based studio providing innovative and cost effective CAD drafting and design solutions that provide value to business needs. We introduced ourselves with a vision to be the best rather than to be the biggest of all the players in the industry. We truly believe

[PATCH 2/2] drivers/staging/msm/lcdc.c: Convert IS_ERR result to PTR_ERR

This code elsewhere returns a negative constant to an indicate an error, while IS_ERR returns the result of a >= operation. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ if (...) { ... - return IS_ERR(x); + return PTR_ERR(x); } //

[PATCH 10/12] rtl8192e: Move static variable to device struct

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E.h |4 drivers/staging/rtl8192e/r8192E_core.c | 12 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E.h b/drivers/staging/rtl8192e/r8192E.h index 0189a3d..a8

[PATCH 12/12] rtl8192e: Remove #if 1 blocks

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E_core.c | 49 ++- 1 files changed, 10 insertions(+), 39 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E_core.c b/drivers/staging/rtl8192e/r8192E_core.c index 1958e73..fb16bef 100644 --- a/dr

[PATCH 11/12] rtl8192e: Move static variable to device struct

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E.h |1 + drivers/staging/rtl8192e/r8192E_core.c |7 +++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E.h b/drivers/staging/rtl8192e/r8192E.h index a8b69d3..a63a2a5 10

[PATCH 09/12] rtl8192e: Move static variable to device struct

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E.h |2 ++ drivers/staging/rtl8192e/r8192E_core.c | 11 +-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E.h b/drivers/staging/rtl8192e/r8192E.h index 0de74da..0189a

[PATCH 08/12] rtl8192e: Move static variable to device struct

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E.h |1 + drivers/staging/rtl8192e/r8192E_core.c | 18 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E.h b/drivers/staging/rtl8192e/r8192E.h index 0ec2c06

[PATCH 07/12] rtl8192e: Remove PF_SYNCTHREAD ifdefs

Signed-off-by: Mike McCormack --- .../staging/rtl8192e/ieee80211/ieee80211_softmac.c |4 drivers/staging/rtl8192e/r8192E_core.c |4 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c b/drivers/stagin

[PATCH 06/12] rtl8192e: Don't mess with carrier before registering device

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E_core.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E_core.c b/drivers/staging/rtl8192e/r8192E_core.c index 92c1910..5685d33 100644 --- a/drivers/staging/rtl8192e/r8192E_

[PATCH 05/12] rtl8192e: Remove support for legacy wireless extentions

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E_core.c | 12 ++-- drivers/staging/rtl8192e/r8192E_wx.c | 23 --- 2 files changed, 6 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E_core.c b/drivers/staging/rtl8192e/r

[PATCH 04/12] rtl8192e: Remove unused struct members

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E.h| 28 +++- drivers/staging/rtl8192e/r8192E_core.c | 11 --- drivers/staging/rtl8192e/r8192E_dm.c |2 -- drivers/staging/rtl8192e/r819xE_cmdpkt.c |3 --- 4 files changed, 3

[PATCH 03/12] rtl8192e: Delete dead code

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8190_rtl8256.c | 10 - drivers/staging/rtl8192e/r8192E_core.c | 23 --- drivers/staging/rtl8192e/r8192E_dm.c | 62 ++--- 3 files changed, 5 insertions(+), 90 deletions(-) diff --git a/driv

[PATCH 02/12] rtl8192e: Remove unused statistics

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E.h|1 - drivers/staging/rtl8192e/r819xE_cmdpkt.c |9 - 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E.h b/drivers/staging/rtl8192e/r8192E.h index 19fd188..358

[PATCH 01/12] rtl8192e: Remove variable that is never written

Signed-off-by: Mike McCormack --- drivers/staging/rtl8192e/r8192E.h |1 - drivers/staging/rtl8192e/r8192E_core.c |6 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/r8192E.h b/drivers/staging/rtl8192e/r8192E.h index 5f85872..19fd188 100