From: wwang
Delete a function named rtsx_transfer_sglist which won't be called.
Signed-off-by: wwang
---
drivers/staging/rts_pstor/rtsx_transport.c | 136
1 files changed, 0 insertions(+), 136 deletions(-)
diff --git a/drivers/staging/rts_pstor/rtsx_transport.c
From: wwang
Add static modifier before some functions and global variables.
Signed-off-by: wwang
---
drivers/staging/rts_pstor/ms.c |2 +-
drivers/staging/rts_pstor/rtsx.c |4 +-
drivers/staging/rts_pstor/rtsx_card.c |2 +-
drivers/staging/rts_pstor/rtsx_
Dear Greg:
Do you mean that exactly one modification corresponds to one patch? Such
as, if I add 2 static modifier and delete one function, I should send 3
patches?
wwang
于 2011年02月16日 10:09, Greg KH 写道:
> On Wed, Feb 16, 2011 at 09:43:38AM +0800, wei_w...@realsil.com.cn wrote:
>> From: wwang
>
On Wed, Feb 16, 2011 at 09:43:38AM +0800, wei_w...@realsil.com.cn wrote:
> From: wwang
>
> Add static modifier before some function definitions; delete function
> named rtsx_transfer_sglist which won't be called.
Thanks for describing this better.
And now that we can easily see that you are doi
On Tue, Feb 15, 2011 at 02:37:40PM -0800, Henry Ptasinski wrote:
> On 02/15/2011 02:12 PM, Stanislav Fomichev wrote:
> >Commit 59eb21a65047 "cfg80211: Extend channel to frequency mapping for
> >802.11j"
> >changed the definition of the ieee80211_channel_to_frequency; so fix its
> >usage in brcmfma
From: wwang
Add static modifier before some function definitions; delete function
named rtsx_transfer_sglist which won't be called.
Signed-off-by: wwang
---
drivers/staging/rts_pstor/ms.c |2 +-
drivers/staging/rts_pstor/rtsx.c |4 +-
drivers/staging/rts_pstor/rts
The attempt to enter to suspend mode can be hindered when the network
interface is disabled.
When system enters the suspend mode with the network interface
disabled, network layer calls ifdown() followed by cfg80211 layer
calling wl_cfg80211_suspend() which is registered as suspend handler
for cf
On 02/15/2011 02:12 PM, Stanislav Fomichev wrote:
Commit 59eb21a65047 "cfg80211: Extend channel to frequency mapping for 802.11j"
changed the definition of the ieee80211_channel_to_frequency; so fix its
usage in brcmfmac.
Commit 59eb21a65047 went into wireless-next a few weeks ago, but hasn't
Commit 59eb21a65047 "cfg80211: Extend channel to frequency mapping for 802.11j"
changed the definition of the ieee80211_channel_to_frequency; so fix its
usage in brcmfmac.
Signed-off-by: Stanislav Fomichev
---
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |4 +++-
1 files changed, 3 inser
> As some of the platform not support irq_to_gpio, we pass gpio port
> by platform data.
Looks good to me.
Signed-off-by: Andrew Chew
> Signed-off-by: Tony SIM
> ---
> drivers/staging/iio/magnetometer/ak8975.c |8 +++-
> include/linux/input/ak8975.h | 20 +++
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/vmbus_drv.c | 72 +++-
1 files changed, 56 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmb
On Tue, Feb 15, 2011 at 07:09:34PM +, Hank Janssen wrote:
>
> > > -Original Message-
> > > From: Greg KH [mailto:gre...@suse.de]
> > > Sent: Tuesday, February 15, 2011 9:23 AM
> > > > Before the end of the week I will submit two patches for this;
> > > >
> > > > Remove DPRINT a
> > -Original Message-
> > From: Greg KH [mailto:gre...@suse.de]
> > Sent: Tuesday, February 15, 2011 9:23 AM
> > > Before the end of the week I will submit two patches for this;
> > >
> > > Remove DPRINT and change it to printk
> >
> > No, use dev_dbg() and friends instead of "raw" prin
On Tue, Feb 15, 2011 at 05:52:46PM +, KY Srinivasan wrote:
>
> If I understand you correctly, you would be prefer to have unbounded waiting
> with comments
> justifying why we cannot have timeouts. I will roll out a patch once the tree
> stabilizes.
>
Just make sure to add a comment expla
> -Original Message-
> From: Greg KH [mailto:gre...@suse.de]
> Sent: Tuesday, February 15, 2011 11:30 AM
> To: KY Srinivasan
> Cc: Jiri Slaby; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org;
> virtualizat...@lists.osdl.org
> Subject: Re: [PATCH 2/3]: Staging: hv: Use native wa
> -Original Message-
> From: Greg KH [mailto:gre...@suse.de]
> Sent: Tuesday, February 15, 2011 9:23 AM
> > Before the end of the week I will submit two patches for this;
> >
> > Remove DPRINT and change it to printk
>
> No, use dev_dbg() and friends instead of "raw" printk() calls.
On Tue, Feb 15, 2011 at 04:53:41PM +, KY Srinivasan wrote:
> > > @@ -518,19 +534,23 @@ static int vmbus_bus_init(void)
> > > }
> > >
> > > /* Get the interrupt resource */
> > > - ret = request_irq(vmbus_irq, vmbus_isr, IRQF_SAMPLE_RANDOM,
> > > - driver->name, NULL);
> >
On Tue, Feb 15, 2011 at 04:59:28PM +, Hank Janssen wrote:
>
>
> > -Original Message-
> > From: KY Srinivasan
> > Sent: Tuesday, February 15, 2011 8:54 AM
> > > -Original Message-
> > > From: Greg KH [mailto:gre...@suse.de]
> > > Sent: Tuesday, February 15, 2011 11:00 AM
> > >
> -Original Message-
> From: KY Srinivasan
> Sent: Tuesday, February 15, 2011 8:54 AM
> > -Original Message-
> > From: Greg KH [mailto:gre...@suse.de]
> > Sent: Tuesday, February 15, 2011 11:00 AM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject
> -Original Message-
> From: Greg KH [mailto:gre...@suse.de]
> Sent: Tuesday, February 15, 2011 11:00 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org;
> virtualizat...@lists.osdl.org; Haiyang Zhang; Hank Janssen
> Subject: Re: [PATCH ]:Staging: hv:
On Tue, Feb 15, 2011 at 04:22:20PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@suse.de]
> > Sent: Tuesday, February 15, 2011 9:03 AM
> > To: KY Srinivasan
> > Cc: Jiri Slaby; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org;
> > virtua
On Tue, Feb 15, 2011 at 07:15:37AM -0800, K. Y. Srinivasan wrote:
>
> Signed-off-by: K. Y. Srinivasan
> Signed-off-by: Haiyang Zhang
> Signed-off-by: Hank Janssen
>
> ---
> drivers/staging/hv/vmbus_drv.c | 49 +++
> 1 files changed, 34 insertions(+), 15 d
> -Original Message-
> From: Greg KH [mailto:gre...@suse.de]
> Sent: Tuesday, February 15, 2011 9:03 AM
> To: KY Srinivasan
> Cc: Jiri Slaby; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org;
> virtualizat...@lists.osdl.org
> Subject: Re: [PATCH 2/3]: Staging: hv: Use native wai
On Tue, Feb 15, 2011 at 01:35:56PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Jiri Slaby [mailto:jirisl...@gmail.com]
> > Sent: Tuesday, February 15, 2011 4:21 AM
> > To: KY Srinivasan
> > Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> > devel@linuxdriverproject
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/vmbus_drv.c | 49 +++
1 files changed, 34 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbu
> -Original Message-
> From: Jiri Slaby [mailto:jirisl...@gmail.com]
> Sent: Tuesday, February 15, 2011 4:21 AM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: [PATCH 2/3]: Staging: hv: Us
On Tue, Feb 15, 2011 at 09:15:34AM +0800, wei_w...@realsil.com.cn wrote:
> From: wwang
>
> Fix some sparse warning
What sparse warnings did you fix?
You deleted whole functions, why?
Please provide a much more detailed description of your changes and
resend the patch.
thanks,
greg k-h
__
use %p instead of %X
drop casting of pointer to long long int
Cc: Mike Thomas
Signed-off-by: Tomas Winkler
---
drivers/staging/easycap/easycap_main.c | 34 +-
drivers/staging/easycap/easycap_sound.c |2 +-
drivers/staging/easycap/easycap_sound_oss.c |9
EASYCAP_NEEDS_V4L2_DEVICE_H and EASYCAP_NEEDS_V4L2_FOPS are required in
in-tree driver
Cc: Mike Thomas
Signed-off-by: Tomas Winkler
---
drivers/staging/easycap/Makefile|2 --
drivers/staging/easycap/easycap.h |6 --
drivers/staging/easycap/easycap_main.c |
remove pointless compilation flag
Cc: Mike Thomas
Signed-off-by: Tomas Winkler
---
drivers/staging/easycap/easycap.h |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/easycap/easycap.h
b/drivers/staging/easycap/easycap.h
index fe91257..e8ef1a2 100644
-
The return status of wl_ucode_init_buf() is now being used. Also a bug in
firmware validation, which could lead to incompatible firmware not being
rejected by the driver, has been fixed. Comment from Dan Carpenter on using
negative error values has been incorporated in this commit.
Signed-off-by:
On 02/15/2011 11:54 AM, Dan Carpenter wrote:
On Tue, Feb 15, 2011 at 11:13:52AM +0100, Roland Vossen wrote:
+ rc = rc || wl_ucode_init_buf(wl, (void **)&bcm43xx_bomminor,
+D11UCODE_OVERSIGHT_BOMMINOR);
+ return rc;
This returns 0 on success and 1
On Tue, Feb 15, 2011 at 11:13:52AM +0100, Roland Vossen wrote:
> + rc = rc || wl_ucode_init_buf(wl, (void **)&bcm43xx_bomminor,
> + D11UCODE_OVERSIGHT_BOMMINOR);
> + return rc;
This returns 0 on success and 1 on failure. Kernel style is to return
negative
Upon firmware load failure, wl_release_fw() was called multiple
times. This caused the driver to oops. Solution was to remove redundant
wl_release_fw() calls.
Signed-off-by: Roland Vossen
Reviewed-by: Arend van Spriel
---
drivers/staging/brcm80211/brcmsmac/wl_mac80211.c |2 --
1 files chang
The return status of wl_ucode_init_buf() is now being used. Also a bug in
firmware validation, which could lead to incompatible firmware not being
rejected by the driver, has been fixed.
Signed-off-by: Roland Vossen
Reviewed-by: Arend van Spriel
---
drivers/staging/brcm80211/brcmsmac/wl_mac8021
When no or incompatible firmware was present in /lib/firmware/brcm, the driver
could crash. This problem has been fixed and verified.
Signed-off-by: Roland Vossen
Reviewed-by: Arend van Spriel
staging: brcm80211: bugfix for oops on firmware load problems
staging: brcm80211: bugfix for stac
If there is a problem with the firmware load (eg, firmware not present in
/lib/firmware/brcm), then the driver would dump its stack instead of bailing
out gracefully. Root cause was an uninitialized variable (wl->pub) being
dereferenced in the rfkill portion of a cleanup routine (wl_remove). Fix wa
From: Tony SIM
As some of the platform not support irq_to_gpio, we pass gpio port
by platform data.
Signed-off-by: Tony SIM
---
drivers/staging/iio/magnetometer/ak8975.c |8 +++-
include/linux/input/ak8975.h | 20
2 files changed, 27 insertions(+), 1
On 02/11/2011 06:59 PM, K. Y. Srinivasan wrote:
> In preperation for getting rid of the osd layer; change
> the code to use native wait interfaces. As part of this,
> fixed the buggy implementation in the osd_wait_primitive
> where the condition was cleared potentially after the
> condition was si
From: wwang
Add const modifier before global variable realtek_cr_ids.
Signed-off-by: wwang
---
drivers/usb/storage/realtek_cr.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
index 4f6b25f..d509a4a 1
On 02/15/2011 02:38 AM, wei_w...@realsil.com.cn wrote:
> From: wwang
>
> Fix some sparse warning for realtek_cr patch
>
> Signed-off-by: wwang
> ---
> drivers/usb/storage/realtek_cr.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/realtek_
41 matches
Mail list logo
