[PATCH 13/21]drivers:staging:comedi:pcl816.c remove one to many l's in the word.

2011-02-24 Thread Justin P. Mattock
The patch below removes an extra "l" in the word. Signed-off-by: Justin P. Mattock --- drivers/staging/comedi/drivers/pcl816.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c index 3d0f0

[PATCH 16/21]drivers:staging:vt6655:device_main.c remove one to many l's in the word.

2011-02-24 Thread Justin P. Mattock
The patch below removes an extra "l" in the word. Signed-off-by: Justin P. Mattock --- drivers/staging/vt6655/device_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index f5028d9..8950c

[PATCH 15/21]drivers:staging:rtl8712:rtl871x_pwrctrl.c remove one to many l's in the word.

2011-02-24 Thread Justin P. Mattock
The patch below removes an extra "l" in the word. Signed-off-by: Justin P. Mattock --- drivers/staging/rtl8712/rtl871x_pwrctrl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.c b/drivers/staging/rtl8712/rtl871x_pwrctrl.c index

[PATCH 14/21]drivers:staging:comedi:pcl818.c remove one to many l's in the word.

2011-02-24 Thread Justin P. Mattock
The patch below removes an extra "l" in the word. Signed-off-by: Justin P. Mattock --- drivers/staging/comedi/drivers/pcl818.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index d2b

[PATCH 12/21]drivers:staging:vt6656:main_usb.c remove one to many l's in the word.

2011-02-24 Thread Justin P. Mattock
The patch below removes an extra "l" in the word. Signed-off-by: Justin P. Mattock --- drivers/staging/vt6656/main_usb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 7cc3d24..7b5b7c5 100644

RE: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@suse.de] > Sent: Thursday, February 24, 2011 7:32 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > virtualizat...@lists.osdl.org; Haiyang Zhang; Hank Janssen > Subject: Re: [PATCH ] Staging: hv:

Re: [PATCH] staging: gma500: Fix compilation error.

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 08:58:52PM +0100, Belisko Marek wrote: > Hi Greg, > > On Thu, Feb 24, 2011 at 6:12 PM, Greg KH wrote: > > On Thu, Feb 24, 2011 at 10:33:18AM +0100, Marek Belisko wrote: > >> This patch will fix following compilation error: > >> drivers/staging/gma500/psb_drv.c:1635: error:

Re: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread Greg KH
On Fri, Feb 25, 2011 at 12:24:57AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@suse.de] > > Sent: Thursday, February 24, 2011 6:46 PM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > > virtualizat...@li

RE: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@suse.de] > Sent: Thursday, February 24, 2011 6:46 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > virtualizat...@lists.osdl.org; Haiyang Zhang; Hank Janssen > Subject: Re: [PATCH ] Staging: hv:

Re: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 03:20:58PM -0800, K. Y. Srinivasan wrote: > This patch cleans up (a lot of the) naming issues that > various reviewers have noted. It also gets rid of > some unnecessary layering in the code. Whenever you have a patch description that says "It also..." you know you need to

[PATCH v2] staging: brcm80211: Fix memory leak after kmalloc failure

2011-02-24 Thread Stefan Weil
This error was spotted by cppcheck: drivers/staging/brcm80211/phy/wlc_phy_lcn.c:4053: error: Memory leak: ptr v2: Rebased patch on linux-next (file was moved to a new directory). Cc: Brett Rudley Cc: Henry Ptasinski Cc: Greg Kroah-Hartman Cc: linux-wirel...@vger.kernel.org Cc: de...@driverdev

Re: [PATCH] staging: brcm80211: Fix memory leak after kmalloc failure

2011-02-24 Thread Stefan Weil
Am 23.02.2011 23:05, schrieb Greg KH: On Sun, Feb 20, 2011 at 12:29:11AM +0100, Stefan Weil wrote: This error was spotted by cppcheck: drivers/staging/brcm80211/phy/wlc_phy_lcn.c:4053: error: Memory leak: ptr Cc: Brett Rudley Cc: Henry Ptasinski Cc: linux-wirel...@vger.kernel.org Cc: de...@d

Re: [PATCH] staging: gma500: Fix compilation error.

2011-02-24 Thread Belisko Marek
Hi Greg, On Thu, Feb 24, 2011 at 6:12 PM, Greg KH wrote: > On Thu, Feb 24, 2011 at 10:33:18AM +0100, Marek Belisko wrote: >> This patch will fix following compilation error: >> drivers/staging/gma500/psb_drv.c:1635: error: unknown field ‘pci_driver’ >> specified in initializer >> drivers/staging

Re: [PATCH 1/2] staging: remove null checks before kfree

2011-02-24 Thread Steven Rostedt
On Thu, 2011-02-24 at 19:08 +, Ilia Mirkin wrote: > FWIW my reasoning for doing this was that generally the reason you're > freeing something is because you allocated it, so kfree(NULL) happens > rarely -- error paths, conditional features, etc. If you actually > expect the argument to be NULL

Re: [PATCH 1/2] staging: remove null checks before kfree

2011-02-24 Thread Ilia Mirkin
On Thu, Feb 24, 2011 at 5:25 PM, Steven Rostedt wrote: > On Thu, 2011-02-24 at 09:06 -0800, Greg KH wrote: >> On Thu, Feb 24, 2011 at 11:08:29AM -0500, Steven Rostedt wrote: >> > On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote: >> > > This patch was created with the following semantic

Re: [PATCH 2/3] staging: brcm80211: removed locks around Mac80211 calls

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 10:50:28AM -0800, Brett Rudley wrote: > > So please work on removing all of them from the driver, it's one of the > > requirements to move out of the staging tree. > > > > We will. What are others? The more we know the more we can cleanup. Isn't the list in the TODO f

RE: [PATCH 2/3] staging: brcm80211: removed locks around Mac80211 calls

2011-02-24 Thread Brett Rudley
> So please work on removing all of them from the driver, it's one of the > requirements to move out of the staging tree. > We will. What are others? The more we know the more we can cleanup. Thanks brett ___ devel mailing list devel@linuxdriverp

Re: [PATCH 1/2] staging: remove null checks before kfree

2011-02-24 Thread Steven Rostedt
On Thu, 2011-02-24 at 09:06 -0800, Greg KH wrote: > On Thu, Feb 24, 2011 at 11:08:29AM -0500, Steven Rostedt wrote: > > On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote: > > > This patch was created with the following semantic patch: > > > > > > // > > > @@ > > > expression E; > > > @@

Re: [PATCH] staging: gma500: Fix compilation error.

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 10:33:18AM +0100, Marek Belisko wrote: > This patch will fix following compilation error: > drivers/staging/gma500/psb_drv.c:1635: error: unknown field ‘pci_driver’ > specified in initializer > drivers/staging/gma500/psb_drv.c:1636: error: unknown field ‘name’ specified >

Re: [PATCH 2/3] staging: brcm80211: removed locks around Mac80211 calls

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 11:30:53AM +0100, Roland Vossen wrote: > Hello Dan, > > >Yeah. We should delete the assert statement too because that's the > >easiest way to get rid of the warning. > > I use a little script that I wrote myself that checks a patch series > before submitting it. The scrip

Re: [PATCH 1/2] staging: remove null checks before kfree

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 11:08:29AM -0500, Steven Rostedt wrote: > On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote: > > This patch was created with the following semantic patch: > > > > // > > @@ > > expression E; > > @@ > > > > - if (E != NULL) kfree(E); > > + kfree(E); > > // > >

Re: [PATCH 1/2] staging: remove null checks before kfree

2011-02-24 Thread Steven Rostedt
On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote: > This patch was created with the following semantic patch: > > // > @@ > expression E; > @@ > > - if (E != NULL) kfree(E); > + kfree(E); > // OK, so when will we be removing the unlikely() from the implementations of kfree()?

CAN WE SINCERELY TRUST EACH OTHER ON THIS PLEASE?

2011-02-24 Thread Humphrey
Dear partner, May i confide in you?,and If yes, please i do have a reason for both of us, to enshrine total trust and confidence in my quest for you to be my foreign benefactor in this good live changing business. Honestly I want you to keep the payment of my 10% contract commission bill fro

Re: [PATCH] staging: gma500: Fix compilation error.

2011-02-24 Thread Alan Cox
On Thu, 24 Feb 2011 10:33:18 +0100 Marek Belisko wrote: > This patch will fix following compilation error: The joys of the DRM layer API of the week. Acked-by: Alan Cox ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverp

[PATCH] staging: brcm80211: removed compile warning

2011-02-24 Thread Roland Vossen
A warning was generated if CONFIG_BRCMDBG=n. Fixed this by introducing an function. Signed-off-by: Roland Vossen --- drivers/staging/brcm80211/brcmsmac/wl_mac80211.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c b/dri

Re: [PATCH 2/3] staging: brcm80211: removed locks around Mac80211 calls

2011-02-24 Thread Roland Vossen
Hello Dan, Yeah. We should delete the assert statement too because that's the easiest way to get rid of the warning. I use a little script that I wrote myself that checks a patch series before submitting it. The script builds each commit in the patch series in different configurations (eg,

[PATCH] staging: gma500: Fix compilation error.

2011-02-24 Thread Marek Belisko
This patch will fix following compilation error: drivers/staging/gma500/psb_drv.c:1635: error: unknown field ‘pci_driver’ specified in initializer drivers/staging/gma500/psb_drv.c:1636: error: unknown field ‘name’ specified in initializer drivers/staging/gma500/psb_drv.c:1636: warning: initializa