The problem is that everyone reading [patch 1/6] thinks you're renaming
hv_device to vm_device or introducing a new struct vm_device. That
makes people annoyed. If you had written the patch description like this:
In the original code, the structs vm_device included a struct
hv_device. T
On Wed, Mar 02, 2011 at 01:44:11AM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:g...@kroah.com]
> > Sent: Monday, February 28, 2011 9:59 PM
> > To: KY Srinivasan
> > Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> > devel@linuxdriverproject.org; vir
On Wed, Mar 02, 2011 at 01:43:13AM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:g...@kroah.com]
> > Sent: Monday, February 28, 2011 9:53 PM
> > To: KY Srinivasan
> > Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> > devel@linuxdriverproject.org; vir
On Wed, Mar 02, 2011 at 01:42:37AM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:g...@kroah.com]
> > Sent: Monday, February 28, 2011 9:44 PM
> > To: KY Srinivasan
> > Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> > devel@linuxdriverproject.org; vir
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, February 28, 2011 9:59 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang;
> Hank
> Janssen
> Subject: Re: [PA
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, February 28, 2011 9:53 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang;
> Hank
> Janssen
> Subject: Re: [PA
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, February 28, 2011 9:44 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang;
> Hank
> Janssen
> Subject: Re: [PA
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, February 28, 2011 9:33 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang;
> Hank
> Janssen
> Subject: Re: [PA
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, February 28, 2011 9:35 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang;
> Hank
> Janssen
> Subject: Re: [PA
/staging/brcm80211/sys/wl_mac80211.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20110301.orig/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
+++ linux-next-20110301/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
@@ -1376,7 +1376,7 @@ wl_cfg80211_
On Wed, Mar 02, 2011 at 12:10:16AM +0100, Jonathan Neuschäfer wrote:
> Signed-off-by: Jonathan Neuschäfer
> ---
Someone already fixed this in a different patch.
Generally these things aren't worth fixing on their own. No one
will even notice the whitespace unless they're looking for it.
regar
Signed-off-by: Jonathan Neuschäfer
---
drivers/staging/quickstart/quickstart.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/quickstart/quickstart.c
b/drivers/staging/quickstart/quickstart.c
index d83bec8..8648e1a 100644
--- a/drivers/staging/quickstar
Signed-off-by: Jonathan Neuschäfer
---
drivers/staging/echo/echo.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
index 58c4e90..3c188d5 100644
--- a/drivers/staging/echo/echo.c
+++ b/drivers/staging/echo/echo.c
On 03/01/2011 11:45 AM, Jiri Slaby wrote:
> On 02/25/2011 04:39 PM, Arend van Spriel wrote:
>> --- a/drivers/staging/brcm80211/util/hnddma.c
>> +++ b/drivers/staging/brcm80211/util/hnddma.c
>> @@ -32,6 +32,10 @@
>> #include
>> #endif
>>
>> +#ifdef BRCM_FULLMAC
>> +#error "hnddma.c shouldn't be
Drop the badly defined and broken private ioctl interface. Since the
driver is in staging, and some of the ioctls are clearly unsafe or not
even working, it's unlikely that there are any users.
Signed-off-by: Aaro Koskinen
---
drivers/staging/xgifb/XGI_main.h|9 --
drivers/staging/xgifb/
On Tue, Mar 01, 2011 at 02:44:37PM +0100, Arend van Spriel wrote:
> On Tue, 01 Mar 2011 14:26:18 +0100, Dan Carpenter
> wrote:
>
> >On Tue, Mar 01, 2011 at 10:56:58AM +0100, Arend van Spriel wrote:
> >>wlc_mac80211 has been renamed to wlc_main. This commit makes the
> >>required changes to the ot
On Tue, Mar 01, 2011 at 11:09:52AM +0100, Arend van Spriel wrote:
> This is replacing [PATCH3 4/6] posted earlier.
>
> The source and include file for the wlc_mac80211 module has been
> renamed to wlc_main and subsequently the include statement in
> other source files. This module provides the mai
On Tue, Mar 01, 2011 at 11:09:58AM +0100, Arend van Spriel wrote:
> On Tue, 01 Mar 2011 10:56:57 +0100, Arend van Spriel
> wrote:
>
> >The source and include file for the wlc_mac80211 module has been
> >renamed to wlc_main and subsequently the include statement in
> >other source files. This modu
removed the following defines as a side effect:
- FC_SUBTYPE_ANY_QOS
- FC_KIND_MASK
- FC_PROBE_REQ
- FC_PROBE_RESP
- FC_BEACON
- FC_PS_POLL
- FC_RTS
- FC_CTS
also fixed possible bug when the CPU byte ordered fc was passed into
ieee80211_is_data and ieee80211_is_mgmt
Signed-off-by: Stanislav Fomic
Signed-off-by: Stanislav Fomichev
---
drivers/staging/brcm80211/include/proto/802.11.h |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/brcm80211/include/proto/802.11.h
b/drivers/staging/brcm80211/include/proto/802.11.h
index 5cdfc7a..374125d 100644
---
Hello Greg,
This are the patches that were not clearly applied from my previous series.
They're based on the latest staging-2.6 (staging-next).
Stanislav Fomichev (2):
brcm80211: use proper ieee80211 routines
brcm80211: remove unused TLV defines
drivers/staging/brcm80211/brcmsmac/wlc_ampdu.
On Tue, Mar 01, 2011 at 08:29:50PM +0100, Roel Van Nyen wrote:
> Remove all type defines from driver and replace them with kernel built-in
> types.
>
> Signed-off-by: Roel Van Nyen
Some of your other patches were merged so this doesn't apply to
linux-next any more.
> -typedef u8 BOOLEAN;
It m
On Tue, Mar 01, 2011 at 04:37:55PM +0100, Javier Martinez Canillas wrote:
> >> ---
> >> drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c | 9 -
> >
> > This doesn't apply anymore, care to redo it and resend?
> >
> > thanks,
>
> Sure Greg but I tried with today linux-next and the patch
On Tue, Mar 01, 2011 at 04:37:55PM +0100, Javier Martinez Canillas wrote:
> >> ---
> >> drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c | 9 -
> >
> > This doesn't apply anymore, care to redo it and resend?
> >
> > thanks,
>
> Sure Greg but I tried with today linux-next and the patch
>> ---
>> drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c | 9 -
>
> This doesn't apply anymore, care to redo it and resend?
>
> thanks,
Sure Greg but I tried with today linux-next and the patch applies
cleanly. Maybe the problem are some patches that you have but haven't
reached linu
On 26/02/11 23:15, Manohar Vanga wrote:
> Remove some more unreachable code found in bridges/vme_ca91cx42.c
> and bridges/vme_tsi148.c
>
> Signed-off-by: Manohar Vanga
Acked-by Martyn Welch
> ---
> drivers/staging/vme/bridges/vme_ca91cx42.c |3 ---
> drivers/staging/vme/bridges/vme_tsi148
On 26/02/11 22:36, Manohar Vanga wrote:
> Remove some unreachable code (kfree calls) from vme.c
>
> Signed-off-by: Manohar Vanga
Acked-by: Martyn Welch
> ---
> drivers/staging/vme/vme.c |4
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.c
On Tue, Mar 01, 2011 at 01:50:23PM +, Alan Cox wrote:
> On Sat, 26 Feb 2011 15:48:12 +0300
> Dan Carpenter wrote:
>
> > These gotos were swapped. In the original code, the first would
> > result in a NULL dereference and the second would result in a memory
> > leak.
> >
> > Signed-off-by: D
On Sat, 26 Feb 2011 15:48:12 +0300
Dan Carpenter wrote:
> These gotos were swapped. In the original code, the first would
> result in a NULL dereference and the second would result in a memory
> leak.
>
> Signed-off-by: Dan Carpenter
Applied to my GMA500 tree. Need to sort out with GregKH how
On Tue, Mar 01, 2011 at 02:44:37PM +0100, Arend van Spriel wrote:
> On Tue, 01 Mar 2011 14:26:18 +0100, Dan Carpenter
> wrote:
>
> >On Tue, Mar 01, 2011 at 10:56:58AM +0100, Arend van Spriel wrote:
> >>wlc_mac80211 has been renamed to wlc_main. This commit makes the
> >>required changes to the ot
On Tue, Mar 01, 2011 at 11:09:52AM +0100, Arend van Spriel wrote:
> This is replacing [PATCH3 4/6] posted earlier.
>
> The source and include file for the wlc_mac80211 module has been
> renamed to wlc_main and subsequently the include statement in
> other source files. This module provides the mai
On Tue, Mar 01, 2011 at 10:56:59AM +0100, Arend van Spriel wrote:
> @@ -1293,18 +1293,24 @@ static int __init wl_module_init(void)
> wl_msg_level = msglevel;
> else {
> char *var = getvar(NULL, "wl_msglevel");
> - if (var)
> - wl_msg
On Tue, Mar 01, 2011 at 11:09:58AM +0100, Arend van Spriel wrote:
> On Tue, 01 Mar 2011 10:56:57 +0100, Arend van Spriel
> Should have used the -M option again :-( Please discard this patch
> and I will send a replacement patch.
>
The reason it doesn't apply is because you've got a patch merged i
On Tue, 01 Mar 2011 14:26:18 +0100, Dan Carpenter
wrote:
On Tue, Mar 01, 2011 at 10:56:58AM +0100, Arend van Spriel wrote:
wlc_mac80211 has been renamed to wlc_main. This commit makes the
required changes to the other driver files to make it compile again.
It would have been better to com
On Tue, Mar 01, 2011 at 10:56:58AM +0100, Arend van Spriel wrote:
> wlc_mac80211 has been renamed to wlc_main. This commit makes the
> required changes to the other driver files to make it compile again.
>
It would have been better to combine this one with 4/6 so that the
code compiles after ever
On 02/25/2011 04:39 PM, Arend van Spriel wrote:
> --- a/drivers/staging/brcm80211/util/hnddma.c
> +++ b/drivers/staging/brcm80211/util/hnddma.c
> @@ -32,6 +32,10 @@
> #include
> #endif
>
> +#ifdef BRCM_FULLMAC
> +#error "hnddma.c shouldn't be needed for FULLMAC"
> +#endif
> +
> /* debug/trace
On Tue, 01 Mar 2011 10:56:57 +0100, Arend van Spriel
wrote:
The source and include file for the wlc_mac80211 module has been
renamed to wlc_main and subsequently the include statement in
other source files. This module provides the main interface towards
wl_mac80211 module.
Reviewed-by: Rola
This is replacing [PATCH3 4/6] posted earlier.
The source and include file for the wlc_mac80211 module has been
renamed to wlc_main and subsequently the include statement in
other source files. This module provides the main interface towards
wl_mac80211 module.
Reviewed-by: Roland Vossen
Reviewe
wlc_antsel_attach was called with four parameters but actually
three parameters were already provided in the first parameter.
Reviewed-by: Roland Vossen
Reviewed-by: Brett Rudley
Signed-off-by: Arend van Spriel
---
drivers/staging/brcm80211/brcmsmac/wlc_antsel.c | 13 ++---
drivers
wlc_mac80211 has been renamed to wlc_main. This commit makes the
required changes to the other driver files to make it compile again.
Reviewed-by: Roland Vossen
Reviewed-by: Brett Rudley
Signed-off-by: Arend van Spriel
---
drivers/staging/brcm80211/brcmsmac/Makefile |2 +-
drivers/st
By checkpatch recommendation using strict_strtoul now.
Reviewed-by: Roland Vossen
Reviewed-by: Brett Rudley
Signed-off-by: Arend van Spriel
---
drivers/staging/brcm80211/brcmsmac/wl_mac80211.c | 28 +
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/driver
41 matches
Mail list logo
