Re: [PATCH 00/21] Coding style and minor changes in ft1000_hw.

2011-03-09 Thread Greg KH
On Mon, Mar 07, 2011 at 09:21:05AM +0100, Marek Belisko wrote: > Marek Belisko (21): > staging: ft1000: Replace camelcase CardSendCommand function name. > staging: ft1000: Fix coding style in card_send_command function. > staging: ft1000: Fix coding style in dsp_reload function. > staging:

Re: [PATCH] STAGING: brcm80211 fix TX Queue overflow

2011-03-09 Thread Greg KH
On Wed, Mar 09, 2011 at 10:41:25AM -0800, Grant Grundler wrote: > Increase QLEN to avoid TX Queue overflow. > iperf testing results in poor throughput and massive reporting of: > dhd_bus_txdata: out of bus->txq !!! > > Also renamed QLEN/et al to reflect usage as TX queue parameters. > Te

Re: [PATCH] Staging: comedi: coding style fix

2011-03-09 Thread Greg KH
On Tue, Mar 08, 2011 at 08:01:40PM -0800, Vinay Sawal wrote: > Fixed a brace coding style issue > > Signed-off-by: Vinay Sawal > --- > drivers/staging/comedi/drivers.c |4 ++-- What kernel tree did you do this against? Please do all patches against the linux-next tree as it looks like this

Re: [PATCH 2/3] staging: brcm80211: remove duplicated #include

2011-03-09 Thread Greg KH
On Wed, Mar 09, 2011 at 07:11:13AM +0800, Huang Weiyi wrote: > Remove duplicated #include('s) in > drivers/staging/brcm80211/sys/wlc_mac80211.c > > Signed-off-by: Huang Weiyi > --- > drivers/staging/brcm80211/sys/wlc_mac80211.c |1 - This file isn't in the linux-next tree, so I can't apply

[PATCH] STAGING: brcm80211 remove dhd_doflow

2011-03-09 Thread Grant Grundler
Remove dhd_doflow. iperf result without flow control is unacceptable. Signed-off-by: Grant Grundler --- tested on ARM tegra2_seaboard. Broadcom sent me a patch with "dhd_doflow = true" and I just don't see a use case for "= false". ergo remove it. diff --git a/drivers/staging/brcm80211/brcmfmac/

[PATCH] Staging: bcm: Bcmnet: fixed checkpatch script reported issues

2011-03-09 Thread Vinay Sawal
Fixed all issues reported by checkpatch script on this file. Signed-off-by: Vinay Sawal --- drivers/staging/bcm/Bcmnet.c | 31 --- 1 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c index a6ce

Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

2011-03-09 Thread Greg KH
On Wed, Mar 09, 2011 at 01:21:28PM -0800, Vinay Sawal wrote: > You're correct. The script checkpatch didn't complain about the > missing license header. Where did you get that license header from? Are you sure you were allowed to license the code in that specific way? > But since the license hea

Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

2011-03-09 Thread Vinay Sawal
On Wed, Mar 9, 2011 at 1:26 PM, Greg KH wrote: > On Wed, Mar 09, 2011 at 12:50:01PM -0800, Vinay Sawal wrote: >> Fixed all issues reported by checkpatch script on this file. >> >> Signed-off-by: Vinay Sawal >> --- >>  drivers/staging/bcm/Bcmnet.c |   51 >> +--

Re: [PATCH] staging: brcm80211: implementation of RFKILL functionality

2011-03-09 Thread Greg KH
On Wed, Mar 09, 2011 at 07:44:47PM +0100, Arend van Spriel wrote: > Resubmitted the patch to be included in the staging-linus branch. > > Only hardware switch state needs to be handled by driver. RFKILL is > informed when hardware switch is activated. MAC80211 rfkill_poll > callback is used to che

Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

2011-03-09 Thread Greg KH
On Wed, Mar 09, 2011 at 12:50:01PM -0800, Vinay Sawal wrote: > Fixed all issues reported by checkpatch script on this file. > > Signed-off-by: Vinay Sawal > --- > drivers/staging/bcm/Bcmnet.c | 51 + > 1 files changed, 36 insertions(+), 15 deletions(-) >

Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

2011-03-09 Thread Vinay Sawal
On Wed, Mar 9, 2011 at 12:55 PM, Belisko Marek wrote: > On Wed, Mar 9, 2011 at 9:50 PM, Vinay Sawal wrote: >> Fixed all issues reported by checkpatch script on this file. >> >> Signed-off-by: Vinay Sawal >> --- >>  drivers/staging/bcm/Bcmnet.c |   51 >> +

Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

2011-03-09 Thread Belisko Marek
On Wed, Mar 9, 2011 at 9:50 PM, Vinay Sawal wrote: > Fixed all issues reported by checkpatch script on this file. > > Signed-off-by: Vinay Sawal > --- >  drivers/staging/bcm/Bcmnet.c |   51 + >  1 files changed, 36 insertions(+), 15 deletions(-) > > diff --

[PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

2011-03-09 Thread Vinay Sawal
Fixed all issues reported by checkpatch script on this file. Signed-off-by: Vinay Sawal --- drivers/staging/bcm/Bcmnet.c | 51 + 1 files changed, 36 insertions(+), 15 deletions(-) diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c

Re: [PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

2011-03-09 Thread Vinay Sawal
On Wed, Mar 9, 2011 at 12:20 PM, Dan Carpenter wrote: > On Wed, Mar 09, 2011 at 11:50:54AM -0800, Vinay Sawal wrote: >> On Wed, Mar 9, 2011 at 9:36 AM, Dan Carpenter wrote: >> > On Tue, Mar 08, 2011 at 10:58:22PM -0800, Vinay Sawal wrote: >> >> Fixed all issues reported by 'checkpatch.pl' for thi

Re: [PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

2011-03-09 Thread Dan Carpenter
On Wed, Mar 09, 2011 at 11:50:54AM -0800, Vinay Sawal wrote: > On Wed, Mar 9, 2011 at 9:36 AM, Dan Carpenter wrote: > > On Tue, Mar 08, 2011 at 10:58:22PM -0800, Vinay Sawal wrote: > >> Fixed all issues reported by 'checkpatch.pl' for this file. > >> > >> Signed-off-by: Vinay Sawal > >> --- > >>

Re: [PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

2011-03-09 Thread Vinay Sawal
On Wed, Mar 9, 2011 at 9:36 AM, Dan Carpenter wrote: > On Tue, Mar 08, 2011 at 10:58:22PM -0800, Vinay Sawal wrote: >> Fixed all issues reported by 'checkpatch.pl' for this file. >> >> Signed-off-by: Vinay Sawal >> --- >> + >> +#define __NO_VERSION__ > > What do these __NO_VERSION__ defines do?

[PATCH] staging: brcm80211: implementation of RFKILL functionality

2011-03-09 Thread Arend van Spriel
Resubmitted the patch to be included in the staging-linus branch. Only hardware switch state needs to be handled by driver. RFKILL is informed when hardware switch is activated. MAC80211 rfkill_poll callback is used to check hardware switch deactivation. Reviewed-by: Brett Rudley Reviewed-by: He

[PATCH] staging: brcm80211: implementation of RFKILL functionality

2011-03-09 Thread Arend van Spriel
Resubmitted the patch to be included in the staging-linus branch. Only hardware switch state needs to be handled by driver. RFKILL is informed when hardware switch is activated. MAC80211 rfkill_poll callback is used to check hardware switch deactivation. Reviewed-by: Brett Rudley Reviewed-by: He

[PATCH] STAGING: brcm80211 fix TX Queue overflow

2011-03-09 Thread Grant Grundler
Increase QLEN to avoid TX Queue overflow. iperf testing results in poor throughput and massive reporting of: dhd_bus_txdata: out of bus->txq !!! Also renamed QLEN/et al to reflect usage as TX queue parameters. Tested with "dhd_doflow = true". Signed-off-by: Venkat Rao Sig

Re: [PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

2011-03-09 Thread Dan Carpenter
On Tue, Mar 08, 2011 at 10:58:22PM -0800, Vinay Sawal wrote: > Fixed all issues reported by 'checkpatch.pl' for this file. > > Signed-off-by: Vinay Sawal > --- > + > +#define __NO_VERSION__ What do these __NO_VERSION__ defines do? > #include "headers.h" regards, dan carpenter

Re: [PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

2011-03-09 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Mar 09, 2011 at 09:16:29AM -0800, Vinay Sawal wrote: > Sorry for the confusion. I used the same branch to generate two > unrelated patches. And that's probably why the second patch (this) > cam

Re: [PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

2011-03-09 Thread Vinay Sawal
Sorry for the confusion. I used the same branch to generate two unrelated patches. And that's probably why the second patch (this) came out the way it did. If you don't think that's the reason then I am sorry I don't know what's going on. I am new to the community and this is my first attempt at su

Re: [PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

2011-03-09 Thread Greg KH
On Tue, Mar 08, 2011 at 10:58:22PM -0800, Vinay Sawal wrote: > Fixed all issues reported by 'checkpatch.pl' for this file. Where is the 1/2 patch in this series? confused, greg k-h ___ devel mailing list devel@linuxdriverproject.org http://driverdev.li

Re: looking for more details on BCM4329, access to 802.11 header

2011-03-09 Thread Jason
On Wed, Mar 09, 2011 at 12:59:33AM -0500, George Nychis wrote: > This was a *huge* help to get this response from you, thanks a bunch for that. > No problem, I wish this particular idea could be higher on my project list. ;-) > I'd love to poke GregKG's staging tree and the mac80211 driver for t

Re: [PATCH 06/15] staging: xgifb: delete bIntegratedMMEnabled

2011-03-09 Thread Dan Carpenter
On Wed, Mar 09, 2011 at 10:23:01AM +0200, Aaro Koskinen wrote: > Hi, > > On Wed, 9 Mar 2011, Dan Carpenter wrote: > >On Tue, Mar 08, 2011 at 10:16:11PM +0200, Aaro Koskinen wrote: > >>bIntegratedMMEnabled is always true, so the field and checks can be > >>eliminated. > >> > >What about for the chi

Re: [PATCH 06/15] staging: xgifb: delete bIntegratedMMEnabled

2011-03-09 Thread Aaro Koskinen
Hi, On Wed, 9 Mar 2011, Dan Carpenter wrote: On Tue, Mar 08, 2011 at 10:16:11PM +0200, Aaro Koskinen wrote: bIntegratedMMEnabled is always true, so the field and checks can be eliminated. What about for the chips that came before the XG40? Are we dropping support for them? They were never