Kalle Valo writes:
> In maemo, to save power, we decreased the dynamic power save timeout
> whenever display was turned off. This was all done from user space and
> wifi driver in the kernel was completely unaware of the display state.
[...]
> And before someone suggests adding dynamic timeout
This was empty code, WTF^pi.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/include/common_drv.h |4 ---
drivers/staging/ath6kl/miscdrv/common_drv.c | 34 --
drivers/staging/ath6kl/os/linux/ar6000_drv.c |8 --
3 files changed
This uses ioctl, if this is required it should be replaced
with the nl80211 test command interface.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Kconfig |6 -
drivers/staging/ath6kl/Makefile|5 -
drivers/staging/ath
This will be passed along to the SDIO probe routine when
it fails. This will generate better error code to the user
when loading the module if it fails.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
.../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 12 ++--
1 files changed,
These do not help in any way.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
.../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif.c
b/drivers/staging/ath6kl/hi
This has no functional changes.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
.../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif.c
b/drivers/
When CONFIG_ATH6KL_ENABLE_COEXISTENCE gets enabled we define
another flag called ENABLE_COEXISTENCE, just use
CONFIG_ATH6KL_ENABLE_COEXISTENCE since that is already defined
by the generated autoconf header file from the kernel.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/stagi
There should be no need to assign the pm ops dynamically, so
assign them statically and make them const. While we are
doing this just do some simple code style cleanup on the
routines and move them above prior to their assignment
into the driver ops.
This has no functional change other than assign
Perhaps there was some good intention on having some platform
driver on ath6kl, but right now its pointless. Kill!
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/os/linux/ar6000_drv.c |6 --
drivers/staging/ath6kl/os/linux/ar6000_pm.c| 55 --
Removes verbose debug messages and checks that are just
not needed, and renames the functions to something more
sensible. While we clean this up, just move the routines
above and remove the forward declarations.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
.../staging/ath6kl/hif/sdio/l
No functional changes except renames of the routines and
id data structure.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
.../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 172 ++--
1 files changed, 85 insertions(+), 87 deletions(-)
diff --git a/drivers/staging/ath6
These map to do nothing.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/os/linux/ar6000_drv.c |3 ---
drivers/staging/ath6kl/os/linux/ar6000_pm.c|6 --
.../staging/ath6kl/os/linux/include/wlan_config.h |6 --
3 files changed, 0 in
Make the code more legible by parsing the config options on
the header file. While a it ensure to propagate errors and
bail out if we fail to set btcoex params.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 80 +++-
This propagates initial platform registration failures and
also HIF initialization failures.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
.../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 32 ---
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 12 ---
dr
When CONFIG_AR600x_WB31_XXX gets enabled we define
another flag called AR600x_WB31_XXX, just use
CONFIG_AR600x_WB31_XXX since that is already defined
by the generated autoconf header file from the kernel.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile
There already is a CONFIG_AR600x_CUSTOM_XXX if this is
desired to be used.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ath6kl/Makefile b/drivers/staging/ath6kl/M
When CONFIG_AR600x_SD32_XXX gets enabled we define
another flag called AR600x_SD32_XXX, just use
CONFIG_AR600x_SD32_XXX since that is already defined
by the generated autoconf header file from the kernel.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile
This was enabled by default but its pretty useless for upstream
given that its sendign some custom wireless event. These need
to be reviewed instead and a respective cfg80211 event / call
should be used later.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile
Since this is defined statically we just leave the code.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile|1 -
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 14 --
.../staging/ath6kl/os/linux/include/ar6000_drv.h
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile|1 -
drivers/staging/ath6kl/htc2/AR6000/ar6k.h |3 -
drivers/staging/ath6kl/include/a_config.h | 22
drivers/staging/ath6kl/include/a_debug.h |
This is always enabled.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile |1 -
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 12
drivers/staging/ath6kl/reorder/rcv_aggr.c|4
drivers/staging/ath6kl/wmi/wmi.c
When CONFIG_AR600x_SD31_XXX gets enabled we define
another flag called AR600x_SD31_XXX, just use
CONFIG_AR600x_SD31_XXX since that is already defined
by the generated autoconf header file from the kernel.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/ath6kl/Makefile b/drivers/staging/ath6kl/Makefile
index d7441e7..50f9be3 100644
--- a/drivers/staging/ath6kl/Makefile
+++
All the code is used so just keep it and remove the static define.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile|1 -
.../common/AR6002/hw4.0/hw/analog_intf_reg.h | 13 -
.../include/common/AR6002/hw4.0/hw/apb_m
This is always set so just keep the code it idefs around.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile|1 -
drivers/staging/ath6kl/htc2/htc.c |6 --
drivers/staging/ath6kl/htc2/htc_internal.h |8
drivers/stag
This is always defined so just keep the code.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile|1 -
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 11 ---
.../staging/ath6kl/os/linux/include/ar6000_drv.h |5 -
ath6kl used to have an internal PAL for Bluetooth 3.0 support
but this is no longer supported. The target used a WMI with an
ACL header for supporting these frames. Userspace would use
the ioctl AR6000_XIOCTL_ACL_DATA to send data to the target
and the firmware would generate ACL frames.
Remove bo
The check for SET_NETDEV_DEV is not required given that
this is upstream. The setting of the SET_NETDEV_DEV with
the osDevInfo.pOSDevice is redundant for the cfg80211 case
as this was already being done, so just set the netdev device
for the non-cfg80211 which was missing.
Cc: Naveen Singh
Signed
To get upstream we can't use out of tree defines, kill
all the androidisms. ath6kl won't be usable on Android
unless external patches are supported later or Android
gets their shit together and gets all their crap upstream.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/a
This is not required.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/os/linux/ar6000_drv.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c
b/drivers/staging/ath6kl/os/linux/ar6000_drv.c
index
for i in $(find ./drivers/staging/ath6kl/ -name \*.[ch]) ; do \
sed -r -i -e "s/A_FREE/kfree/g" $i; done
Tested-by: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/bmi/src/bmi.c |8 +++---
.../ath6kl/hif/sdio/linux_sdio/src/hif_scatter.c |
Leave the code in place as this is always defined statically.
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/Makefile|1 -
drivers/staging/ath6kl/os/linux/ar6000_android.c |2 -
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 66 -
This unwraps the do while loops in favor for function helpers.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 68 ++
1 files changed, 48 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/ath6kl/os/linux/a
When something fails we set up some generic error values,
instead keep the values from the callers and make sure to
pass them on.
Cc: Naveen Singh
Signed-off-by: Luis R. Rodriguez
---
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 51 --
1 files changed, 24 insertions(
Greg,
here's my third series of cleanup on ath6kl. Worth noting is the
removal of all that ioctl and Androd crap, and in total about 10K LOC of
cleanup. It also starts focusingon the initialization aspects of the driver,
with focus on passing more error values in places where it should have. The
c
Hey Greg, the staging-next branch seems pretty unstable right now, am
I the only one experiencing this?
Unfortunately I cannot debug what is making it unstable at the moment
though. Just curious -- can suck in new 2.6.38 stuff and also tags.
Also would it be too much trouble to ask for private bra
Replaced printk in hv_timesource with pr_ calls
Signed-off-by: Hank Janssen
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/hv_timesource.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/hv_timesource.c
b/driv
This patch set removes all un-needed DPRINT and printk calls and replaces
the remaining ones with the correct pr_, dev_ and netdev_ calls
from hv_vmbus, hv_netvsc, hv_timesource and hv_utils.
Several DPRINTS are remaining that will be cleaned up in my next
set of patches. They deal with printing
Replace all remaining DPRINT calls with their native dev_ and
netvsc_ calls. And also change some of the verbiage to be more useful.
rndis_filter has a few remaining DPRINT calls in it that will be removed
in a future patch because the debug will be implemented differently.
Signed-off-by: Hank Ja
Replaced all DPRINT and printk calls with pr_ calls
Signed-off-by: Hank Janssen
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/hv_kvp.c |6 +++---
drivers/staging/hv/hv_util.c | 17 +
2 files changed, 12 insertions(+), 11 deletions(-
Remove all un-needed DPRINT calls from hv_netvsc.
This patch deals with hv_netvsc only.
Signed-off-by: Hank Janssen
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/netvsc.c | 102 ++---
drivers/staging/hv/netvsc_drv.c
Replace all remaining DPRINT calls (excluding the ringbuffer debug
which is going to be done in a next set of patches) with their
native pr_ calls. And also changed some of the printouts to be more
useful.
Signed-off-by: Hank Janssen
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
Remove all un-needed DPRINT calls from hv_utils.
This patch deals with hv_utils only.
Signed-off-by: Hank Janssen
Signed-off-by: Haiyang Zhang
Signed-off-by: K. Y. Srinivasan
---
drivers/staging/hv/hv_kvp.c |3 ---
drivers/staging/hv/hv_util.c | 12
2 files changed, 0 ins
Remove all un-needed DPRINT calls from hv_vmbus. Several
are remaining that will be cleaned up in my next set of patches.
They deal with printing out the ringbuffer debugging which is
going to be implemented slightly differently.
This patch deals with hv_vmbus only.
Signed-off-by: Hank Janssen
S
44565
附 件中是; 跟 单 流 程
dev
FHvm457.xls
Description: Binary data
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
On Tue, Mar 29, 2011 at 11:40:18AM +0200, Arend van Spriel wrote:
> GUIDANCE NEEDED:
> This patch puts the module at proposed location. Please provide your
> guidance if there is a better location within the linux tree for this
> module.
>
> This module has been isolated from the brcm80211 driver
On Tue, Mar 29, 2011 at 11:40:18AM +0200, Arend van Spriel wrote:
> GUIDANCE NEEDED:
> This patch puts the module at proposed location. Please provide your
> guidance if there is a better location within the linux tree for this
> module.
>
> This module has been isolated from the brcm80211 driver
On Tue, Mar 29, 2011 at 11:40:18AM +0200, Arend van Spriel wrote:
> GUIDANCE NEEDED:
> This patch puts the module at proposed location. Please provide your
> guidance if there is a better location within the linux tree for this
> module.
>
> This module has been isolated from the brcm80211 driver
On Tue, Mar 29, 2011 at 02:03:36PM +0200, Roland Vossen wrote:
> The reason that I am investing time in the ASSERT/WARN_ON etc
> patches is that Greg KH does not want ASSERT statement in our
> driver. It would be great if I could simply replace all ASSERTs with
> WARN_ONs (inversing the condition c
On Tue, Mar 29, 2011 at 11:40:18AM +0200, Arend van Spriel wrote:
> GUIDANCE NEEDED:
> This patch puts the module at proposed location. Please provide your
> guidance if there is a better location within the linux tree for this
> module.
>
> This module has been isolated from the brcm80211 driver
On Tuesday 29 March 2011, Par-Gunnar Hjalmdahl wrote:
> This patch adds support for the ST-Ericsson CG2900
> Connectivity Combo controller (Bluetooth, FM, GPS).
>
> Signed-off-by: Par-Gunnar Hjalmdahl
> Acked-by: Linus Walleij
Acked-by: Arnd Bergmann
_
Hello Dan, Greg and John,
Greg and John: there is a request for you at the bottom of this email.
Dan, thanks for your elaborate answer on my questions/statements. I
appreciate the time you put into this. It cleared up quite some things
for me, so your typing was not in vain :-)
It doesn't t
This patch adds a driver for the ST-Ericsson CG2900 connectivity
controller.
It has earlier been tried to add this driver to the mfd and bluetooth
areas, but due to continued discussions the driver is placed into
staging for the moment.
Compared to v2 this patch has the following update:
- Remove
On 03/29/2011 11:40 AM, Arend van Spriel wrote:
> --- /dev/null
> +++ b/drivers/brcmaxi/axi.c
> @@ -0,0 +1,786 @@
...
> +/* resetctrl */
> +#define AIRC_RESET 1
> +
> +/* definition for specifying padding fields */
> +#define _PADLINE(line) pad ## line
> +#define _XSTR(
Acked-by: Roland Vossen
On 03/27/2011 11:31 PM, Stanislav Fomichev wrote:
Signed-off-by: Stanislav Fomichev
---
drivers/staging/brcm80211/include/bcmdevs.h | 69 +--
1 files changed, 2 insertions(+), 67 deletions(-)
diff --git a/drivers/staging/brcm80211/include/bc
The open-source community is looking for a library which will detect
cores in a chip using axi backplane. This is an initial delivery of
what it could look like. Tested it with the Broadcom open-source
mac80211 wireless driver located in drivers/staging/brcm80211.
Reviewed-by: Randy Dunlap
Review
GUIDANCE NEEDED:
This patch puts the module at proposed location. Please provide your
guidance if there is a better location within the linux tree for this
module.
This module has been isolated from the brcm80211 driver currently
located in staging and provided to other drivers for chipsets using
57 matches
Mail list logo
