There were hundreds of warnings, but now there's only four. These are
related to the 'volatile' keyword and printk(), which I think should be
left to the maintainers to modify if deemed necessary.
Signed-off-by: Daniel Kenji Toyama
---
drivers/staging/xgifb/vb_init.c | 527 +
Hello!!
I am Goh Eng Eam Francis, attorney at law with many years of practice. I was an
attorney to a late client of mine who died in Malay-sia of a heart related
condition in 2008. My reason of sending you this email is to help secure the
amount left behind by my client before it is confiscate
Not all warnings were silenced. One of them is a typedef in vb_ext.h
which I think seems alright.
The other warnings in vb_ext.c I left there because that would involve
changing a bit of the logic in the code. IMHO though I think the
functions are too complicated (i.e. the if/else are too deep with
I've removed all the warnings given by checkpatch.pl in vb_def.h and
also changed the indentation of pretty much the entire file so that it
is more consistent.
Signed-off-by: Daniel Kenji Toyama
---
drivers/staging/xgifb/vb_def.h | 1269
1 files changed,
Now get rid of IDE details from blkvsc_drv.c.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 55 +++---
drivers/staging/hv/storvsc.c| 18 ++--
2 files changed, 25 ins
This makes the license Operating System agnostic and updates
the patent license grant for use of the firmware license specifically
on the Atheros chipsets.
This allows us to share the same license between all Atheros chipsets,
ath9k, ath9k_htc, ath6kl, and future chipsets.
Cc: ath9k-de...@atheros
David,
the first patch was sent September, 1, 2010 but I just noticed that it was
never applied. I am resending that and now with the never-sent-before ath6kl
firmware...
Luis R. Rodriguez (2):
linux-firmware: update Atheros firmware license
linux-firmware: add ath6kl firmware
LICENCE.ather
One of the goto labels was named Cleanup; change it to cleanup.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/hv/bl
Get rid of some of the DPRINT_INFO() statements.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/sta
The Hyper-V block driver does not handle removable media.
Get rid of the code to manage removable media.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |9 +
1 files changed, 1 insertions(+), 8 deletions(
We are making up the geometry anyway, keep it simple.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 84 +-
1 files changed, 11 insertions(+), 73 deletions(-)
diff --git a/dri
Simplyfify blkvsc_init_rw() by using a single scsi command independent of
the start sector.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 58 +--
1 files changed, 13 insertion
In preparation for removing the IDE details from the block driver, implement
a function that maps channel properties to block device information.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/storvsc.c | 68 +++
The block driver in Hyper-V does not handle removable media, get rid of the
media_not_present state.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |9 +
1 files changed, 1 insertions(+), 8 deletions(-)
Get rid of some DPRINT_ERR() calls.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv
There are multiple functions to either get info about the device
(INQUIRY, CAPACITY etc) or to FLUSH the device cache. The majority of the
code for these functions is identical. Introduce a common function for
doing all these operations.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zha
Get rid of some of the DPRINT_DBG() statements.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 84 ---
1 files changed, 0 insertions(+), 84 deletions(-)
diff --git a/drivers/s
Given that we don't support removable media, cleanup blkvsc_open().
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 10 +-
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/hv/
We can support HDIO_GET_IDENTITY ioctl, enable blkvsc_ioctl().
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/hv/blkv
The block driver in Hyper-V does not support removable media, get rid of the
blkvsc_revalidate_disk().
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 17 -
1 files changed, 0 insertions(+), 17 del
It is never the case that the dev_add function pointer will not be set
(we set it in this code!). Get rid of this meaningless check.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |5 -
1 files changed, 0 ins
Now that we have a common function for some of the operations on the device,
use that and get rid of the function blkvsc_do_read_capacity().
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 117 +
storvsc_remove() cannot fail, clean it up accordingly.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/storvsc_drv.c | 14 ++
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/hv/storvsc
One of the jump labels was named Remove; change it to remove.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/hv/blkvsc_drv
Get rid of blkvsc_do_read_capacity16() and instead use the common function
for retrieving capacity.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 81 +--
1 files changed, 2 in
Get rid of the function blkvsc_do_flush() and instead use the common function
to force a device flush.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 52 ++
1 files changed, 14
blkvsc_remove() cannot fail. Clean it up accordingly.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 15 +++
1 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/hv/blkvsc_d
This is a resend of this patch-set.
More cleanup. In this patch-set we deal with the following issues:
1) While a Linux guest on Hyper-V can be assigned removable media
devices (DVD, floppy etc), these devices are not handled by the
Hyper-V block driver. So, we clean
Get rid of the forward declaration of blkvsc_cancel_pending_reqs() by moving
the code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 159 +++---
Get rid of the forward declaration of blkvsc_do_flush() by moving the code
around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 71 +++
1 files
Get rid of the forward declaration of blkvsc_ioctl() by moving the code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 56 ++
1 files chan
Get rid of the forward declaration for blkvsc_do_read_capacity() by moving
the code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 152 +++---
Get rid of the forward declaration of blkvsc_cmd_completion() by moving the
code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 48 +++---
1
Get rid of the forward declaration for blkvsc_release() by moving the code
around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 45 +++
1 files
Get rid of the forward declaration of blkvsc_shutdown() by moving the
code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 70 +++
1 files
Get rid of the forward declaration of blkvsc_revalidate_disk() by moving
the code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 31 +++
1 files c
Move some definitions/declarations to be earlier in the file.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --
Get rid of the forward declaration of blkvsc_do_read_capacity16() by moving
the code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 168 +++---
Get rid of some dead code in blkvsc_drv.c.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 26 --
1 files changed, 0 insertions(+), 26 deletions(-)
diff --git
Get rid of the forward declaration of blkvsc_remove() by moving the code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 130 +++---
1 files cha
Move module parameter to be earlier in the file.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/stag
Get rid of the forward declaration for blkvsc_do_request() by moving the
code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 370 ---
1 fil
Get rid of the forward declaration for blkvsc_do_inquiry() by moving the code
around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 158 +++---
1 file
Get rid of the forward declaration for blkvsc_do_pending_reqs() by moving
the code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 45 +++
Get rid of the forward declaration of blkvsc_init_rw() by moving the
code around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 117 ---
1 files c
Get rid of the forward declaration for blkvsc_request() by moving the code
around.
Signed-off-by: K. Y. Srinivasan
Signed-off-by: Haiyang Zhang
Signed-off-by: Abhishek Kane
Signed-off-by: Hank Janssen
---
drivers/staging/hv/blkvsc_drv.c | 86 +++---
1 files c
This is a resend of a previously sent patch-set.
This patch-set deals with some of the style isues in blkvsc_drv.c. We also
get rid most of the "dead code" in this file:
1) Get rid of most of the forward declarations in this file.
The only remaining forward declarations are to
> -Original Message-
> From: devel-boun...@linuxdriverproject.org [mailto:devel-
> boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan
> Sent: Thursday, April 21, 2011 8:41 PM
> To: Greg KH
> Cc: Abhishek Kane (Mindtree Consulting PVT LTD); Haiyang Zhang;
> gre...@suse.de; linux-ke
On 04/22/2011 08:19 PM, Michelle Konzack wrote:
> Hello Greg KH,
>
> Am 2011-04-21 14:29:01, hacktest Du folgendes herunter:
>> Why do you need to write a new driver? We already have such a driver in
>> the kernel today, have you tried it?
>
> Because this keyboard has much more functions (incl
Hello Greg KH,
Am 2011-04-21 14:29:01, hacktest Du folgendes herunter:
> Why do you need to write a new driver? We already have such a driver in
> the kernel today, have you tried it?
Because this keyboard has much more functions (including security) as
other ones and require a special driver
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Hi guys,
> Yes, why would a normal driver ever mess with a "raw" kobject or struct
> device? They would use the standard functions to properly handle this
> type of reference counting depending on their subsystem type (hint, you
> should be doing this from the network device structure functions..
52 matches
Mail list logo