On Sat, Jun 4, 2011 at 03:04, Henry Ptasinski wrote:
> On 06/01/2011 08:06 PM, Julian Calaby wrote:
>>
>> Roland,
>>
>> I've passed an eye over the entire patch set.
>
> Thanks for taking the time and putting in the effort to reveiw them all.
No problem!
>> 2. You shouldn't need to #ifdef on BIG
On Sat, Jun 4, 2011 at 02:58, Roland Vossen wrote:
> On 06/02/2011 05:06 AM, Julian Calaby wrote:
>>
>> Roland,
>>
>> I've passed an eye over the entire patch set.
>>
>> My comments are pretty minor, but I've replied to the patches that I
>> have concerns for. Please note that I'm not really a dev
On Sat, Jun 4, 2011 at 02:37, Roland Vossen wrote:
> Hello Julian,
>
> the structure definition itself is already in a header file (aiutils.h).
> Probably you are referring to the forward declaration used in the patch?
Exactly, it probably shouldn't be here as the header file that
includes the st
You are receiving this email because we wish you to use our 3D/2D animation
services.
We are a China based animation studio. We are specialized in providing 3D
designing/modelling/animation services across the globe. We utilize the finest
equipment available in the industry, offer efficient dat
You are receiving this email because we wish you to use our 3D/2D Animated
Movie/TV Series Services.
We are a China based Animated Movie/TV Series Studio. with the technical, our
studio is a animation studio with the technical, creative and production
capabilities to create a new generation of
On 6/1/2011 4:37:53 PM, Julian Calaby wrote:
On Wed, Jun 1, 2011 at 21:45, Roland Vossen wrote:
From: Franky Lin
Merge bcmcdc.h into dhd_cdc.c in fullmac as it's only used by
dhd_cdc.c
Signed-off-by: Franky Lin
Reviewed-by: Roland Vossen
Reviewed-by: Arend van Spriel
Again, you might want
On 06/01/2011 08:06 PM, Julian Calaby wrote:
Roland,
I've passed an eye over the entire patch set.
Thanks for taking the time and putting in the effort to reveiw them all.
My comments are pretty minor, but I've replied to the patches that I
have concerns for. Please note that I'm not really
On 06/02/2011 05:06 AM, Julian Calaby wrote:
Roland,
I've passed an eye over the entire patch set.
My comments are pretty minor, but I've replied to the patches that I
have concerns for. Please note that I'm not really a developer, and my
comments are mostly style issues, not actual functional
As a next step of this cleanup, you might want to turn these into
static inline functions instead of macros.
True, inline functions have better type safety. Arend van Spriel is
currently looking at interfacing the macro's (cc'ed), we will keep this
in mind.
Thanks, Roland.
_
Hello Julian,
the structure definition itself is already in a header file (aiutils.h).
Probably you are referring to the forward declaration used in the patch?
Bye, Roland.
On 06/02/2011 01:58 AM, Julian Calaby wrote:
On Wed, Jun 1, 2011 at 21:45, Roland Vossen wrote:
Code cleanup.
Signed
Use the normal include style.
Signed-off-by: Joe Perches
---
drivers/staging/msm/ebi2_l2f.c|2 +-
drivers/staging/msm/ebi2_tmd20.c |2 +-
drivers/staging/msm/mddihost.h|2 +-
drivers/staging/msm/mdp_ppp.c |2 +-
drivers/staging/msm/mdp_ppp_v20.c |2 +-
drivers/st
Just neatening.
Joe Perches (5):
drbd: Use angle brackets for system includes
drm: Use angle brackets for system includes
aix94xx: Use angle brackets for system includes
ALSA: asihpi: Use angle brackets for system includes
staging: msm: Use angle brackets for system includes
drivers/bl
12 matches
Mail list logo
