[patch] Staging: iio: dereferencing uninitialized variable

In the error handling, it dereferences "st" before it has been initialized. I also just tidied it up a bit to remove some extra conditions. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c index 98cebd2..72b0917 100644 --

Re: [PATCH] usbip: handle length at sysfs show() functions

Greg KH wrote: > On Wed, Jun 01, 2011 at 07:14:07AM +0200, Németh Márton wrote: >> The sysfs show() functions shall return the actual content length of >> the result buffer. According to Documentation/filesystems/sysfs.txt:215 >> the scnprintf() function is preferred. >> >> See also the article tit

Re: [PATCH] usbip: change match_busid() to local function

Forget it, this change is already there in the git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git , on staging-next branch. I just forget to switch the branch from master after cloning the staging-2.6 repository. Regards, Márton Németh Németh Márton wrote: > From: Márto

Re: [PATCH] usbip: change match_busid() to local function

From: Márton Németh The function match_busid() is only referenced in the stub_main.c so it can be changed to static. This will remove the following warning when compiling with "make W=1 ...": * drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’ Signed-off-

RE: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support auto-loading

> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, June 07, 2011 6:25 PM > To: KY Srinivasan > Cc: Christoph Hellwig; gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; > Abhishek Kane (Min

Re: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support auto-loading

On Tue, Jun 07, 2011 at 10:19:06PM +, KY Srinivasan wrote: > Thanks Greg. Can you give me some pointers here as to what needs to be > done here. Looking at the code for virtio, it looks like I would need to add > stuff > to scripts/mod/file2alias.c as well as to include/linux/mod_devicetable.h

RE: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support auto-loading

> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, June 07, 2011 2:58 PM > To: KY Srinivasan > Cc: Christoph Hellwig; gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; > Abhishek Kane (Min

RE: [PATCH 49/49] Staging: hv: vmbus: Increase the timeout value in vmbus_request_offers()

> -Original Message- > From: Greg KH [mailto:gre...@suse.de] > Sent: Tuesday, June 07, 2011 5:28 PM > To: KY Srinivasan > Cc: Greg KH; linux-ker...@vger.kernel.org; devel@linuxdriverproject.org; > virtualizat...@lists.osdl.org; Haiyang Zhang; Abhishek Kane (Mindtree > Consulting > PVT LT

Re: [PATCH] usbip: handle length at sysfs show() functions

On Wed, Jun 01, 2011 at 07:14:07AM +0200, Németh Márton wrote: > From: Márton Németh > > The sysfs show() functions shall return the actual content length of > the result buffer. According to Documentation/filesystems/sysfs.txt:215 > the scnprintf() function is preferred. > > See also the articl

Re: [PATCH] usbip: handle length at sysfs show() functions

On Wed, Jun 01, 2011 at 07:14:07AM +0200, Németh Márton wrote: > From: Márton Németh > > The sysfs show() functions shall return the actual content length of > the result buffer. According to Documentation/filesystems/sysfs.txt:215 > the scnprintf() function is preferred. > > See also the articl

Re: [PATCH] usbip: change match_busid() to local function

On Mon, May 30, 2011 at 10:09:39PM +0200, Németh Márton wrote: > From: Márton Németh > > The function match_busid() is only referenced in the stub_main.c so it can be > changed > to static. This will remove the following warning when compiling with "make > W=1 ...": > > * drivers/staging/usbi

Re: [PATCH 49/49] Staging: hv: vmbus: Increase the timeout value in vmbus_request_offers()

On Tue, Jun 07, 2011 at 09:20:16PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:g...@kroah.com] > > Sent: Tuesday, June 07, 2011 4:45 PM > > To: KY Srinivasan > > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > > devel@linuxdriverproject.org; virtua

RE: [PATCH 49/49] Staging: hv: vmbus: Increase the timeout value in vmbus_request_offers()

> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, June 07, 2011 4:45 PM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; > Abhishek Kane (Mindtree Consulting PV

Re: [PATCH 00/49] Staging: hv: Driver cleanup

On Mon, Jun 06, 2011 at 03:49:00PM -0700, K. Y. Srinivasan wrote: > Further cleanup of the hv drivers: > > 1) Continue to cleanup our drivers to conform to the Linux Driver > Model. > > 2) Fix some long standing bugs with regards to unloading and > reloading the dri

Re: [PATCH 15/49] Staging: hv: vmbus: Make vmbus an acpi bus driver

On Mon, Jun 06, 2011 at 03:49:39PM -0700, K. Y. Srinivasan wrote: > Now, make the vmbus driver an ACPI bus driver. Why an ACPI bus driver and not a PCI one? Is that what this really is? For some reason, I thought it was a PCI device that we hooked our bus off of, is that not true? greg k-h _

Re: [PATCH 49/49] Staging: hv: vmbus: Increase the timeout value in vmbus_request_offers()

On Mon, Jun 06, 2011 at 03:50:13PM -0700, K. Y. Srinivasan wrote: > Increase the timeout value in vmbus_request_offers(). Why? What does this solve/fix/prevent? thanks, greg k-h ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linu

Re: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper - vmbus_onchannel_event()

On Tue, Jun 07, 2011 at 07:58:50PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:g...@kroah.com] > > Sent: Tuesday, June 07, 2011 2:59 PM > > To: KY Srinivasan > > Cc: Christoph Hellwig; gre...@suse.de; linux-ker...@vger.kernel.org; > > devel@linuxdriver

RE: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper - vmbus_onchannel_event()

> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, June 07, 2011 2:59 PM > To: KY Srinivasan > Cc: Christoph Hellwig; gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; > Abhishek Kane (Min

Re: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper - vmbus_onchannel_event()

On Tue, Jun 07, 2011 at 02:59:32PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Christoph Hellwig [mailto:h...@infradead.org] > > Sent: Monday, June 06, 2011 7:15 PM > > To: KY Srinivasan > > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > > devel@linuxdriverprojec

Re: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support auto-loading

On Tue, Jun 07, 2011 at 02:54:25PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Christoph Hellwig [mailto:h...@infradead.org] > > Sent: Monday, June 06, 2011 7:13 PM > > To: KY Srinivasan > > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > > devel@linuxdriverprojec

RE: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper - vmbus_onchannel_event()

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Monday, June 06, 2011 7:15 PM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; > Abhishek Kane (Mindtree

RE: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support auto-loading

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Monday, June 06, 2011 7:13 PM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > devel@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; > Abhishek Kane (Mindtree

RE: [PATCH] staging iio: Replace kmalloc with local variable

Jonathan Cameron wrote on 2011-06-07: > On 06/07/11 14:41, Ben Dooks wrote: >> On Tue, Jun 07, 2011 at 02:00:23PM +0100, Jonathan Cameron wrote: >>> On 06/07/11 13:39, anish wrote: From: anish kumar replaced kmalloc with local variable as I2C(in this case) doesn't require kmall

Re: [PATCH] staging iio: Replace kmalloc with local variable

On Tue, 7 Jun 2011 14:41:35 +0100, Ben Dooks wrote: > On Tue, Jun 07, 2011 at 02:00:23PM +0100, Jonathan Cameron wrote: > > On 06/07/11 13:39, anish wrote: > > > From: anish kumar > > > > > > replaced kmalloc with local variable as I2C(in this case) doesn't require > > > kmalloc memory it can do

Re: [PATCH] staging iio: Replace kmalloc with local variable

On 06/07/11 14:41, Ben Dooks wrote: > On Tue, Jun 07, 2011 at 02:00:23PM +0100, Jonathan Cameron wrote: >> On 06/07/11 13:39, anish wrote: >>> From: anish kumar >>> >>> replaced kmalloc with local variable as I2C(in this case) doesn't require >>> kmalloc memory it can do with stack memory. >> I've

Re: [PATCH] staging iio: Replace kmalloc with local variable

On Tue, Jun 07, 2011 at 02:00:23PM +0100, Jonathan Cameron wrote: > On 06/07/11 13:39, anish wrote: > > From: anish kumar > > > > replaced kmalloc with local variable as I2C(in this case) doesn't require > > kmalloc memory it can do with stack memory. > I've cc'd linux-i2c just to check I'm right

Re: [PATCH] staging iio: Replace kmalloc with local variable

On 06/07/11 13:39, anish wrote: > From: anish kumar > > replaced kmalloc with local variable as I2C(in this case) doesn't require > kmalloc memory it can do with stack memory. I've cc'd linux-i2c just to check I'm right about the whole i2c doesn't need dma safe buffers bit... > > Signed-off-by:

[PATCH] staging iio: Replace kmalloc with local variable

From: anish kumar replaced kmalloc with local variable as I2C(in this case) doesn't require kmalloc memory it can do with stack memory. Signed-off-by: anish kumar --- drivers/staging/iio/adc/max1363_core.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/sta

Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

On 06/07/11 11:32, anish kumar wrote: > Jonathan Cameron wrote: >> On 06/07/11 05:56, anish singh wrote: >>> >>> >>> On Tue, Jun 7, 2011 at 4:11 AM, Greg KH >> > wrote: >>> >>> On Mon, Jun 06, 2011 at 03:28:29PM -0700, Joe Perches wrote: >>> > On Mon, 2011-06-06 at 15

Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

Jonathan Cameron wrote: On 06/07/11 05:56, anish singh wrote: On Tue, Jun 7, 2011 at 4:11 AM, Greg KH mailto:gre...@suse.de>> wrote: On Mon, Jun 06, 2011 at 03:28:29PM -0700, Joe Perches wrote: > On Mon, 2011-06-06 at 15:21 -0700, Greg KH wrote: > > On Mon, Jun 06, 2011 at 03:10:5

Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

On 06/07/11 05:56, anish singh wrote: > > > On Tue, Jun 7, 2011 at 4:11 AM, Greg KH > wrote: > > On Mon, Jun 06, 2011 at 03:28:29PM -0700, Joe Perches wrote: > > On Mon, 2011-06-06 at 15:21 -0700, Greg KH wrote: > > > On Mon, Jun 06, 2011 at 03:10:57PM -0700,

Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

On 06/06/11 23:10, Joe Perches wrote: > On Mon, 2011-06-06 at 14:55 -0700, Greg KH wrote: >> On Tue, Jun 07, 2011 at 12:37:37AM +0530, anish wrote: >>> From: anish kumar >>> Replace kmalloc with local variables as it was un-necessary and >>> also removed the redudant code after this change. >> SPI

[PATCH] Staging: Winbond: Fix assorted spacing issues.

Fix the phy_calibration.c file's spacing issues and convert the spaces to tabs. This reduces the number of errors and warnings returned by checkpatch.pl. Signed-off-by: Akshay Joshi --- drivers/staging/winbond/phy_calibration.c | 462 ++-- 1 files changed, 231 insertions