Re: [PATCH] staging:rts_pstor:modify thread synchronization flow

2011-08-03 Thread wwang
On 2011年08月03日 23:39, Greg KH wrote: > On Wed, Aug 03, 2011 at 04:00:25PM +0800, wei_w...@realsil.com.cn wrote: >> From: wwang >> >> Using different completion variables to synchronize different kernel threads >> >> Signed-off-by: wwang > Is this fixing a bug that is seen now, or is this just a n

Re: [PATCH] drivers:staging:add the missed include file

2011-08-03 Thread Wanlong Gao
On 08/04/2011 07:57 AM, Greg KH wrote: On Thu, Aug 04, 2011 at 07:52:21AM +0800, Wanlong Gao wrote: On 08/03/2011 07:15 PM, Belisko Marek wrote: On Wed, Aug 3, 2011 at 10:20 AM, Wanlong Gao wrote: Add the missed include file linux/io.h in ft1000_proc.c. What is the reason for that? I don't

Re: [PATCH] drivers:staging:add the missed include file

2011-08-03 Thread Greg KH
On Thu, Aug 04, 2011 at 07:52:21AM +0800, Wanlong Gao wrote: > On 08/03/2011 07:15 PM, Belisko Marek wrote: > >On Wed, Aug 3, 2011 at 10:20 AM, Wanlong Gao > >wrote: > >>Add the missed include file linux/io.h in ft1000_proc.c. > >What is the reason for that? I don't see any build error when compi

Re: [PATCH] drivers:staging:add the missed include file

2011-08-03 Thread Wanlong Gao
On 08/03/2011 07:15 PM, Belisko Marek wrote: On Wed, Aug 3, 2011 at 10:20 AM, Wanlong Gao wrote: Add the missed include file linux/io.h in ft1000_proc.c. What is the reason for that? I don't see any build error when compile today's linux-next. Signed-off-by: Wanlong Gao --- drivers/staging

Re: [PATCH v2] Staging: comedi: fix warning issue in pcl818.c

2011-08-03 Thread Ryan Mallon
On 03/08/11 23:49, Ravishankar wrote: From: Ravishankar This is a patch to the pcl818.c file that fixes up a printk(),brace coding style and initilise statics to NULL warning found by the checkpatch.pl tool Signed-off-by: Ravishankar There are still a multitude of issues with these patches,

ATM/13470/IDR

2011-08-03 Thread PRIME MINISTER'S OFFICE
PRIME MINISTER'S OFFICE TREASURY AND MINISTER FOR THE CIVIL SERVICE, LONDON, UNITED KINGDOM. Our ref: ATM/13470/IDR Your ref:...Date: 08/03/2011 IMMEDIATE PAYMENT NOTIFICATION I am The Rt Hon David Cameron MP,Prime Minister, First Lord of the Treasury and Minister for the Civil Service Bri

Re: [PATCH] staging:rts_pstor:modify thread synchronization flow

2011-08-03 Thread Greg KH
On Wed, Aug 03, 2011 at 04:00:25PM +0800, wei_w...@realsil.com.cn wrote: > From: wwang > > Using different completion variables to synchronize different kernel threads > > Signed-off-by: wwang Is this fixing a bug that is seen now, or is this just a nice "cleanup" patch that can wait for the 3

Re: [PATCH 5/8] staging: vme: add functions for bridge module refcounting

2011-08-03 Thread Emilio G. Cota
On Wed, Aug 03, 2011 at 16:06:30 +0200, Manohar Vanga wrote: > Hey Martyn, > > > Can we not do this inside vme_master_request, vme_slave_request, etc? > > > > I.e. Add reference count when resources are given out. > > > > This would then be done in the vme_*_free routines. > > I agree this woul

Re: [PATCH] zcache: include module.h for MODULE_LICENSE

2011-08-03 Thread Greg KH
On Wed, Aug 03, 2011 at 11:00:40AM -0300, Thadeu Lima de Souza Cascardo wrote: > The oncoming cleanup of module.h usage requires the explicit inclusion > of module.h when it was otherwise being included indirectly. Otherwise, > building zcache will fail. > > Signed-off-by: Thadeu Lima de Souza Cas

Re: [PATCH 5/8] staging: vme: add functions for bridge module refcounting

2011-08-03 Thread Manohar Vanga
Hey Martyn, > Can we not do this inside vme_master_request, vme_slave_request, etc? > > I.e. Add reference count when resources are given out. > > This would then be done in the vme_*_free routines. I agree this would be much better. I will change this and resend :) Thanks! -- /manohar ___

Re: [PATCH 5/8] staging: vme: add functions for bridge module refcounting

2011-08-03 Thread Martyn Welch
On 01/08/11 11:20, Manohar Vanga wrote: > This patch adds functions that allow for reference counting > bridge modules. The patch introduces the functions > 'vme_bridge_get()' and 'vme_bridge_put()'. > > This patch is based on the changes introduced by Emilio G. Cota > in the patch: > > https

[PATCH] zcache: include module.h for MODULE_LICENSE

2011-08-03 Thread Thadeu Lima de Souza Cascardo
The oncoming cleanup of module.h usage requires the explicit inclusion of module.h when it was otherwise being included indirectly. Otherwise, building zcache will fail. Signed-off-by: Thadeu Lima de Souza Cascardo --- drivers/staging/zcache/zcache-main.c |1 + 1 files changed, 1 insertions(

[PATCH v2] Staging: comedi: fix warning issue in pcl818.c

2011-08-03 Thread Ravishankar
From: Ravishankar This is a patch to the pcl818.c file that fixes up a printk(),brace coding style and initilise statics to NULL warning found by the checkpatch.pl tool Signed-off-by: Ravishankar --- drivers/staging/comedi/drivers/pcl818.c | 120 + 1 files ch

Re: [PATCH 8/8] staging: vme: make match() driver specific to improve non-VME64x support

2011-08-03 Thread Manohar Vanga
Hey Martyn, > I haven't got any hardware old enough to hand to play with how ISA devices get > bound into the device model. Neither do I! I studied the code in drivers/base/isa.c to understand how it is being done. More specifically, take a look at isa_register_driver() and isa_bus_match() and yo

Re: [PATCH] drivers:staging:add the missed include file

2011-08-03 Thread Belisko Marek
On Wed, Aug 3, 2011 at 10:20 AM, Wanlong Gao wrote: > Add the missed include file linux/io.h in ft1000_proc.c. What is the reason for that? I don't see any build error when compile today's linux-next. > > Signed-off-by: Wanlong Gao > --- >  drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c |    

Re: [PATCH v2] Staging: comedi: fix warning issue in pcl818.c

2011-08-03 Thread Dan Carpenter
You're still putting KERNEL_WARNING labels in the middle of the printed output instead of only at the start of the line. regards, dan carpenter ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/d

[PATCH] drivers:staging:solo6x10:add the missed slab.h

2011-08-03 Thread Wanlong Gao
Add the missed linux/slab.h to solo6x10.h. Signed-off-by: Wanlong Gao --- drivers/staging/solo6x10/solo6x10.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/solo6x10/solo6x10.h b/drivers/staging/solo6x10/solo6x10.h index 17c06bd..abee721 100644 --- a/dr

Re: [PATCH 8/8] staging: vme: make match() driver specific to improve non-VME64x support

2011-08-03 Thread Martyn Welch
On 01/08/11 11:20, Manohar Vanga wrote: > For jumper based boards (non VME64x), there is no mechanism > for detecting the card that is plugged into a specific slot. This > leads to issues in non-autodiscovery crates/cards when a card is > plugged into a slot that is "claimed" by a different driver.

Re: [PATCH] drivers:staging:remove the unused label error_ret

2011-08-03 Thread Jonathan Cameron
On 08/03/11 10:10, Wanlong Gao wrote: > remove the unused label error_ret in ad5791.c. Got that one in my tree as well. For reference, the current state of iio tree (including all sorts of fun unreviewed code and liable to be rebased several times a day is) git://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH] drivers:staging: remove the unused label

2011-08-03 Thread Jonathan Cameron
On 08/03/11 10:06, Wanlong Gao wrote: > remove the unused label error_ret in ad37854.c. > I have equivalent queued up locally, but you posted first which is fine by me. Thanks! Have also fixes for all current sparse / smatch and coccinelle checker issues (bar one set of false positives). > Sign

[PATCH] drivers:staging:remove the unused label error_ret

2011-08-03 Thread Wanlong Gao
remove the unused label error_ret in ad5791.c. Signed-off-by: Wanlong Gao --- drivers/staging/iio/dac/ad5791.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c index 64770d2..5b00b70 100644 --- a/drivers/

[PATCH] drivers:staging: remove the unused label

2011-08-03 Thread Wanlong Gao
remove the unused label error_ret in ad37854.c. Signed-off-by: Wanlong Gao --- drivers/staging/iio/meter/ade7854.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c index b82659f..ac3f9d5 100644 ---

Re: [PATCH 2/8] staging: vme: allow explicit assignment of bus numbers

2011-08-03 Thread Martyn Welch
On 02/08/11 15:57, Martyn Welch wrote: > > Which part of the example udev rule I gave is a fixed identifier? It > identifies the CDROM based on system topology, using the PCI bus numbering and > SCSI bus numbering. > > For example, for a device sitting on VME, in the A32 address space at 0x3,

[PATCH] drivers:staging:add the missed include file slab.h

2011-08-03 Thread Wanlong Gao
dt3155v4l.c has missed the linux/slab.h. Signed-off-by: Wanlong Gao --- drivers/staging/dt3155v4l/dt3155v4l.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dt3155v4l/dt3155v4l.c b/drivers/staging/dt3155v4l/dt3155v4l.c index fe02d22..05aa41c 100644 ---

[PATCH] drivers:staging:add the missed include file

2011-08-03 Thread Wanlong Gao
Add the missed include file linux/io.h in ft1000_proc.c. Signed-off-by: Wanlong Gao --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c b/drivers/staging/ft1000/ft1000-

[PATCH] staging:rts_pstor:modify thread synchronization flow

2011-08-03 Thread wei_wang
From: wwang Using different completion variables to synchronize different kernel threads Signed-off-by: wwang --- drivers/staging/rts_pstor/rtsx.c | 109 +++--- drivers/staging/rts_pstor/rtsx.h |9 +++- 2 files changed, 50 insertions(+), 68 deletions(-) di

[PATCH v2] Staging: comedi: fix warning issue in pcl818.c

2011-08-03 Thread Ravishnakar
From: Ravishankar This is a patch to the pcl818.c file that fixes up a printk(),brace coding style and initilise statics to NULL warning found by the checkpatch.pl tool Signed-off-by: Ravishankar --- drivers/staging/comedi/drivers/pcl818.c | 121 + 1 files ch